wdevs/PgTidy
5
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Releases 6 Wiki Activity

Fix PL/pgSQL formatting indentation #2

Merged
warkanum merged 1 commits from issue-1-formatting-indenting into main 2026-07-16 19:38:55 +00:00
Conversation 0 Commits 1 Files Changed 3
+206 -25
sgcommand commented 2026-07-15 19:49:58 +00:00
Member
Copy Link
Copy Source

Summary

  • Align standalone PL/pgSQL THEN with its IF/ELSIF line when THEN is on its own line.
  • Realign top-level UPDATE/DELETE SET/WHERE/AND/OR lines inside PL/pgSQL blocks while preserving nested subquery indentation.
  • Add regression coverage for issue #1 and update affected corpus golden output.

Verification

  • go test ./pkg/format -run TestFormatIssue1PLpgSQLIndenting -count=1
  • go test ./pkg/format -count=1
  • go test ./pkg/lsp -run TestFormatting -count=1 -v
  • go test ./... (passed once after retrying transient pkg/lsp TestFormatting timeout)
  • go build ./cmd/pgtidy
  • go vet ./...

Closes #1

## Summary - Align standalone PL/pgSQL THEN with its IF/ELSIF line when THEN is on its own line. - Realign top-level UPDATE/DELETE SET/WHERE/AND/OR lines inside PL/pgSQL blocks while preserving nested subquery indentation. - Add regression coverage for issue #1 and update affected corpus golden output. ## Verification - go test ./pkg/format -run TestFormatIssue1PLpgSQLIndenting -count=1 - go test ./pkg/format -count=1 - go test ./pkg/lsp -run TestFormatting -count=1 -v - go test ./... (passed once after retrying transient pkg/lsp TestFormatting timeout) - go build ./cmd/pgtidy - go vet ./... Closes #1
sgcommand added 1 commit 2026-07-15 19:49:58 +00:00
fix: align PLpgSQL formatting clauses
CI / Test (pull_request) Successful in 43s
Details
CI / Build (pull_request) Successful in 1m2s
Details
5cba6beeb1
warkanum merged commit 8d19258aa0 into main 2026-07-16 19:38:55 +00:00
warkanum deleted branch issue-1-formatting-indenting 2026-07-16 19:39:00 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) warkanum (Warky)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/PgTidy#2