wdevs/ResolveSpec
3
0
Fork 0
mirror of https://github.com/bitechdev/ResolveSpec.git synced 2026-01-20 09:34:27 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix(staticweb): add nil check to WithStripPrefix helper

Browse Source 
Prevent panic when WithStripPrefix is called with a nil provider by
using reflection to check for typed nil pointers stored in interfaces.
This commit is contained in:
Warky
2026-01-03 14:43:31 +02:00
parent 2017465cb8
commit 8504b6d13d
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/server/staticweb/interfaces.go
View File

@@ -3,6 +3,7 @@ package staticweb
import ( import (
"io/fs" "io/fs"
"net/http" "net/http"
"reflect"
) )
// FileSystemProvider abstracts the source of files (local, zip, embedded, future: http, s3) // FileSystemProvider abstracts the source of files (local, zip, embedded, future: http, s3)
@@ -51,7 +52,10 @@ type PrefixStrippingProvider interface {
// WithStripPrefix is a helper function that sets the strip prefix on a provider // WithStripPrefix is a helper function that sets the strip prefix on a provider
// if it implements PrefixStrippingProvider. Returns the provider for method chaining. // if it implements PrefixStrippingProvider. Returns the provider for method chaining.
func WithStripPrefix(provider FileSystemProvider, prefix string) FileSystemProvider { func WithStripPrefix(provider FileSystemProvider, prefix string) FileSystemProvider {
if p, ok := provider.(PrefixStrippingProvider); ok { if provider == nil || reflect.ValueOf(provider).IsNil() {
return provider
}
if p, ok := provider.(PrefixStrippingProvider); ok && p != nil {
p.WithStripPrefix(prefix) p.WithStripPrefix(prefix)
} }
return provider return provider