wdevs/ResolveSpec
3
0
Fork 0
mirror of https://github.com/bitechdev/ResolveSpec.git synced 2026-01-05 11:24:26 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Update pkg/server/manager.go

Browse Source 
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This commit is contained in:
Hein Puth (Warkanum)
2025-12-30 12:58:38 +02:00
committed by GitHub
parent feb023ec48
commit 8adc386863
1 changed files with 8 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
pkg/server/manager.go
View File

@@ -217,8 +217,14 @@ func (sm *serverManager) Remove(name string) error {
return fmt.Errorf("server with name '%s' not found", name) return fmt.Errorf("server with name '%s' not found", name)
} }
// Stop the server if it's running // Stop the server if it's running. Prefer the server's configured shutdownTimeout
ctx, cancel := context.WithTimeout(context.Background(), 10*time.Second) // when available, and fall back to a sensible default.
timeout := 10 * time.Second
if gs, ok := instance.(*gracefulServer); ok && gs.shutdownTimeout > 0 {
timeout = gs.shutdownTimeout
}
ctx, cancel := context.WithTimeout(context.Background(), timeout)
defer cancel() defer cancel()
if err := instance.Stop(ctx); err != nil { if err := instance.Stop(ctx); err != nil {
logger.Warn("Failed to gracefully stop server '%s' on remove: %v", name, err) logger.Warn("Failed to gracefully stop server '%s' on remove: %v", name, err)