mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-05-16 00:35:18 +00:00
fix(sql_helpers): strip empty RHS conditions from SQL strings
* Add regex patterns to identify and remove empty comparisons * Implement tests for stripping empty RHS conditions fix(handler): prevent duplicate JOIN aliases from preload * Skip custom SQL JOINs if alias already provided by preload * Split multiple JOIN clauses for individual alias handling
This commit is contained in:
@@ -575,11 +575,25 @@ func (h *Handler) handleRead(ctx context.Context, w common.ResponseWriter, id st
|
||||
}
|
||||
}
|
||||
|
||||
// Apply custom SQL JOIN clauses
|
||||
// Apply custom SQL JOIN clauses, skipping any whose alias is already provided by a
|
||||
// preload LEFT JOIN (to prevent "table name specified more than once" errors).
|
||||
if len(options.CustomSQLJoin) > 0 {
|
||||
for _, joinClause := range options.CustomSQLJoin {
|
||||
preloadAliasSet := make(map[string]bool, len(options.Preload))
|
||||
for _, p := range options.Preload {
|
||||
if alias := common.RelationPathToBunAlias(p.Relation); alias != "" {
|
||||
preloadAliasSet[alias] = true
|
||||
}
|
||||
}
|
||||
|
||||
for i, joinClause := range options.CustomSQLJoin {
|
||||
if i < len(options.JoinAliases) && options.JoinAliases[i] != "" {
|
||||
alias := strings.ToLower(options.JoinAliases[i])
|
||||
if preloadAliasSet[alias] {
|
||||
logger.Debug("Skipping custom SQL JOIN (alias '%s' already joined by preload): %s", alias, joinClause)
|
||||
continue
|
||||
}
|
||||
}
|
||||
logger.Debug("Applying custom SQL JOIN: %s", joinClause)
|
||||
// Joins are already sanitized during parsing, so we can apply them directly
|
||||
query = query.Join(joinClause)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -5,6 +5,7 @@ import (
|
||||
"encoding/json"
|
||||
"fmt"
|
||||
"reflect"
|
||||
"regexp"
|
||||
"strconv"
|
||||
"strings"
|
||||
|
||||
@@ -501,6 +502,31 @@ func (h *Handler) parseExpand(options *ExtendedRequestOptions, value string) {
|
||||
}
|
||||
}
|
||||
|
||||
// reMultiJoinBoundary finds the start of each individual JOIN clause within a string that
|
||||
// may contain multiple consecutive JOIN clauses (e.g., "INNER JOIN ... LEFT OUTER JOIN ...").
|
||||
var reMultiJoinBoundary = regexp.MustCompile(`(?i)(?:inner|left(?:\s+outer)?|right(?:\s+outer)?|full(?:\s+outer)?|cross)\s+join\b`)
|
||||
|
||||
// splitJoinClauses splits a SQL string that may contain multiple JOIN clauses into
|
||||
// individual clauses. A plain pipe-separated segment may itself contain several JOINs;
|
||||
// this function splits them so each gets its own alias entry.
|
||||
func splitJoinClauses(joinStr string) []string {
|
||||
indices := reMultiJoinBoundary.FindAllStringIndex(joinStr, -1)
|
||||
if len(indices) <= 1 {
|
||||
return []string{strings.TrimSpace(joinStr)}
|
||||
}
|
||||
parts := make([]string, 0, len(indices))
|
||||
for i, idx := range indices {
|
||||
end := len(joinStr)
|
||||
if i+1 < len(indices) {
|
||||
end = indices[i+1][0]
|
||||
}
|
||||
if part := strings.TrimSpace(joinStr[idx[0]:end]); part != "" {
|
||||
parts = append(parts, part)
|
||||
}
|
||||
}
|
||||
return parts
|
||||
}
|
||||
|
||||
// parseCustomSQLJoin parses x-custom-sql-join header
|
||||
// Format: Single JOIN clause or multiple JOIN clauses separated by |
|
||||
// Example: "LEFT JOIN departments d ON d.id = employees.department_id"
|
||||
@@ -533,17 +559,19 @@ func (h *Handler) parseCustomSQLJoin(options *ExtendedRequestOptions, value stri
|
||||
continue
|
||||
}
|
||||
|
||||
// Extract table alias from the JOIN clause
|
||||
alias := extractJoinAlias(sanitizedJoin)
|
||||
if alias != "" {
|
||||
// Split into individual JOIN clauses so each clause gets its own alias entry.
|
||||
// CustomSQLJoin and JoinAliases are kept parallel (one entry per individual clause).
|
||||
for _, clause := range splitJoinClauses(sanitizedJoin) {
|
||||
alias := extractJoinAlias(clause)
|
||||
// Keep arrays parallel; use empty string when alias cannot be extracted.
|
||||
options.JoinAliases = append(options.JoinAliases, alias)
|
||||
// Also add to the embedded RequestOptions for validation
|
||||
options.RequestOptions.JoinAliases = append(options.RequestOptions.JoinAliases, alias)
|
||||
logger.Debug("Extracted join alias: %s", alias)
|
||||
if alias != "" {
|
||||
logger.Debug("Extracted join alias: %s", alias)
|
||||
}
|
||||
logger.Debug("Adding custom SQL join: %s", clause)
|
||||
options.CustomSQLJoin = append(options.CustomSQLJoin, clause)
|
||||
}
|
||||
|
||||
logger.Debug("Adding custom SQL join: %s", sanitizedJoin)
|
||||
options.CustomSQLJoin = append(options.CustomSQLJoin, sanitizedJoin)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
Reference in New Issue
Block a user