mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-05-18 17:55:16 +00:00
Compare commits
6 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
c42fa11c1a | ||
|
|
85bb0f7874 | ||
|
|
cd65946191 | ||
|
|
cb416d49c4 | ||
|
|
cb921f2c5e | ||
|
|
1ebe0d7ac3 |
@@ -1451,6 +1451,18 @@ func (b *BunInsertQuery) Returning(columns ...string) common.InsertQuery {
|
|||||||
return b
|
return b
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (b *BunInsertQuery) prepareValues() {
|
||||||
|
if len(b.values) > 0 {
|
||||||
|
if !b.hasModel {
|
||||||
|
b.query = b.query.Model(&b.values)
|
||||||
|
} else {
|
||||||
|
for k, v := range b.values {
|
||||||
|
b.query = b.query.Value(k, "?", v)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func (b *BunInsertQuery) Exec(ctx context.Context) (res common.Result, err error) {
|
func (b *BunInsertQuery) Exec(ctx context.Context) (res common.Result, err error) {
|
||||||
defer func() {
|
defer func() {
|
||||||
if r := recover(); r != nil {
|
if r := recover(); r != nil {
|
||||||
@@ -1458,23 +1470,25 @@ func (b *BunInsertQuery) Exec(ctx context.Context) (res common.Result, err error
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
startedAt := time.Now()
|
startedAt := time.Now()
|
||||||
if len(b.values) > 0 {
|
b.prepareValues()
|
||||||
if !b.hasModel {
|
|
||||||
// If no model was set, use the values map as the model
|
|
||||||
// Bun can insert map[string]interface{} directly
|
|
||||||
b.query = b.query.Model(&b.values)
|
|
||||||
} else {
|
|
||||||
// If model was set, use Value() to add individual values
|
|
||||||
for k, v := range b.values {
|
|
||||||
b.query = b.query.Value(k, "?", v)
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
result, err := b.query.Exec(ctx)
|
result, err := b.query.Exec(ctx)
|
||||||
recordQueryMetrics(b.metricsEnabled, "INSERT", b.schema, b.entity, b.tableName, startedAt, err)
|
recordQueryMetrics(b.metricsEnabled, "INSERT", b.schema, b.entity, b.tableName, startedAt, err)
|
||||||
return &BunResult{result: result}, err
|
return &BunResult{result: result}, err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (b *BunInsertQuery) Scan(ctx context.Context, dest interface{}) (err error) {
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
err = logger.HandlePanic("BunInsertQuery.Scan", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
startedAt := time.Now()
|
||||||
|
b.prepareValues()
|
||||||
|
err = b.query.Scan(ctx, dest)
|
||||||
|
recordQueryMetrics(b.metricsEnabled, "INSERT", b.schema, b.entity, b.tableName, startedAt, err)
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
|
||||||
// BunUpdateQuery implements UpdateQuery for Bun
|
// BunUpdateQuery implements UpdateQuery for Bun
|
||||||
type BunUpdateQuery struct {
|
type BunUpdateQuery struct {
|
||||||
query *bun.UpdateQuery
|
query *bun.UpdateQuery
|
||||||
|
|||||||
@@ -3,11 +3,13 @@ package database
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"reflect"
|
||||||
"strings"
|
"strings"
|
||||||
"sync"
|
"sync"
|
||||||
"time"
|
"time"
|
||||||
|
|
||||||
"gorm.io/gorm"
|
"gorm.io/gorm"
|
||||||
|
"gorm.io/gorm/clause"
|
||||||
|
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
@@ -676,15 +678,16 @@ func (g *GormSelectQuery) Exists(ctx context.Context) (exists bool, err error) {
|
|||||||
|
|
||||||
// GormInsertQuery implements InsertQuery for GORM
|
// GormInsertQuery implements InsertQuery for GORM
|
||||||
type GormInsertQuery struct {
|
type GormInsertQuery struct {
|
||||||
db *gorm.DB
|
db *gorm.DB
|
||||||
reconnect func(...*gorm.DB) error
|
reconnect func(...*gorm.DB) error
|
||||||
model interface{}
|
model interface{}
|
||||||
values map[string]interface{}
|
values map[string]interface{}
|
||||||
schema string
|
schema string
|
||||||
tableName string
|
tableName string
|
||||||
entity string
|
entity string
|
||||||
driverName string
|
driverName string
|
||||||
metricsEnabled bool
|
metricsEnabled bool
|
||||||
|
returningColumns []string
|
||||||
}
|
}
|
||||||
|
|
||||||
func (g *GormInsertQuery) Model(model interface{}) common.InsertQuery {
|
func (g *GormInsertQuery) Model(model interface{}) common.InsertQuery {
|
||||||
@@ -718,7 +721,7 @@ func (g *GormInsertQuery) OnConflict(action string) common.InsertQuery {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (g *GormInsertQuery) Returning(columns ...string) common.InsertQuery {
|
func (g *GormInsertQuery) Returning(columns ...string) common.InsertQuery {
|
||||||
// GORM doesn't have explicit RETURNING, but updates the model
|
g.returningColumns = columns
|
||||||
return g
|
return g
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -749,6 +752,76 @@ func (g *GormInsertQuery) Exec(ctx context.Context) (res common.Result, err erro
|
|||||||
return &GormResult{result: result}, result.Error
|
return &GormResult{result: result}, result.Error
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (g *GormInsertQuery) Scan(ctx context.Context, dest interface{}) (err error) {
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
err = logger.HandlePanic("GormInsertQuery.Scan", r)
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
startedAt := time.Now()
|
||||||
|
|
||||||
|
var returningCols []clause.Column
|
||||||
|
for _, col := range g.returningColumns {
|
||||||
|
returningCols = append(returningCols, clause.Column{Name: col})
|
||||||
|
}
|
||||||
|
|
||||||
|
db := g.db.WithContext(ctx)
|
||||||
|
if len(returningCols) > 0 {
|
||||||
|
db = db.Clauses(clause.Returning{Columns: returningCols})
|
||||||
|
}
|
||||||
|
|
||||||
|
var result *gorm.DB
|
||||||
|
switch {
|
||||||
|
case g.model != nil:
|
||||||
|
result = db.Create(g.model)
|
||||||
|
case g.values != nil:
|
||||||
|
result = db.Create(g.values)
|
||||||
|
default:
|
||||||
|
result = db.Create(map[string]interface{}{})
|
||||||
|
}
|
||||||
|
|
||||||
|
if isDBClosed(result.Error) && g.reconnect != nil {
|
||||||
|
if reconnErr := g.reconnect(g.db); reconnErr == nil {
|
||||||
|
result = db.Create(g.model)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
recordQueryMetrics(g.metricsEnabled, "INSERT", g.schema, g.entity, g.tableName, startedAt, result.Error)
|
||||||
|
if result.Error != nil {
|
||||||
|
return result.Error
|
||||||
|
}
|
||||||
|
|
||||||
|
// Extract the returning column value from the model or values map
|
||||||
|
if len(g.returningColumns) == 1 {
|
||||||
|
col := g.returningColumns[0]
|
||||||
|
if g.model != nil {
|
||||||
|
val := reflect.ValueOf(g.model)
|
||||||
|
if val.Kind() == reflect.Ptr {
|
||||||
|
val = val.Elem()
|
||||||
|
}
|
||||||
|
if val.Kind() == reflect.Struct {
|
||||||
|
for i := 0; i < val.NumField(); i++ {
|
||||||
|
f := val.Type().Field(i)
|
||||||
|
dbTag := strings.Split(f.Tag.Get("bun"), ",")[0]
|
||||||
|
jsonTag := strings.Split(f.Tag.Get("json"), ",")[0]
|
||||||
|
if strings.EqualFold(f.Name, col) || dbTag == col || jsonTag == col {
|
||||||
|
reflect.ValueOf(dest).Elem().Set(val.Field(i))
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if g.values != nil {
|
||||||
|
if v, ok := g.values[col]; ok {
|
||||||
|
reflect.ValueOf(dest).Elem().Set(reflect.ValueOf(v))
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// GormUpdateQuery implements UpdateQuery for GORM
|
// GormUpdateQuery implements UpdateQuery for GORM
|
||||||
type GormUpdateQuery struct {
|
type GormUpdateQuery struct {
|
||||||
db *gorm.DB
|
db *gorm.DB
|
||||||
|
|||||||
@@ -708,6 +708,51 @@ func (p *PgSQLInsertQuery) Exec(ctx context.Context) (res common.Result, err err
|
|||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (p *PgSQLInsertQuery) Scan(ctx context.Context, dest interface{}) (err error) {
|
||||||
|
startedAt := time.Now()
|
||||||
|
defer func() {
|
||||||
|
if r := recover(); r != nil {
|
||||||
|
err = logger.HandlePanic("PgSQLInsertQuery.Scan", r)
|
||||||
|
}
|
||||||
|
recordQueryMetrics(p.metricsEnabled, "INSERT", p.schema, p.entity, p.tableName, startedAt, err)
|
||||||
|
}()
|
||||||
|
|
||||||
|
if len(p.values) == 0 {
|
||||||
|
return fmt.Errorf("no values to insert")
|
||||||
|
}
|
||||||
|
|
||||||
|
columns := make([]string, 0, len(p.values))
|
||||||
|
placeholders := make([]string, 0, len(p.values))
|
||||||
|
args := make([]interface{}, 0, len(p.values))
|
||||||
|
i := 1
|
||||||
|
for _, col := range p.valueOrder {
|
||||||
|
columns = append(columns, col)
|
||||||
|
placeholders = append(placeholders, fmt.Sprintf("$%d", i))
|
||||||
|
args = append(args, p.values[col])
|
||||||
|
i++
|
||||||
|
}
|
||||||
|
|
||||||
|
query := fmt.Sprintf("INSERT INTO %s (%s) VALUES (%s)",
|
||||||
|
p.tableName,
|
||||||
|
strings.Join(columns, ", "),
|
||||||
|
strings.Join(placeholders, ", "))
|
||||||
|
|
||||||
|
if len(p.returning) > 0 {
|
||||||
|
query += " RETURNING " + strings.Join(p.returning, ", ")
|
||||||
|
}
|
||||||
|
|
||||||
|
logger.Debug("PgSQL INSERT (Scan): %s [args: %v]", query, args)
|
||||||
|
|
||||||
|
var row *sql.Row
|
||||||
|
if p.tx != nil {
|
||||||
|
row = p.tx.QueryRowContext(ctx, query, args...)
|
||||||
|
} else {
|
||||||
|
row = p.db.QueryRowContext(ctx, query, args...)
|
||||||
|
}
|
||||||
|
|
||||||
|
return row.Scan(dest)
|
||||||
|
}
|
||||||
|
|
||||||
// PgSQLUpdateQuery implements UpdateQuery for PostgreSQL
|
// PgSQLUpdateQuery implements UpdateQuery for PostgreSQL
|
||||||
type PgSQLUpdateQuery struct {
|
type PgSQLUpdateQuery struct {
|
||||||
db *sql.DB
|
db *sql.DB
|
||||||
|
|||||||
@@ -75,6 +75,7 @@ type InsertQuery interface {
|
|||||||
|
|
||||||
// Execution
|
// Execution
|
||||||
Exec(ctx context.Context) (Result, error)
|
Exec(ctx context.Context) (Result, error)
|
||||||
|
Scan(ctx context.Context, dest interface{}) error
|
||||||
}
|
}
|
||||||
|
|
||||||
// UpdateQuery interface for building UPDATE queries
|
// UpdateQuery interface for building UPDATE queries
|
||||||
|
|||||||
@@ -234,27 +234,32 @@ func (p *NestedCUDProcessor) injectForeignKeys(data map[string]interface{}, mode
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
// Iterate through model fields to find foreign key fields
|
for parentKey, parentID := range parentIDs {
|
||||||
for i := 0; i < modelType.NumField(); i++ {
|
dbColNames := reflection.GetForeignKeyColumn(modelType, parentKey)
|
||||||
field := modelType.Field(i)
|
|
||||||
jsonTag := field.Tag.Get("json")
|
|
||||||
jsonName := strings.Split(jsonTag, ",")[0]
|
|
||||||
|
|
||||||
// Check if this field is a foreign key and we have a parent ID for it
|
if len(dbColNames) == 0 {
|
||||||
// Common patterns: DepartmentID, ManagerID, ProjectID, etc.
|
// No explicit tag found — fall back to naming convention by scanning scalar fields.
|
||||||
for parentKey, parentID := range parentIDs {
|
for i := 0; i < modelType.NumField(); i++ {
|
||||||
// Match field name patterns like "department_id" with parent key "department"
|
field := modelType.Field(i)
|
||||||
if strings.EqualFold(jsonName, parentKey+"_id") ||
|
jsonName := strings.Split(field.Tag.Get("json"), ",")[0]
|
||||||
strings.EqualFold(jsonName, parentKey+"id") ||
|
if strings.EqualFold(jsonName, "rid"+parentKey) ||
|
||||||
strings.EqualFold(field.Name, parentKey+"ID") {
|
strings.EqualFold(jsonName, "rid_"+parentKey) ||
|
||||||
// Use the DB column name as the key, since data is keyed by DB column names
|
strings.EqualFold(jsonName, "id_"+parentKey) ||
|
||||||
dbColName := reflection.GetColumnName(field)
|
strings.EqualFold(jsonName, parentKey+"_id") ||
|
||||||
if _, exists := data[dbColName]; !exists {
|
strings.EqualFold(jsonName, parentKey+"id") ||
|
||||||
logger.Debug("Injecting foreign key: %s = %v", dbColName, parentID)
|
strings.EqualFold(field.Name, parentKey+"ID") {
|
||||||
data[dbColName] = parentID
|
dbColNames = []string{reflection.GetColumnName(field)}
|
||||||
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
for _, dbColName := range dbColNames {
|
||||||
|
if _, exists := data[dbColName]; !exists {
|
||||||
|
logger.Debug("Injecting foreign key: %s = %v", dbColName, parentID)
|
||||||
|
data[dbColName] = parentID
|
||||||
|
}
|
||||||
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -272,24 +277,15 @@ func (p *NestedCUDProcessor) processInsert(
|
|||||||
query = query.Value(key, ConvertSliceForBun(value))
|
query = query.Value(key, ConvertSliceForBun(value))
|
||||||
}
|
}
|
||||||
pkName := reflection.GetPrimaryKeyName(tableName)
|
pkName := reflection.GetPrimaryKeyName(tableName)
|
||||||
// Add RETURNING clause to get the inserted ID
|
|
||||||
query = query.Returning(pkName)
|
query = query.Returning(pkName)
|
||||||
|
|
||||||
result, err := query.Exec(ctx)
|
var id interface{}
|
||||||
if err != nil {
|
if err := query.Scan(ctx, &id); err != nil {
|
||||||
logger.Error("Insert execution failed: table=%s, data=%+v, error=%v", tableName, data, err)
|
logger.Error("Insert execution failed: table=%s, data=%+v, error=%v", tableName, data, err)
|
||||||
return nil, fmt.Errorf("insert exec failed: %w", err)
|
return nil, fmt.Errorf("insert exec failed: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Try to get the ID
|
logger.Debug("Insert successful, ID: %v", id)
|
||||||
var id interface{}
|
|
||||||
if lastID, err := result.LastInsertId(); err == nil && lastID > 0 {
|
|
||||||
id = lastID
|
|
||||||
} else if data[pkName] != nil {
|
|
||||||
id = data[pkName]
|
|
||||||
}
|
|
||||||
|
|
||||||
logger.Debug("Insert successful, ID: %v, rows affected: %d", id, result.RowsAffected())
|
|
||||||
return id, nil
|
return id, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -101,12 +101,18 @@ func (m *mockInsertQuery) Value(column string, value interface{}) InsertQuery {
|
|||||||
func (m *mockInsertQuery) OnConflict(action string) InsertQuery { return m }
|
func (m *mockInsertQuery) OnConflict(action string) InsertQuery { return m }
|
||||||
func (m *mockInsertQuery) Returning(columns ...string) InsertQuery { return m }
|
func (m *mockInsertQuery) Returning(columns ...string) InsertQuery { return m }
|
||||||
func (m *mockInsertQuery) Exec(ctx context.Context) (Result, error) {
|
func (m *mockInsertQuery) Exec(ctx context.Context) (Result, error) {
|
||||||
// Record the insert call
|
|
||||||
m.db.insertCalls = append(m.db.insertCalls, m.values)
|
m.db.insertCalls = append(m.db.insertCalls, m.values)
|
||||||
m.db.lastID++
|
m.db.lastID++
|
||||||
return &mockResult{lastID: m.db.lastID, rowsAffected: 1}, nil
|
return &mockResult{lastID: m.db.lastID, rowsAffected: 1}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockInsertQuery) Scan(ctx context.Context, dest interface{}) error {
|
||||||
|
m.db.insertCalls = append(m.db.insertCalls, m.values)
|
||||||
|
m.db.lastID++
|
||||||
|
reflect.ValueOf(dest).Elem().Set(reflect.ValueOf(m.db.lastID))
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// Mock UpdateQuery
|
// Mock UpdateQuery
|
||||||
type mockUpdateQuery struct {
|
type mockUpdateQuery struct {
|
||||||
db *mockDatabase
|
db *mockDatabase
|
||||||
|
|||||||
@@ -729,9 +729,10 @@ func (h *Handler) mergeQueryParams(r *http.Request, sqlquery string, variables m
|
|||||||
propQry[parmk] = val
|
propQry[parmk] = val
|
||||||
}
|
}
|
||||||
|
|
||||||
// Apply filters if allowed — check against string-literal-stripped SQL to avoid
|
// Apply filters if allowed — check only the SELECT list to avoid matching function
|
||||||
// matching column names that only appear inside quoted arguments (e.g. JSON strings)
|
// parameters in the FROM clause (e.g. [p_rid_doctype] in a set-returning function call)
|
||||||
if allowFilter && len(parmk) > 1 && strings.Contains(strings.ToLower(sqlStripStringLiterals(sqlquery)), strings.ToLower(parmk)) {
|
// or names inside quoted string arguments.
|
||||||
|
if allowFilter && len(parmk) > 1 && strings.Contains(sqlSelectList(sqlStripStringLiterals(sqlquery)), strings.ToLower(parmk)) {
|
||||||
if len(parmv) > 1 {
|
if len(parmv) > 1 {
|
||||||
// Sanitize each value in the IN clause with appropriate quoting
|
// Sanitize each value in the IN clause with appropriate quoting
|
||||||
sanitizedValues := make([]string, len(parmv))
|
sanitizedValues := make([]string, len(parmv))
|
||||||
@@ -847,6 +848,18 @@ func sqlStripStringLiterals(sql string) string {
|
|||||||
return re.ReplaceAllString(sql, "''")
|
return re.ReplaceAllString(sql, "''")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// sqlSelectList returns the column list portion of a SELECT query (between SELECT and FROM).
|
||||||
|
// Returns the full query lowercased if no clear SELECT…FROM boundary is found.
|
||||||
|
func sqlSelectList(sql string) string {
|
||||||
|
lower := strings.ToLower(sql)
|
||||||
|
selectPos := strings.Index(lower, "select ")
|
||||||
|
fromPos := strings.Index(lower, " from ")
|
||||||
|
if selectPos < 0 || fromPos <= selectPos {
|
||||||
|
return lower
|
||||||
|
}
|
||||||
|
return lower[selectPos+7 : fromPos]
|
||||||
|
}
|
||||||
|
|
||||||
// replaceMetaVariables replaces meta variables like [rid_user], [user], etc. in the SQL query
|
// replaceMetaVariables replaces meta variables like [rid_user], [user], etc. in the SQL query
|
||||||
func (h *Handler) replaceMetaVariables(sqlquery string, r *http.Request, userCtx *security.UserContext, metainfo map[string]interface{}, variables map[string]interface{}) string {
|
func (h *Handler) replaceMetaVariables(sqlquery string, r *http.Request, userCtx *security.UserContext, metainfo map[string]interface{}, variables map[string]interface{}) string {
|
||||||
if strings.Contains(sqlquery, "[p_meta_default]") {
|
if strings.Contains(sqlquery, "[p_meta_default]") {
|
||||||
|
|||||||
@@ -821,7 +821,7 @@ func TestReplaceMetaVariables(t *testing.T) {
|
|||||||
name: "Replace [user]",
|
name: "Replace [user]",
|
||||||
sqlQuery: "SELECT * FROM audit WHERE username = [user]",
|
sqlQuery: "SELECT * FROM audit WHERE username = [user]",
|
||||||
expectedCheck: func(result string) bool {
|
expectedCheck: func(result string) bool {
|
||||||
return strings.Contains(result, "'testuser'")
|
return strings.Contains(result, "$USR$testuser$USR$")
|
||||||
},
|
},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
@@ -957,6 +957,60 @@ func TestAllowFilterDoesNotMatchInsideJsonArgument(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// TestAllowFilterDoesNotMatchFunctionParams verifies that query params that appear only
|
||||||
|
// as function call arguments in the FROM clause (e.g. [p_rid_doctype]) are not treated
|
||||||
|
// as column filters, since they are not in the SELECT list.
|
||||||
|
func TestAllowFilterDoesNotMatchFunctionParams(t *testing.T) {
|
||||||
|
handler := NewHandler(&MockDatabase{})
|
||||||
|
|
||||||
|
sqlQuery := `select rid, rid_parent, description, row_cnt, filterstring, tableprefix, rid_table, tooltip, additionalfilter, haschildren
|
||||||
|
from crm_get_doc_menu($JQ$[p_tableprefix]$JQ$,[p_rid_parent],[p_rid_doctype],[p_removedup],[p_showall]) r`
|
||||||
|
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
queryParams map[string]string
|
||||||
|
checkResult func(t *testing.T, result string)
|
||||||
|
}{
|
||||||
|
{
|
||||||
|
name: "p_rid_doctype is a function param, not a column — no filter applied",
|
||||||
|
queryParams: map[string]string{"p_rid_doctype": "0"},
|
||||||
|
checkResult: func(t *testing.T, result string) {
|
||||||
|
if strings.Contains(strings.ToLower(result), "where") {
|
||||||
|
t.Errorf("Expected no WHERE clause for p_rid_doctype (function arg, not SELECT column), got:\n%s", result)
|
||||||
|
}
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "p_showall is a function param, not a column — no filter applied",
|
||||||
|
queryParams: map[string]string{"p_showall": "1"},
|
||||||
|
checkResult: func(t *testing.T, result string) {
|
||||||
|
if strings.Contains(strings.ToLower(result), "where") {
|
||||||
|
t.Errorf("Expected no WHERE clause for p_showall (function arg, not SELECT column), got:\n%s", result)
|
||||||
|
}
|
||||||
|
},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "rid is a SELECT column — filter applied",
|
||||||
|
queryParams: map[string]string{"rid": "42"},
|
||||||
|
checkResult: func(t *testing.T, result string) {
|
||||||
|
if !strings.Contains(strings.ToLower(result), "where") {
|
||||||
|
t.Error("Expected WHERE clause for rid (real SELECT column)")
|
||||||
|
}
|
||||||
|
},
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
req := createTestRequest("GET", "/test", tt.queryParams, nil, nil)
|
||||||
|
variables := make(map[string]interface{})
|
||||||
|
propQry := make(map[string]string)
|
||||||
|
result := handler.mergeQueryParams(req, sqlQuery, variables, true, propQry)
|
||||||
|
tt.checkResult(t, result)
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
// TestGetReplacementForBlankParamDoubleQuote verifies that placeholders surrounded by
|
// TestGetReplacementForBlankParamDoubleQuote verifies that placeholders surrounded by
|
||||||
// double quotes (as in JSON string values) are blanked to "" not NULL.
|
// double quotes (as in JSON string values) are blanked to "" not NULL.
|
||||||
func TestGetReplacementForBlankParamDoubleQuote(t *testing.T) {
|
func TestGetReplacementForBlankParamDoubleQuote(t *testing.T) {
|
||||||
|
|||||||
@@ -973,6 +973,72 @@ func GetRelationType(model interface{}, fieldName string) RelationType {
|
|||||||
return RelationUnknown
|
return RelationUnknown
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// GetForeignKeyColumn returns the DB column names of the foreign key(s) that
|
||||||
|
// the relation field identified by parentKey owns on modelType. Composite keys
|
||||||
|
// (e.g. bun "join:a=b,join:c=d" or GORM "foreignKey:ColA,ColB") yield multiple
|
||||||
|
// entries. Returns nil when no tag is found (caller should fall back to
|
||||||
|
// convention).
|
||||||
|
//
|
||||||
|
// It checks tags in priority order:
|
||||||
|
// 1. Bun join: tag — e.g. `bun:"rel:belongs-to,join:department_id=id"` → ["department_id"]
|
||||||
|
// 2. GORM foreignKey: tag — e.g. `gorm:"foreignKey:DepartmentID"` → [column of DepartmentID field]
|
||||||
|
//
|
||||||
|
// parentKey is matched case-insensitively against the field name and JSON tag.
|
||||||
|
func GetForeignKeyColumn(modelType reflect.Type, parentKey string) []string {
|
||||||
|
for modelType.Kind() == reflect.Ptr || modelType.Kind() == reflect.Slice {
|
||||||
|
modelType = modelType.Elem()
|
||||||
|
}
|
||||||
|
if modelType.Kind() != reflect.Struct {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
for i := 0; i < modelType.NumField(); i++ {
|
||||||
|
field := modelType.Field(i)
|
||||||
|
|
||||||
|
name := field.Name
|
||||||
|
jsonName := strings.Split(field.Tag.Get("json"), ",")[0]
|
||||||
|
if !strings.EqualFold(name, parentKey) && !strings.EqualFold(jsonName, parentKey) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
|
|
||||||
|
// Bun: join:local_col=foreign_col (one join: part per pair)
|
||||||
|
var bunCols []string
|
||||||
|
for _, part := range strings.Split(field.Tag.Get("bun"), ",") {
|
||||||
|
part = strings.TrimSpace(part)
|
||||||
|
if strings.HasPrefix(part, "join:") {
|
||||||
|
pair := strings.TrimPrefix(part, "join:")
|
||||||
|
if idx := strings.Index(pair, "="); idx > 0 {
|
||||||
|
bunCols = append(bunCols, pair[:idx])
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(bunCols) > 0 {
|
||||||
|
return bunCols
|
||||||
|
}
|
||||||
|
|
||||||
|
// GORM: foreignKey:FieldA,FieldB
|
||||||
|
for _, part := range strings.Split(field.Tag.Get("gorm"), ";") {
|
||||||
|
part = strings.TrimSpace(part)
|
||||||
|
if strings.HasPrefix(part, "foreignKey:") {
|
||||||
|
var cols []string
|
||||||
|
for _, fkFieldName := range strings.Split(strings.TrimPrefix(part, "foreignKey:"), ",") {
|
||||||
|
fkFieldName = strings.TrimSpace(fkFieldName)
|
||||||
|
if fkField, ok := modelType.FieldByName(fkFieldName); ok {
|
||||||
|
cols = append(cols, getColumnNameFromField(fkField))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(cols) > 0 {
|
||||||
|
return cols
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
// GetRelationModel gets the model type for a relation field
|
// GetRelationModel gets the model type for a relation field
|
||||||
// It searches for the field by name in the following order (case-insensitive):
|
// It searches for the field by name in the following order (case-insensitive):
|
||||||
// 1. Actual field name
|
// 1. Actual field name
|
||||||
|
|||||||
149
pkg/reflection/model_utils_foreign_key_test.go
Normal file
149
pkg/reflection/model_utils_foreign_key_test.go
Normal file
@@ -0,0 +1,149 @@
|
|||||||
|
package reflection
|
||||||
|
|
||||||
|
import (
|
||||||
|
"reflect"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// --- local test models ---
|
||||||
|
|
||||||
|
type fkDept struct{}
|
||||||
|
|
||||||
|
// bunEmployee uses bun join: tag to declare the FK column explicitly.
|
||||||
|
type bunEmployee struct {
|
||||||
|
DeptID string `bun:"dept_id" json:"dept_id"`
|
||||||
|
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id" json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// bunCompositeEmployee has a composite bun join: (two join: parts).
|
||||||
|
type bunCompositeEmployee struct {
|
||||||
|
DeptID string `bun:"dept_id" json:"dept_id"`
|
||||||
|
TenantID string `bun:"tenant_id" json:"tenant_id"`
|
||||||
|
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id,join:tenant_id=id" json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// gormEmployee uses gorm foreignKey: tag (mirrors testmodels.Employee).
|
||||||
|
type gormEmployee struct {
|
||||||
|
DepartmentID string `json:"department_id"`
|
||||||
|
ManagerID string `json:"manager_id"`
|
||||||
|
Department *fkDept `gorm:"foreignKey:DepartmentID;references:ID" json:"department"`
|
||||||
|
Manager *fkDept `gorm:"foreignKey:ManagerID;references:ID" json:"manager"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// gormCompositeEmployee has a composite GORM foreignKey.
|
||||||
|
type gormCompositeEmployee struct {
|
||||||
|
DeptID string `json:"dept_id"`
|
||||||
|
TenantID string `json:"tenant_id"`
|
||||||
|
Department *fkDept `gorm:"foreignKey:DeptID,TenantID" json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// conventionEmployee has no explicit FK tag — relies on naming convention.
|
||||||
|
type conventionEmployee struct {
|
||||||
|
DepartmentID string `json:"department_id"`
|
||||||
|
Department *fkDept `json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// noTagEmployee has a relation field with no FK tag and no convention match.
|
||||||
|
type noTagEmployee struct {
|
||||||
|
Unrelated *fkDept `json:"unrelated"`
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestGetForeignKeyColumn(t *testing.T) {
|
||||||
|
tests := []struct {
|
||||||
|
name string
|
||||||
|
modelType reflect.Type
|
||||||
|
parentKey string
|
||||||
|
want []string
|
||||||
|
}{
|
||||||
|
// Bun join: tag
|
||||||
|
{
|
||||||
|
name: "bun join tag returns local column",
|
||||||
|
modelType: reflect.TypeOf(bunEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"dept_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "bun join tag matched via json tag (case-insensitive)",
|
||||||
|
modelType: reflect.TypeOf(bunEmployee{}),
|
||||||
|
parentKey: "Department",
|
||||||
|
want: []string{"dept_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "bun composite join returns all local columns",
|
||||||
|
modelType: reflect.TypeOf(bunCompositeEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"dept_id", "tenant_id"},
|
||||||
|
},
|
||||||
|
|
||||||
|
// GORM foreignKey: tag
|
||||||
|
{
|
||||||
|
name: "gorm foreignKey resolves to column name",
|
||||||
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"department_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "gorm foreignKey resolves second relation",
|
||||||
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
|
parentKey: "manager",
|
||||||
|
want: []string{"manager_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "gorm foreignKey matched case-insensitively",
|
||||||
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
|
parentKey: "Department",
|
||||||
|
want: []string{"department_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "gorm composite foreignKey returns all columns",
|
||||||
|
modelType: reflect.TypeOf(gormCompositeEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"dept_id", "tenant_id"},
|
||||||
|
},
|
||||||
|
|
||||||
|
// Pointer and slice unwrapping
|
||||||
|
{
|
||||||
|
name: "pointer to struct is unwrapped",
|
||||||
|
modelType: reflect.TypeOf(&gormEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"department_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "slice of struct is unwrapped",
|
||||||
|
modelType: reflect.TypeOf([]gormEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"department_id"},
|
||||||
|
},
|
||||||
|
|
||||||
|
// No tag — returns nil so caller can fall back to convention
|
||||||
|
{
|
||||||
|
name: "relation with no FK tag returns nil",
|
||||||
|
modelType: reflect.TypeOf(conventionEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: nil,
|
||||||
|
},
|
||||||
|
|
||||||
|
// Unknown parent key
|
||||||
|
{
|
||||||
|
name: "unknown parent key returns nil",
|
||||||
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
|
parentKey: "nonexistent",
|
||||||
|
want: nil,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "non-struct type returns nil",
|
||||||
|
modelType: reflect.TypeOf(""),
|
||||||
|
parentKey: "department",
|
||||||
|
want: nil,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
got := GetForeignKeyColumn(tt.modelType, tt.parentKey)
|
||||||
|
if !reflect.DeepEqual(got, tt.want) {
|
||||||
|
t.Errorf("GetForeignKeyColumn(%v, %q) = %v, want %v", tt.modelType, tt.parentKey, got, tt.want)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
}
|
||||||
@@ -8,6 +8,7 @@ import (
|
|||||||
"regexp"
|
"regexp"
|
||||||
"strconv"
|
"strconv"
|
||||||
"strings"
|
"strings"
|
||||||
|
"unicode/utf8"
|
||||||
|
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
@@ -64,7 +65,10 @@ type ExpandOption struct {
|
|||||||
// decodeHeaderValue decodes base64 encoded header values
|
// decodeHeaderValue decodes base64 encoded header values
|
||||||
// Supports ZIP_ and __ prefixes for base64 encoding
|
// Supports ZIP_ and __ prefixes for base64 encoding
|
||||||
func decodeHeaderValue(value string) string {
|
func decodeHeaderValue(value string) string {
|
||||||
str, _ := DecodeParam(value)
|
str, err := DecodeParam(value)
|
||||||
|
if err != nil {
|
||||||
|
return value
|
||||||
|
}
|
||||||
return str
|
return str
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -98,6 +102,11 @@ func DecodeParam(pStr string) (string, error) {
|
|||||||
|
|
||||||
if strings.HasPrefix(code, "ZIP_") || strings.HasPrefix(code, "__") {
|
if strings.HasPrefix(code, "ZIP_") || strings.HasPrefix(code, "__") {
|
||||||
code, _ = DecodeParam(code)
|
code, _ = DecodeParam(code)
|
||||||
|
} else {
|
||||||
|
strDat, err := base64.StdEncoding.DecodeString(code)
|
||||||
|
if err == nil && utf8.Valid(strDat) {
|
||||||
|
code = string(strDat)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return code, nil
|
return code, nil
|
||||||
|
|||||||
@@ -174,6 +174,7 @@ func (h *Handler) handleRequest(conn *Connection, msg *Message) {
|
|||||||
Options: msg.Options,
|
Options: msg.Options,
|
||||||
ID: recordID,
|
ID: recordID,
|
||||||
Data: msg.Data,
|
Data: msg.Data,
|
||||||
|
Tx: h.db,
|
||||||
Metadata: make(map[string]interface{}),
|
Metadata: make(map[string]interface{}),
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -239,6 +239,11 @@ func (m *MockInsertQuery) Exec(ctx context.Context) (common.Result, error) {
|
|||||||
return args.Get(0).(common.Result), args.Error(1)
|
return args.Get(0).(common.Result), args.Error(1)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *MockInsertQuery) Scan(ctx context.Context, dest interface{}) error {
|
||||||
|
args := m.Called(ctx, dest)
|
||||||
|
return args.Error(0)
|
||||||
|
}
|
||||||
|
|
||||||
// MockUpdateQuery is a mock implementation of common.UpdateQuery
|
// MockUpdateQuery is a mock implementation of common.UpdateQuery
|
||||||
type MockUpdateQuery struct {
|
type MockUpdateQuery struct {
|
||||||
mock.Mock
|
mock.Mock
|
||||||
|
|||||||
@@ -111,6 +111,9 @@ type HookContext struct {
|
|||||||
AbortMessage string // Message to return if aborted
|
AbortMessage string // Message to return if aborted
|
||||||
AbortCode int // HTTP status code if aborted
|
AbortCode int // HTTP status code if aborted
|
||||||
|
|
||||||
|
// Tx provides access to the database/transaction for executing additional SQL
|
||||||
|
Tx common.Database
|
||||||
|
|
||||||
// Metadata is additional context data
|
// Metadata is additional context data
|
||||||
Metadata map[string]interface{}
|
Metadata map[string]interface{}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user