mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-05-21 19:45:33 +00:00
Compare commits
18 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
0308644075 | ||
|
|
e5984f5205 | ||
|
|
76909ae869 | ||
|
|
c90c2984ac | ||
|
|
1ab4ae33e7 | ||
|
|
905457964c | ||
|
|
c42d09238f | ||
|
|
0647a88aba | ||
|
|
3d2e11eeed | ||
|
|
4493bfa40f | ||
|
|
b157379ff8 | ||
|
|
52752d9c8b | ||
|
|
baca5ad29e | ||
|
|
53ab22ce02 | ||
|
|
09a3dc92b9 | ||
|
|
6590cd789a | ||
|
|
4244e838b1 | ||
|
|
c42fa11c1a |
@@ -289,19 +289,20 @@ func (b *BunAdapter) DriverName() string {
|
|||||||
|
|
||||||
// BunSelectQuery implements SelectQuery for Bun
|
// BunSelectQuery implements SelectQuery for Bun
|
||||||
type BunSelectQuery struct {
|
type BunSelectQuery struct {
|
||||||
query *bun.SelectQuery
|
query *bun.SelectQuery
|
||||||
db bun.IDB // Store DB connection for count queries
|
db bun.IDB // Store DB connection for count queries
|
||||||
hasModel bool // Track if Model() was called
|
hasModel bool // Track if Model() was called
|
||||||
schema string // Separated schema name
|
schema string // Separated schema name
|
||||||
tableName string // Just the table name, without schema
|
tableName string // Just the table name, without schema
|
||||||
entity string
|
entity string
|
||||||
tableAlias string
|
tableAlias string
|
||||||
driverName string // Database driver name (postgres, sqlite, mssql)
|
driverName string // Database driver name (postgres, sqlite, mssql)
|
||||||
inJoinContext bool // Track if we're in a JOIN relation context
|
inJoinContext bool // Track if we're in a JOIN relation context
|
||||||
joinTableAlias string // Alias to use for JOIN conditions
|
joinTableAlias string // Alias to use for JOIN conditions
|
||||||
skipAutoDetect bool // Skip auto-detection to prevent circular calls
|
skipAutoDetect bool // Skip auto-detection to prevent circular calls
|
||||||
customPreloads map[string][]func(common.SelectQuery) common.SelectQuery // Relations to load with custom implementation
|
preloadRelationAlias string // Relation alias used in separate-query preloads (e.g. "tprp" for relation "TPRP")
|
||||||
metricsEnabled bool
|
customPreloads map[string][]func(common.SelectQuery) common.SelectQuery // Relations to load with custom implementation
|
||||||
|
metricsEnabled bool
|
||||||
}
|
}
|
||||||
|
|
||||||
func (b *BunSelectQuery) Model(model interface{}) common.SelectQuery {
|
func (b *BunSelectQuery) Model(model interface{}) common.SelectQuery {
|
||||||
@@ -346,12 +347,14 @@ func (b *BunSelectQuery) ColumnExpr(query string, args ...interface{}) common.Se
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (b *BunSelectQuery) Where(query string, args ...interface{}) common.SelectQuery {
|
func (b *BunSelectQuery) Where(query string, args ...interface{}) common.SelectQuery {
|
||||||
// If we're in a JOIN context, add table prefix to unqualified columns
|
|
||||||
if b.inJoinContext && b.joinTableAlias != "" {
|
if b.inJoinContext && b.joinTableAlias != "" {
|
||||||
query = addTablePrefix(query, b.joinTableAlias)
|
query = addTablePrefix(query, b.joinTableAlias)
|
||||||
|
} else if b.preloadRelationAlias != "" && b.tableName != "" {
|
||||||
|
// Separate-query preload: the caller may have written conditions using the
|
||||||
|
// relation name as a prefix (e.g. "TPRP.col"). Bun uses the real table name
|
||||||
|
// as the alias, so rewrite any such references to use tableName instead.
|
||||||
|
query = replaceRelationAlias(query, b.preloadRelationAlias, b.tableName)
|
||||||
} else if b.tableAlias != "" && b.tableName != "" {
|
} else if b.tableAlias != "" && b.tableName != "" {
|
||||||
// If we have a table alias defined, check if the query references a different alias
|
|
||||||
// This can happen in preloads where the user expects a certain alias but Bun generates another
|
|
||||||
query = normalizeTableAlias(query, b.tableAlias, b.tableName)
|
query = normalizeTableAlias(query, b.tableAlias, b.tableName)
|
||||||
}
|
}
|
||||||
b.query = b.query.Where(query, args...)
|
b.query = b.query.Where(query, args...)
|
||||||
@@ -487,6 +490,30 @@ func normalizeTableAlias(query, expectedAlias, tableName string) string {
|
|||||||
return modified
|
return modified
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// replaceRelationAlias rewrites WHERE conditions written with a relation alias prefix
|
||||||
|
// (e.g. "TPRP.col") to use the real table name that bun uses in separate queries
|
||||||
|
// (e.g. "t_proposalinstance.col"). Only called for separate-query preload wrappers.
|
||||||
|
func replaceRelationAlias(query, relationAlias, tableName string) string {
|
||||||
|
if relationAlias == "" || tableName == "" || query == "" {
|
||||||
|
return query
|
||||||
|
}
|
||||||
|
parts := strings.FieldsFunc(query, func(r rune) bool {
|
||||||
|
return r == ' ' || r == '(' || r == ')' || r == ','
|
||||||
|
})
|
||||||
|
modified := query
|
||||||
|
for _, part := range parts {
|
||||||
|
if dotIndex := strings.Index(part, "."); dotIndex > 0 {
|
||||||
|
prefix := part[:dotIndex]
|
||||||
|
column := part[dotIndex+1:]
|
||||||
|
if strings.EqualFold(prefix, relationAlias) {
|
||||||
|
logger.Debug("Replacing relation alias '%s' with table name '%s' in preload WHERE condition", prefix, tableName)
|
||||||
|
modified = strings.ReplaceAll(modified, part, tableName+"."+column)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return modified
|
||||||
|
}
|
||||||
|
|
||||||
func isJoinKeyword(word string) bool {
|
func isJoinKeyword(word string) bool {
|
||||||
switch strings.ToUpper(word) {
|
switch strings.ToUpper(word) {
|
||||||
case "JOIN", "INNER", "LEFT", "RIGHT", "FULL", "OUTER", "CROSS":
|
case "JOIN", "INNER", "LEFT", "RIGHT", "FULL", "OUTER", "CROSS":
|
||||||
@@ -676,8 +703,20 @@ func (b *BunSelectQuery) PreloadRelation(relation string, apply ...func(common.S
|
|||||||
wrapper.tableAlias = provider.TableAlias()
|
wrapper.tableAlias = provider.TableAlias()
|
||||||
logger.Debug("Preload relation '%s' using table alias: %s", relation, wrapper.tableAlias)
|
logger.Debug("Preload relation '%s' using table alias: %s", relation, wrapper.tableAlias)
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Fallback: if the model didn't provide a table name, ask bun directly.
|
||||||
|
if wrapper.tableName == "" {
|
||||||
|
wrapper.schema, wrapper.tableName = parseTableName(sq.GetTableName(), b.driverName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// For separate-query preloads (has-many), bun aliases the related table using
|
||||||
|
// the actual table name, not the relation name. Record the relation alias so
|
||||||
|
// Where() can rewrite conditions like "TPRP.col" to "t_proposalinstance.col".
|
||||||
|
wrapper.preloadRelationAlias = strings.ToLower(relation)
|
||||||
|
logger.Debug("Preload relation '%s' registered alias '%s' for separate-query WHERE rewriting", relation, wrapper.preloadRelationAlias)
|
||||||
|
|
||||||
// Start with the interface value (not pointer)
|
// Start with the interface value (not pointer)
|
||||||
current := common.SelectQuery(wrapper)
|
current := common.SelectQuery(wrapper)
|
||||||
|
|
||||||
@@ -1276,6 +1315,7 @@ func (b *BunSelectQuery) Scan(ctx context.Context, dest interface{}) (err error)
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunSelectQuery.Scan failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunSelectQuery.Scan failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
@@ -1332,7 +1372,7 @@ func (b *BunSelectQuery) ScanModel(ctx context.Context) (err error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunSelectQuery.ScanModel failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunSelectQuery.ScanModel failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
return err
|
return common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
|
|
||||||
// After main query, load custom preloads using separate queries
|
// After main query, load custom preloads using separate queries
|
||||||
@@ -1362,6 +1402,7 @@ func (b *BunSelectQuery) Count(ctx context.Context) (count int, err error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunSelectQuery.Count failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunSelectQuery.Count failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -1375,6 +1416,7 @@ func (b *BunSelectQuery) Count(ctx context.Context) (count int, err error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
sqlStr := countQuery.String()
|
sqlStr := countQuery.String()
|
||||||
logger.Error("BunSelectQuery.Count (subquery) failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunSelectQuery.Count (subquery) failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -1392,6 +1434,7 @@ func (b *BunSelectQuery) Exists(ctx context.Context) (exists bool, err error) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunSelectQuery.Exists failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunSelectQuery.Exists failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -1580,6 +1623,7 @@ func (b *BunUpdateQuery) Exec(ctx context.Context) (res common.Result, err error
|
|||||||
// Log SQL string for debugging
|
// Log SQL string for debugging
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunUpdateQuery.Exec failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunUpdateQuery.Exec failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(b.metricsEnabled, "UPDATE", b.schema, b.entity, b.tableName, startedAt, err)
|
recordQueryMetrics(b.metricsEnabled, "UPDATE", b.schema, b.entity, b.tableName, startedAt, err)
|
||||||
return &BunResult{result: result}, err
|
return &BunResult{result: result}, err
|
||||||
@@ -1631,6 +1675,7 @@ func (b *BunDeleteQuery) Exec(ctx context.Context) (res common.Result, err error
|
|||||||
// Log SQL string for debugging
|
// Log SQL string for debugging
|
||||||
sqlStr := b.query.String()
|
sqlStr := b.query.String()
|
||||||
logger.Error("BunDeleteQuery.Exec failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("BunDeleteQuery.Exec failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(b.metricsEnabled, "DELETE", b.schema, b.entity, b.tableName, startedAt, err)
|
recordQueryMetrics(b.metricsEnabled, "DELETE", b.schema, b.entity, b.tableName, startedAt, err)
|
||||||
return &BunResult{result: result}, err
|
return &BunResult{result: result}, err
|
||||||
|
|||||||
@@ -583,6 +583,7 @@ func (g *GormSelectQuery) Scan(ctx context.Context, dest interface{}) (err error
|
|||||||
return tx.Find(dest)
|
return tx.Find(dest)
|
||||||
})
|
})
|
||||||
logger.Error("GormSelectQuery.Scan failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("GormSelectQuery.Scan failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "SELECT", g.schema, g.entity, g.tableName, startedAt, err)
|
recordQueryMetrics(g.metricsEnabled, "SELECT", g.schema, g.entity, g.tableName, startedAt, err)
|
||||||
return err
|
return err
|
||||||
@@ -613,6 +614,7 @@ func (g *GormSelectQuery) ScanModel(ctx context.Context) (err error) {
|
|||||||
return tx.Find(g.db.Statement.Model)
|
return tx.Find(g.db.Statement.Model)
|
||||||
})
|
})
|
||||||
logger.Error("GormSelectQuery.ScanModel failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("GormSelectQuery.ScanModel failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "SELECT", g.schema, g.entity, g.tableName, startedAt, err)
|
recordQueryMetrics(g.metricsEnabled, "SELECT", g.schema, g.entity, g.tableName, startedAt, err)
|
||||||
return err
|
return err
|
||||||
@@ -642,6 +644,7 @@ func (g *GormSelectQuery) Count(ctx context.Context) (count int, err error) {
|
|||||||
return tx.Count(&count64)
|
return tx.Count(&count64)
|
||||||
})
|
})
|
||||||
logger.Error("GormSelectQuery.Count failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("GormSelectQuery.Count failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "COUNT", g.schema, g.entity, g.tableName, startedAt, err)
|
recordQueryMetrics(g.metricsEnabled, "COUNT", g.schema, g.entity, g.tableName, startedAt, err)
|
||||||
return int(count64), err
|
return int(count64), err
|
||||||
@@ -671,6 +674,7 @@ func (g *GormSelectQuery) Exists(ctx context.Context) (exists bool, err error) {
|
|||||||
return tx.Limit(1).Count(&count)
|
return tx.Limit(1).Count(&count)
|
||||||
})
|
})
|
||||||
logger.Error("GormSelectQuery.Exists failed. SQL: %s. Error: %v", sqlStr, err)
|
logger.Error("GormSelectQuery.Exists failed. SQL: %s. Error: %v", sqlStr, err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "EXISTS", g.schema, g.entity, g.tableName, startedAt, err)
|
recordQueryMetrics(g.metricsEnabled, "EXISTS", g.schema, g.entity, g.tableName, startedAt, err)
|
||||||
return count > 0, err
|
return count > 0, err
|
||||||
@@ -931,6 +935,7 @@ func (g *GormUpdateQuery) Exec(ctx context.Context) (res common.Result, err erro
|
|||||||
return tx.Updates(g.updates)
|
return tx.Updates(g.updates)
|
||||||
})
|
})
|
||||||
logger.Error("GormUpdateQuery.Exec failed. SQL: %s. Error: %v", sqlStr, result.Error)
|
logger.Error("GormUpdateQuery.Exec failed. SQL: %s. Error: %v", sqlStr, result.Error)
|
||||||
|
return &GormResult{result: result}, common.WrapSQLError(result.Error, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "UPDATE", g.schema, g.entity, g.tableName, startedAt, result.Error)
|
recordQueryMetrics(g.metricsEnabled, "UPDATE", g.schema, g.entity, g.tableName, startedAt, result.Error)
|
||||||
return &GormResult{result: result}, result.Error
|
return &GormResult{result: result}, result.Error
|
||||||
@@ -992,6 +997,7 @@ func (g *GormDeleteQuery) Exec(ctx context.Context) (res common.Result, err erro
|
|||||||
return tx.Delete(g.model)
|
return tx.Delete(g.model)
|
||||||
})
|
})
|
||||||
logger.Error("GormDeleteQuery.Exec failed. SQL: %s. Error: %v", sqlStr, result.Error)
|
logger.Error("GormDeleteQuery.Exec failed. SQL: %s. Error: %v", sqlStr, result.Error)
|
||||||
|
return &GormResult{result: result}, common.WrapSQLError(result.Error, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(g.metricsEnabled, "DELETE", g.schema, g.entity, g.tableName, startedAt, result.Error)
|
recordQueryMetrics(g.metricsEnabled, "DELETE", g.schema, g.entity, g.tableName, startedAt, result.Error)
|
||||||
return &GormResult{result: result}, result.Error
|
return &GormResult{result: result}, result.Error
|
||||||
|
|||||||
@@ -138,7 +138,7 @@ func (p *PgSQLAdapter) Exec(ctx context.Context, query string, args ...interface
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL Exec failed: %v", err)
|
logger.Error("PgSQL Exec failed: %v", err)
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
||||||
return nil, err
|
return nil, common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, nil)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, nil)
|
||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
@@ -164,7 +164,7 @@ func (p *PgSQLAdapter) Query(ctx context.Context, dest interface{}, query string
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL Query failed: %v", err)
|
logger.Error("PgSQL Query failed: %v", err)
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
||||||
return err
|
return common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
defer rows.Close()
|
defer rows.Close()
|
||||||
|
|
||||||
@@ -511,7 +511,7 @@ func (p *PgSQLSelectQuery) Scan(ctx context.Context, dest interface{}) (err erro
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL SELECT failed: %v", err)
|
logger.Error("PgSQL SELECT failed: %v", err)
|
||||||
recordQueryMetrics(p.metricsEnabled, "SELECT", p.schema, p.entity, p.tableName, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, "SELECT", p.schema, p.entity, p.tableName, startedAt, err)
|
||||||
return err
|
return common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
defer rows.Close()
|
defer rows.Close()
|
||||||
|
|
||||||
@@ -534,8 +534,8 @@ func (p *PgSQLSelectQuery) ScanModel(ctx context.Context) error {
|
|||||||
return p.Scan(ctx, p.model)
|
return p.Scan(ctx, p.model)
|
||||||
}
|
}
|
||||||
|
|
||||||
// countInternal executes the COUNT query and returns the result without recording metrics.
|
// countInternal executes the COUNT query and returns the result and the SQL string without recording metrics.
|
||||||
func (p *PgSQLSelectQuery) countInternal(ctx context.Context) (int, error) {
|
func (p *PgSQLSelectQuery) countInternal(ctx context.Context) (rowCount int, querySQL string, retErr error) {
|
||||||
var sb strings.Builder
|
var sb strings.Builder
|
||||||
sb.WriteString("SELECT COUNT(*) FROM ")
|
sb.WriteString("SELECT COUNT(*) FROM ")
|
||||||
sb.WriteString(p.tableName)
|
sb.WriteString(p.tableName)
|
||||||
@@ -571,9 +571,9 @@ func (p *PgSQLSelectQuery) countInternal(ctx context.Context) (int, error) {
|
|||||||
|
|
||||||
var count int
|
var count int
|
||||||
if err := row.Scan(&count); err != nil {
|
if err := row.Scan(&count); err != nil {
|
||||||
return 0, err
|
return 0, query, err
|
||||||
}
|
}
|
||||||
return count, nil
|
return count, query, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
func (p *PgSQLSelectQuery) Count(ctx context.Context) (count int, err error) {
|
func (p *PgSQLSelectQuery) Count(ctx context.Context) (count int, err error) {
|
||||||
@@ -584,9 +584,11 @@ func (p *PgSQLSelectQuery) Count(ctx context.Context) (count int, err error) {
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
startedAt := time.Now()
|
startedAt := time.Now()
|
||||||
count, err = p.countInternal(ctx)
|
var sqlStr string
|
||||||
|
count, sqlStr, err = p.countInternal(ctx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL COUNT failed: %v", err)
|
logger.Error("PgSQL COUNT failed: %v", err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(p.metricsEnabled, "COUNT", p.schema, p.entity, p.tableName, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, "COUNT", p.schema, p.entity, p.tableName, startedAt, err)
|
||||||
return count, err
|
return count, err
|
||||||
@@ -600,9 +602,11 @@ func (p *PgSQLSelectQuery) Exists(ctx context.Context) (exists bool, err error)
|
|||||||
}
|
}
|
||||||
}()
|
}()
|
||||||
startedAt := time.Now()
|
startedAt := time.Now()
|
||||||
count, err := p.countInternal(ctx)
|
var sqlStr string
|
||||||
|
count, sqlStr, err := p.countInternal(ctx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL EXISTS failed: %v", err)
|
logger.Error("PgSQL EXISTS failed: %v", err)
|
||||||
|
err = common.WrapSQLError(err, sqlStr)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(p.metricsEnabled, "EXISTS", p.schema, p.entity, p.tableName, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, "EXISTS", p.schema, p.entity, p.tableName, startedAt, err)
|
||||||
return count > 0, err
|
return count > 0, err
|
||||||
@@ -702,7 +706,7 @@ func (p *PgSQLInsertQuery) Exec(ctx context.Context) (res common.Result, err err
|
|||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL INSERT failed: %v", err)
|
logger.Error("PgSQL INSERT failed: %v", err)
|
||||||
return nil, err
|
return nil, common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
|
|
||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
@@ -750,7 +754,10 @@ func (p *PgSQLInsertQuery) Scan(ctx context.Context, dest interface{}) (err erro
|
|||||||
row = p.db.QueryRowContext(ctx, query, args...)
|
row = p.db.QueryRowContext(ctx, query, args...)
|
||||||
}
|
}
|
||||||
|
|
||||||
return row.Scan(dest)
|
if err := row.Scan(dest); err != nil {
|
||||||
|
return common.WrapSQLError(err, query)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// PgSQLUpdateQuery implements UpdateQuery for PostgreSQL
|
// PgSQLUpdateQuery implements UpdateQuery for PostgreSQL
|
||||||
@@ -929,7 +936,7 @@ func (p *PgSQLUpdateQuery) Exec(ctx context.Context) (res common.Result, err err
|
|||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL UPDATE failed: %v", err)
|
logger.Error("PgSQL UPDATE failed: %v", err)
|
||||||
return nil, err
|
return nil, common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
|
|
||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
@@ -1007,7 +1014,7 @@ func (p *PgSQLDeleteQuery) Exec(ctx context.Context) (res common.Result, err err
|
|||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL DELETE failed: %v", err)
|
logger.Error("PgSQL DELETE failed: %v", err)
|
||||||
return nil, err
|
return nil, common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
|
|
||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
@@ -1088,7 +1095,7 @@ func (p *PgSQLTxAdapter) Exec(ctx context.Context, query string, args ...interfa
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL Tx Exec failed: %v", err)
|
logger.Error("PgSQL Tx Exec failed: %v", err)
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
||||||
return nil, err
|
return nil, common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, nil)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, nil)
|
||||||
return &PgSQLResult{result: result}, nil
|
return &PgSQLResult{result: result}, nil
|
||||||
@@ -1102,7 +1109,7 @@ func (p *PgSQLTxAdapter) Query(ctx context.Context, dest interface{}, query stri
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("PgSQL Tx Query failed: %v", err)
|
logger.Error("PgSQL Tx Query failed: %v", err)
|
||||||
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
recordQueryMetrics(p.metricsEnabled, operation, schema, entity, table, startedAt, err)
|
||||||
return err
|
return common.WrapSQLError(err, query)
|
||||||
}
|
}
|
||||||
defer rows.Close()
|
defer rows.Close()
|
||||||
|
|
||||||
|
|||||||
@@ -125,6 +125,13 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
|||||||
result.AffectedRows = 1
|
result.AffectedRows = 1
|
||||||
result.Data = regularData
|
result.Data = regularData
|
||||||
|
|
||||||
|
// Re-select the inserted row so result.Data reflects DB-generated defaults.
|
||||||
|
if row, err := p.processSelect(ctx, tableName, id); err != nil {
|
||||||
|
logger.Warn("Select after insert failed: table=%s, id=%v, error=%v", tableName, id, err)
|
||||||
|
} else if len(row) > 0 {
|
||||||
|
result.Data = row
|
||||||
|
}
|
||||||
|
|
||||||
// Process child relations after parent insert (to get parent ID)
|
// Process child relations after parent insert (to get parent ID)
|
||||||
if err := p.processChildRelations(ctx, "insert", id, relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
if err := p.processChildRelations(ctx, "insert", id, relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||||
logger.Error("Failed to process child relations after insert: table=%s, parentID=%v, relations=%+v, error=%v", tableName, id, relationFields, err)
|
logger.Error("Failed to process child relations after insert: table=%s, parentID=%v, relations=%+v, error=%v", tableName, id, relationFields, err)
|
||||||
@@ -134,8 +141,12 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
|||||||
logger.Debug("Skipping insert for %s - no data columns besides _request", tableName)
|
logger.Debug("Skipping insert for %s - no data columns besides _request", tableName)
|
||||||
}
|
}
|
||||||
|
|
||||||
case "update":
|
case "update", "change":
|
||||||
// Only perform update if we have data to update
|
// Only perform update if we have data to update
|
||||||
|
if reflection.IsEmptyValue(data[pkName]) {
|
||||||
|
logger.Warn("Skipping update for %s - no primary key", tableName)
|
||||||
|
return result, nil
|
||||||
|
}
|
||||||
if hasData {
|
if hasData {
|
||||||
rows, err := p.processUpdate(ctx, regularData, tableName, data[pkName])
|
rows, err := p.processUpdate(ctx, regularData, tableName, data[pkName])
|
||||||
if err != nil {
|
if err != nil {
|
||||||
@@ -146,9 +157,16 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
|||||||
result.AffectedRows = rows
|
result.AffectedRows = rows
|
||||||
result.Data = regularData
|
result.Data = regularData
|
||||||
|
|
||||||
|
// Re-select the updated row so result.Data reflects current DB state.
|
||||||
|
if row, err := p.processSelect(ctx, tableName, result.ID); err != nil {
|
||||||
|
logger.Warn("Select after update failed: table=%s, id=%v, error=%v", tableName, result.ID, err)
|
||||||
|
} else if len(row) > 0 {
|
||||||
|
result.Data = row
|
||||||
|
}
|
||||||
|
|
||||||
// Process child relations for update
|
// Process child relations for update
|
||||||
if err := p.processChildRelations(ctx, "update", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
if err := p.processChildRelations(ctx, "update", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||||
logger.Error("Failed to process child relations after update: table=%s, parentID=%v, relations=%+v, error=%v", tableName, data[pkName], relationFields, err)
|
logger.Error("Failed to process child relations after update: table=%s, parentID=%v, relations=%+v, error=%v", tableName, data[pkName], regularData, err)
|
||||||
return nil, fmt.Errorf("failed to process child relations: %w", err)
|
return nil, fmt.Errorf("failed to process child relations: %w", err)
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
@@ -157,10 +175,15 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
|||||||
}
|
}
|
||||||
|
|
||||||
case "delete":
|
case "delete":
|
||||||
|
if reflection.IsEmptyValue(data[pkName]) {
|
||||||
|
logger.Warn("Skipping delete for %s - no primary key", tableName)
|
||||||
|
return result, nil
|
||||||
|
}
|
||||||
|
|
||||||
// Process child relations first (for referential integrity)
|
// Process child relations first (for referential integrity)
|
||||||
if err := p.processChildRelations(ctx, "delete", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
if err := p.processChildRelations(ctx, "delete", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||||
logger.Error("Failed to process child relations before delete: table=%s, id=%v, relations=%+v, error=%v", tableName, data[pkName], relationFields, err)
|
logger.Error("Failed to process child relations before delete: table=%s, id=%v, relations=%+v, error=%v", tableName, data[pkName], relationFields, err)
|
||||||
return nil, fmt.Errorf("failed to process child relations before delete: %w", err)
|
return nil, fmt.Errorf("failed to process child relations: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
rows, err := p.processDelete(ctx, tableName, data[pkName])
|
rows, err := p.processDelete(ctx, tableName, data[pkName])
|
||||||
@@ -234,10 +257,12 @@ func (p *NestedCUDProcessor) injectForeignKeys(data map[string]interface{}, mode
|
|||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|
||||||
for parentKey, parentID := range parentIDs {
|
pkCol := reflection.GetPrimaryKeyName(reflect.New(modelType).Interface())
|
||||||
dbColName := reflection.GetForeignKeyColumn(modelType, parentKey)
|
|
||||||
|
|
||||||
if dbColName == "" {
|
for parentKey, parentID := range parentIDs {
|
||||||
|
dbColNames := reflection.GetForeignKeyColumn(modelType, parentKey)
|
||||||
|
|
||||||
|
if len(dbColNames) == 0 {
|
||||||
// No explicit tag found — fall back to naming convention by scanning scalar fields.
|
// No explicit tag found — fall back to naming convention by scanning scalar fields.
|
||||||
for i := 0; i < modelType.NumField(); i++ {
|
for i := 0; i < modelType.NumField(); i++ {
|
||||||
field := modelType.Field(i)
|
field := modelType.Field(i)
|
||||||
@@ -248,13 +273,16 @@ func (p *NestedCUDProcessor) injectForeignKeys(data map[string]interface{}, mode
|
|||||||
strings.EqualFold(jsonName, parentKey+"_id") ||
|
strings.EqualFold(jsonName, parentKey+"_id") ||
|
||||||
strings.EqualFold(jsonName, parentKey+"id") ||
|
strings.EqualFold(jsonName, parentKey+"id") ||
|
||||||
strings.EqualFold(field.Name, parentKey+"ID") {
|
strings.EqualFold(field.Name, parentKey+"ID") {
|
||||||
dbColName = reflection.GetColumnName(field)
|
dbColNames = []string{reflection.GetColumnName(field)}
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if dbColName != "" {
|
for _, dbColName := range dbColNames {
|
||||||
|
if pkCol != "" && strings.EqualFold(dbColName, pkCol) {
|
||||||
|
continue
|
||||||
|
}
|
||||||
if _, exists := data[dbColName]; !exists {
|
if _, exists := data[dbColName]; !exists {
|
||||||
logger.Debug("Injecting foreign key: %s = %v", dbColName, parentID)
|
logger.Debug("Injecting foreign key: %s = %v", dbColName, parentID)
|
||||||
data[dbColName] = parentID
|
data[dbColName] = parentID
|
||||||
@@ -289,6 +317,20 @@ func (p *NestedCUDProcessor) processInsert(
|
|||||||
return id, nil
|
return id, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// processSelect fetches the row identified by id from tableName into a flat map.
|
||||||
|
// Used to populate result.Data with the actual DB state after insert/update.
|
||||||
|
func (p *NestedCUDProcessor) processSelect(ctx context.Context, tableName string, id interface{}) (map[string]interface{}, error) {
|
||||||
|
pkName := reflection.GetPrimaryKeyName(tableName)
|
||||||
|
var row map[string]interface{}
|
||||||
|
if err := p.db.NewSelect().
|
||||||
|
Table(tableName).
|
||||||
|
Where(fmt.Sprintf("%s = ?", QuoteIdent(pkName)), id).
|
||||||
|
Scan(ctx, &row); err != nil {
|
||||||
|
return nil, fmt.Errorf("select after write failed: %w", err)
|
||||||
|
}
|
||||||
|
return row, nil
|
||||||
|
}
|
||||||
|
|
||||||
// processUpdate handles update operation
|
// processUpdate handles update operation
|
||||||
func (p *NestedCUDProcessor) processUpdate(
|
func (p *NestedCUDProcessor) processUpdate(
|
||||||
ctx context.Context,
|
ctx context.Context,
|
||||||
|
|||||||
@@ -1,5 +1,23 @@
|
|||||||
package common
|
package common
|
||||||
|
|
||||||
|
// SQLError wraps a database error together with the SQL that caused it,
|
||||||
|
// so callers can surface the query in API error responses for easier debugging.
|
||||||
|
type SQLError struct {
|
||||||
|
Err error
|
||||||
|
SQL string
|
||||||
|
}
|
||||||
|
|
||||||
|
func (e *SQLError) Error() string { return e.Err.Error() }
|
||||||
|
func (e *SQLError) Unwrap() error { return e.Err }
|
||||||
|
|
||||||
|
// WrapSQLError wraps err with the given SQL. If err is nil it returns nil.
|
||||||
|
func WrapSQLError(err error, sql string) error {
|
||||||
|
if err == nil {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
return &SQLError{Err: err, SQL: sql}
|
||||||
|
}
|
||||||
|
|
||||||
type RequestBody struct {
|
type RequestBody struct {
|
||||||
Operation string `json:"operation"`
|
Operation string `json:"operation"`
|
||||||
Data interface{} `json:"data"`
|
Data interface{} `json:"data"`
|
||||||
@@ -104,6 +122,7 @@ type APIError struct {
|
|||||||
Message string `json:"message"`
|
Message string `json:"message"`
|
||||||
Details interface{} `json:"details,omitempty"`
|
Details interface{} `json:"details,omitempty"`
|
||||||
Detail string `json:"detail,omitempty"`
|
Detail string `json:"detail,omitempty"`
|
||||||
|
SQL string `json:"sql,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
type Column struct {
|
type Column struct {
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package funcspec
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"io"
|
"io"
|
||||||
"net/http"
|
"net/http"
|
||||||
@@ -1071,6 +1072,10 @@ func sendError(w http.ResponseWriter, status int, code, message string, err erro
|
|||||||
}
|
}
|
||||||
if err != nil {
|
if err != nil {
|
||||||
errObj.Detail = err.Error()
|
errObj.Detail = err.Error()
|
||||||
|
var sqlErr *common.SQLError
|
||||||
|
if errors.As(err, &sqlErr) {
|
||||||
|
errObj.SQL = sqlErr.SQL
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
data, _ := json.Marshal(map[string]interface{}{
|
data, _ := json.Marshal(map[string]interface{}{
|
||||||
|
|||||||
@@ -51,6 +51,31 @@ func ExtractTableNameOnly(fullName string) string {
|
|||||||
return fullName[startIndex:]
|
return fullName[startIndex:]
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// IsEmptyValue reports whether v is nil, an empty string, or a zero number.
|
||||||
|
func IsEmptyValue(v any) bool {
|
||||||
|
if v == nil {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
rv := reflect.ValueOf(v)
|
||||||
|
if rv.Kind() == reflect.Ptr {
|
||||||
|
if rv.IsNil() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
rv = rv.Elem()
|
||||||
|
}
|
||||||
|
switch rv.Kind() {
|
||||||
|
case reflect.String:
|
||||||
|
return rv.String() == ""
|
||||||
|
case reflect.Int, reflect.Int8, reflect.Int16, reflect.Int32, reflect.Int64:
|
||||||
|
return rv.Int() == 0
|
||||||
|
case reflect.Uint, reflect.Uint8, reflect.Uint16, reflect.Uint32, reflect.Uint64, reflect.Uintptr:
|
||||||
|
return rv.Uint() == 0
|
||||||
|
case reflect.Float32, reflect.Float64:
|
||||||
|
return rv.Float() == 0
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
// GetPointerElement returns the element type if the provided reflect.Type is a pointer.
|
// GetPointerElement returns the element type if the provided reflect.Type is a pointer.
|
||||||
// If the type is a slice of pointers, it returns the element type of the pointer within the slice.
|
// If the type is a slice of pointers, it returns the element type of the pointer within the slice.
|
||||||
// If neither condition is met, it returns the original type.
|
// If neither condition is met, it returns the original type.
|
||||||
|
|||||||
@@ -973,23 +973,31 @@ func GetRelationType(model interface{}, fieldName string) RelationType {
|
|||||||
return RelationUnknown
|
return RelationUnknown
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetForeignKeyColumn returns the DB column name of the foreign key that the
|
// GetForeignKeyColumn returns the DB column names of the foreign key(s) that
|
||||||
// relation field identified by parentKey owns on modelType.
|
// relate parentKey to modelType. Composite keys (e.g. bun "join:a=b,join:c=d"
|
||||||
|
// or GORM "foreignKey:ColA,ColB") yield multiple entries. Returns nil when no
|
||||||
|
// tag is found (caller should fall back to convention).
|
||||||
//
|
//
|
||||||
// It checks tags in priority order:
|
// Two lookup strategies are tried in order:
|
||||||
// 1. Bun join: tag — e.g. `bun:"rel:belongs-to,join:department_id=id"` → "department_id"
|
|
||||||
// 2. GORM foreignKey: tag — e.g. `gorm:"foreignKey:DepartmentID"` → column of DepartmentID field
|
|
||||||
// 3. Returns "" when no tag is found (caller should fall back to convention)
|
|
||||||
//
|
//
|
||||||
// parentKey is matched case-insensitively against the field name and JSON tag.
|
// 1. Relation-field match: find a field whose name/json equals parentKey, then
|
||||||
func GetForeignKeyColumn(modelType reflect.Type, parentKey string) string {
|
// read its bun join: or GORM foreignKey: tag and return the local columns.
|
||||||
|
// e.g. parentKey="department", field `Department bun:"join:dept_id=id"` → ["dept_id"]
|
||||||
|
//
|
||||||
|
// 2. Join left-side scan: scan every bun join tag in the struct for pairs whose
|
||||||
|
// left side equals parentKey and return the right-side (child FK) columns.
|
||||||
|
// e.g. parentKey="rid_mastertaskitem", field `Children bun:"join:rid_mastertaskitem=rid_parentmastertaskitem"` → ["rid_parentmastertaskitem"]
|
||||||
|
// Strategy 1 is skipped if the matched field is a declared relation (rel:) or
|
||||||
|
// has a GORM tag but carries no explicit FK — callers should use convention.
|
||||||
|
func GetForeignKeyColumn(modelType reflect.Type, parentKey string) []string {
|
||||||
for modelType.Kind() == reflect.Ptr || modelType.Kind() == reflect.Slice {
|
for modelType.Kind() == reflect.Ptr || modelType.Kind() == reflect.Slice {
|
||||||
modelType = modelType.Elem()
|
modelType = modelType.Elem()
|
||||||
}
|
}
|
||||||
if modelType.Kind() != reflect.Struct {
|
if modelType.Kind() != reflect.Struct {
|
||||||
return ""
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// Strategy 1: match parentKey against a field's name/json tag.
|
||||||
for i := 0; i < modelType.NumField(); i++ {
|
for i := 0; i < modelType.NumField(); i++ {
|
||||||
field := modelType.Field(i)
|
field := modelType.Field(i)
|
||||||
|
|
||||||
@@ -999,34 +1007,72 @@ func GetForeignKeyColumn(modelType reflect.Type, parentKey string) string {
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
|
|
||||||
// Bun: join:local_col=foreign_col
|
bunTag := field.Tag.Get("bun")
|
||||||
for _, part := range strings.Split(field.Tag.Get("bun"), ",") {
|
|
||||||
|
// Bun: join:local_col=foreign_col (one join: part per pair)
|
||||||
|
var bunCols []string
|
||||||
|
for _, part := range strings.Split(bunTag, ",") {
|
||||||
part = strings.TrimSpace(part)
|
part = strings.TrimSpace(part)
|
||||||
if strings.HasPrefix(part, "join:") {
|
if strings.HasPrefix(part, "join:") {
|
||||||
// join: may contain multiple pairs separated by spaces: "join:a=b join:c=d"
|
|
||||||
// but typically it's a single pair; take the first local column
|
|
||||||
pair := strings.TrimPrefix(part, "join:")
|
pair := strings.TrimPrefix(part, "join:")
|
||||||
if idx := strings.Index(pair, "="); idx > 0 {
|
if idx := strings.Index(pair, "="); idx > 0 {
|
||||||
return pair[:idx]
|
bunCols = append(bunCols, pair[:idx])
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
if len(bunCols) > 0 {
|
||||||
|
return bunCols
|
||||||
|
}
|
||||||
|
|
||||||
// GORM: foreignKey:FieldName
|
// GORM: foreignKey:FieldA,FieldB
|
||||||
for _, part := range strings.Split(field.Tag.Get("gorm"), ";") {
|
for _, part := range strings.Split(field.Tag.Get("gorm"), ";") {
|
||||||
part = strings.TrimSpace(part)
|
part = strings.TrimSpace(part)
|
||||||
if strings.HasPrefix(part, "foreignKey:") {
|
if strings.HasPrefix(part, "foreignKey:") {
|
||||||
fkFieldName := strings.TrimPrefix(part, "foreignKey:")
|
var cols []string
|
||||||
if fkField, ok := modelType.FieldByName(fkFieldName); ok {
|
for _, fkFieldName := range strings.Split(strings.TrimPrefix(part, "foreignKey:"), ",") {
|
||||||
return getColumnNameFromField(fkField)
|
fkFieldName = strings.TrimSpace(fkFieldName)
|
||||||
|
if fkField, ok := modelType.FieldByName(fkFieldName); ok {
|
||||||
|
cols = append(cols, getColumnNameFromField(fkField))
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if len(cols) > 0 {
|
||||||
|
return cols
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
return ""
|
// The field matched by name/json but has no explicit FK tag. If it is a
|
||||||
|
// declared relation field (rel:) or carries a GORM tag, the caller should
|
||||||
|
// use naming convention — don't fall through to strategy 2. Otherwise the
|
||||||
|
// matched field is a plain scalar column; proceed to the join left-side scan.
|
||||||
|
if strings.Contains(bunTag, "rel:") || field.Tag.Get("gorm") != "" {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
break
|
||||||
}
|
}
|
||||||
|
|
||||||
return ""
|
// Strategy 2: scan every field's bun join tag for pairs whose left side (the
|
||||||
|
// parent's column) matches parentKey; the right side is the child FK column.
|
||||||
|
// This handles cases where parentKey is a raw column name rather than a
|
||||||
|
// relation field name (e.g. self-referential or has-many relationships).
|
||||||
|
seen := map[string]bool{}
|
||||||
|
var cols []string
|
||||||
|
for i := 0; i < modelType.NumField(); i++ {
|
||||||
|
for _, part := range strings.Split(modelType.Field(i).Tag.Get("bun"), ",") {
|
||||||
|
part = strings.TrimSpace(part)
|
||||||
|
if strings.HasPrefix(part, "join:") {
|
||||||
|
pair := strings.TrimPrefix(part, "join:")
|
||||||
|
if idx := strings.Index(pair, "="); idx > 0 {
|
||||||
|
left, right := pair[:idx], pair[idx+1:]
|
||||||
|
if strings.EqualFold(left, parentKey) && !seen[right] {
|
||||||
|
seen[right] = true
|
||||||
|
cols = append(cols, right)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
return cols // nil if empty
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetRelationModel gets the model type for a relation field
|
// GetRelationModel gets the model type for a relation field
|
||||||
|
|||||||
@@ -15,6 +15,13 @@ type bunEmployee struct {
|
|||||||
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id" json:"department"`
|
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id" json:"department"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// bunCompositeEmployee has a composite bun join: (two join: parts).
|
||||||
|
type bunCompositeEmployee struct {
|
||||||
|
DeptID string `bun:"dept_id" json:"dept_id"`
|
||||||
|
TenantID string `bun:"tenant_id" json:"tenant_id"`
|
||||||
|
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id,join:tenant_id=id" json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
// gormEmployee uses gorm foreignKey: tag (mirrors testmodels.Employee).
|
// gormEmployee uses gorm foreignKey: tag (mirrors testmodels.Employee).
|
||||||
type gormEmployee struct {
|
type gormEmployee struct {
|
||||||
DepartmentID string `json:"department_id"`
|
DepartmentID string `json:"department_id"`
|
||||||
@@ -23,6 +30,24 @@ type gormEmployee struct {
|
|||||||
Manager *fkDept `gorm:"foreignKey:ManagerID;references:ID" json:"manager"`
|
Manager *fkDept `gorm:"foreignKey:ManagerID;references:ID" json:"manager"`
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// gormCompositeEmployee has a composite GORM foreignKey.
|
||||||
|
type gormCompositeEmployee struct {
|
||||||
|
DeptID string `json:"dept_id"`
|
||||||
|
TenantID string `json:"tenant_id"`
|
||||||
|
Department *fkDept `gorm:"foreignKey:DeptID,TenantID" json:"department"`
|
||||||
|
}
|
||||||
|
|
||||||
|
// selfRefItem mimics a self-referential model (like mastertaskitem) where the
|
||||||
|
// parent PK column appears as the left side of a has-many join tag.
|
||||||
|
type selfRefItem struct {
|
||||||
|
RidItem int32 `json:"rid_item" bun:"rid_item,type:integer,pk"`
|
||||||
|
RidParentItem int32 `json:"rid_parentitem" bun:"rid_parentitem,type:integer"`
|
||||||
|
// has-one (single parent pointer)
|
||||||
|
Parent *selfRefItem `json:"Parent,omitempty" bun:"rel:has-one,join:rid_item=rid_parentitem"`
|
||||||
|
// has-many (child collection) — same join, duplicate right-side must be deduped
|
||||||
|
Children []*selfRefItem `json:"Children,omitempty" bun:"rel:has-many,join:rid_item=rid_parentitem"`
|
||||||
|
}
|
||||||
|
|
||||||
// conventionEmployee has no explicit FK tag — relies on naming convention.
|
// conventionEmployee has no explicit FK tag — relies on naming convention.
|
||||||
type conventionEmployee struct {
|
type conventionEmployee struct {
|
||||||
DepartmentID string `json:"department_id"`
|
DepartmentID string `json:"department_id"`
|
||||||
@@ -39,20 +64,26 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
|||||||
name string
|
name string
|
||||||
modelType reflect.Type
|
modelType reflect.Type
|
||||||
parentKey string
|
parentKey string
|
||||||
want string
|
want []string
|
||||||
}{
|
}{
|
||||||
// Bun join: tag
|
// Bun join: tag
|
||||||
{
|
{
|
||||||
name: "bun join tag returns local column",
|
name: "bun join tag returns local column",
|
||||||
modelType: reflect.TypeOf(bunEmployee{}),
|
modelType: reflect.TypeOf(bunEmployee{}),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "dept_id",
|
want: []string{"dept_id"},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "bun join tag matched via json tag (case-insensitive)",
|
name: "bun join tag matched via json tag (case-insensitive)",
|
||||||
modelType: reflect.TypeOf(bunEmployee{}),
|
modelType: reflect.TypeOf(bunEmployee{}),
|
||||||
parentKey: "Department",
|
parentKey: "Department",
|
||||||
want: "dept_id",
|
want: []string{"dept_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "bun composite join returns all local columns",
|
||||||
|
modelType: reflect.TypeOf(bunCompositeEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"dept_id", "tenant_id"},
|
||||||
},
|
},
|
||||||
|
|
||||||
// GORM foreignKey: tag
|
// GORM foreignKey: tag
|
||||||
@@ -60,19 +91,33 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
|||||||
name: "gorm foreignKey resolves to column name",
|
name: "gorm foreignKey resolves to column name",
|
||||||
modelType: reflect.TypeOf(gormEmployee{}),
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "department_id",
|
want: []string{"department_id"},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "gorm foreignKey resolves second relation",
|
name: "gorm foreignKey resolves second relation",
|
||||||
modelType: reflect.TypeOf(gormEmployee{}),
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
parentKey: "manager",
|
parentKey: "manager",
|
||||||
want: "manager_id",
|
want: []string{"manager_id"},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "gorm foreignKey matched case-insensitively",
|
name: "gorm foreignKey matched case-insensitively",
|
||||||
modelType: reflect.TypeOf(gormEmployee{}),
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
parentKey: "Department",
|
parentKey: "Department",
|
||||||
want: "department_id",
|
want: []string{"department_id"},
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "gorm composite foreignKey returns all columns",
|
||||||
|
modelType: reflect.TypeOf(gormCompositeEmployee{}),
|
||||||
|
parentKey: "department",
|
||||||
|
want: []string{"dept_id", "tenant_id"},
|
||||||
|
},
|
||||||
|
|
||||||
|
// Join left-side scan (parentKey is a raw column name, not a relation field name)
|
||||||
|
{
|
||||||
|
name: "self-referential: parent PK column returns child FK column",
|
||||||
|
modelType: reflect.TypeOf(selfRefItem{}),
|
||||||
|
parentKey: "rid_item",
|
||||||
|
want: []string{"rid_parentitem"},
|
||||||
},
|
},
|
||||||
|
|
||||||
// Pointer and slice unwrapping
|
// Pointer and slice unwrapping
|
||||||
@@ -80,43 +125,43 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
|||||||
name: "pointer to struct is unwrapped",
|
name: "pointer to struct is unwrapped",
|
||||||
modelType: reflect.TypeOf(&gormEmployee{}),
|
modelType: reflect.TypeOf(&gormEmployee{}),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "department_id",
|
want: []string{"department_id"},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "slice of struct is unwrapped",
|
name: "slice of struct is unwrapped",
|
||||||
modelType: reflect.TypeOf([]gormEmployee{}),
|
modelType: reflect.TypeOf([]gormEmployee{}),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "department_id",
|
want: []string{"department_id"},
|
||||||
},
|
},
|
||||||
|
|
||||||
// No tag — returns "" so caller can fall back to convention
|
// No tag — returns nil so caller can fall back to convention
|
||||||
{
|
{
|
||||||
name: "relation with no FK tag returns empty string",
|
name: "relation with no FK tag returns nil",
|
||||||
modelType: reflect.TypeOf(conventionEmployee{}),
|
modelType: reflect.TypeOf(conventionEmployee{}),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "",
|
want: nil,
|
||||||
},
|
},
|
||||||
|
|
||||||
// Unknown parent key
|
// Unknown parent key
|
||||||
{
|
{
|
||||||
name: "unknown parent key returns empty string",
|
name: "unknown parent key returns nil",
|
||||||
modelType: reflect.TypeOf(gormEmployee{}),
|
modelType: reflect.TypeOf(gormEmployee{}),
|
||||||
parentKey: "nonexistent",
|
parentKey: "nonexistent",
|
||||||
want: "",
|
want: nil,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "non-struct type returns empty string",
|
name: "non-struct type returns nil",
|
||||||
modelType: reflect.TypeOf(""),
|
modelType: reflect.TypeOf(""),
|
||||||
parentKey: "department",
|
parentKey: "department",
|
||||||
want: "",
|
want: nil,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tt := range tests {
|
for _, tt := range tests {
|
||||||
t.Run(tt.name, func(t *testing.T) {
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
got := GetForeignKeyColumn(tt.modelType, tt.parentKey)
|
got := GetForeignKeyColumn(tt.modelType, tt.parentKey)
|
||||||
if got != tt.want {
|
if !reflect.DeepEqual(got, tt.want) {
|
||||||
t.Errorf("GetForeignKeyColumn(%v, %q) = %q, want %q", tt.modelType, tt.parentKey, got, tt.want)
|
t.Errorf("GetForeignKeyColumn(%v, %q) = %v, want %v", tt.modelType, tt.parentKey, got, tt.want)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import (
|
|||||||
"context"
|
"context"
|
||||||
"database/sql"
|
"database/sql"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"net/http"
|
"net/http"
|
||||||
"reflect"
|
"reflect"
|
||||||
@@ -1757,18 +1758,21 @@ func (h *Handler) sendResponse(w common.ResponseWriter, data interface{}, metada
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (h *Handler) sendError(w common.ResponseWriter, status int, code, message string, details interface{}) {
|
func (h *Handler) sendError(w common.ResponseWriter, status int, code, message string, details interface{}) {
|
||||||
|
apiErr := &common.APIError{
|
||||||
|
Code: code,
|
||||||
|
Message: message,
|
||||||
|
Details: details,
|
||||||
|
Detail: fmt.Sprintf("%v", details),
|
||||||
|
}
|
||||||
|
if asErr, ok := details.(error); ok {
|
||||||
|
var sqlErr *common.SQLError
|
||||||
|
if errors.As(asErr, &sqlErr) {
|
||||||
|
apiErr.SQL = sqlErr.SQL
|
||||||
|
}
|
||||||
|
}
|
||||||
w.SetHeader("Content-Type", "application/json")
|
w.SetHeader("Content-Type", "application/json")
|
||||||
w.WriteHeader(status)
|
w.WriteHeader(status)
|
||||||
err := w.WriteJSON(common.Response{
|
if err := w.WriteJSON(common.Response{Success: false, Error: apiErr}); err != nil {
|
||||||
Success: false,
|
|
||||||
Error: &common.APIError{
|
|
||||||
Code: code,
|
|
||||||
Message: message,
|
|
||||||
Details: details,
|
|
||||||
Detail: fmt.Sprintf("%v", details),
|
|
||||||
},
|
|
||||||
})
|
|
||||||
if err != nil {
|
|
||||||
logger.Error("Error sending response: %v", err)
|
logger.Error("Error sending response: %v", err)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -9,29 +9,29 @@ import (
|
|||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
)
|
)
|
||||||
|
|
||||||
// Test that normalizeResultArray returns empty array when no records found without ID
|
// Test that normalizeResultArray returns empty object when no records found (single-record mode)
|
||||||
func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
||||||
handler := &Handler{}
|
handler := &Handler{}
|
||||||
|
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
name string
|
name string
|
||||||
input interface{}
|
input interface{}
|
||||||
shouldBeEmptyArr bool
|
shouldBeEmptyObj bool
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "nil should return empty array",
|
name: "nil should return empty object",
|
||||||
input: nil,
|
input: nil,
|
||||||
shouldBeEmptyArr: true,
|
shouldBeEmptyObj: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "empty slice should return empty array",
|
name: "empty slice should return empty object",
|
||||||
input: []*EmptyTestModel{},
|
input: []*EmptyTestModel{},
|
||||||
shouldBeEmptyArr: true,
|
shouldBeEmptyObj: true,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "single element should return the element",
|
name: "single element should return the element",
|
||||||
input: []*EmptyTestModel{{ID: 1, Name: "test"}},
|
input: []*EmptyTestModel{{ID: 1, Name: "test"}},
|
||||||
shouldBeEmptyArr: false,
|
shouldBeEmptyObj: false,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "multiple elements should return the slice",
|
name: "multiple elements should return the slice",
|
||||||
@@ -39,7 +39,7 @@ func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
|||||||
{ID: 1, Name: "test1"},
|
{ID: 1, Name: "test1"},
|
||||||
{ID: 2, Name: "test2"},
|
{ID: 2, Name: "test2"},
|
||||||
},
|
},
|
||||||
shouldBeEmptyArr: false,
|
shouldBeEmptyObj: false,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -47,25 +47,25 @@ func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
|||||||
t.Run(tt.name, func(t *testing.T) {
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
result := handler.normalizeResultArray(tt.input)
|
result := handler.normalizeResultArray(tt.input)
|
||||||
|
|
||||||
// For cases that should return empty array
|
// For cases that should return empty object
|
||||||
if tt.shouldBeEmptyArr {
|
if tt.shouldBeEmptyObj {
|
||||||
emptyArr, ok := result.([]interface{})
|
emptyObj, ok := result.(map[string]interface{})
|
||||||
if !ok {
|
if !ok {
|
||||||
t.Errorf("Expected empty array []interface{}{}, got %T: %v", result, result)
|
t.Errorf("Expected empty object map[string]interface{}{}, got %T: %v", result, result)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if len(emptyArr) != 0 {
|
if len(emptyObj) != 0 {
|
||||||
t.Errorf("Expected empty array with length 0, got length %d", len(emptyArr))
|
t.Errorf("Expected empty object with length 0, got length %d", len(emptyObj))
|
||||||
}
|
}
|
||||||
|
|
||||||
// Verify it serializes to [] and not null
|
// Verify it serializes to {} and not null
|
||||||
jsonBytes, err := json.Marshal(result)
|
jsonBytes, err := json.Marshal(result)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Errorf("Failed to marshal result: %v", err)
|
t.Errorf("Failed to marshal result: %v", err)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
if string(jsonBytes) != "[]" {
|
if string(jsonBytes) != "{}" {
|
||||||
t.Errorf("Expected JSON '[]', got '%s'", string(jsonBytes))
|
t.Errorf("Expected JSON '{}', got '%s'", string(jsonBytes))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
@@ -138,12 +138,12 @@ func TestSendResponseWithOptions_NoDataFoundHeader(t *testing.T) {
|
|||||||
t.Errorf("Expected X-No-Data-Found header to be 'true', got '%s'", mockWriter.headers["X-No-Data-Found"])
|
t.Errorf("Expected X-No-Data-Found header to be 'true', got '%s'", mockWriter.headers["X-No-Data-Found"])
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check status code is 200
|
// Check status code is 200 even when no records found
|
||||||
if mockWriter.statusCode != 200 {
|
if mockWriter.statusCode != 200 {
|
||||||
t.Errorf("Expected status code 200, got %d", mockWriter.statusCode)
|
t.Errorf("Expected status code 200, got %d", mockWriter.statusCode)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Verify the body is an empty array
|
// Verify the body is an empty array (list request, SingleRecordAsObject not set)
|
||||||
if mockWriter.body == nil {
|
if mockWriter.body == nil {
|
||||||
t.Error("Expected body to be set, got nil")
|
t.Error("Expected body to be set, got nil")
|
||||||
} else {
|
} else {
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import (
|
|||||||
"context"
|
"context"
|
||||||
"database/sql"
|
"database/sql"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"net/http"
|
"net/http"
|
||||||
"reflect"
|
"reflect"
|
||||||
@@ -579,8 +580,8 @@ func (h *Handler) handleRead(ctx context.Context, w common.ResponseWriter, id st
|
|||||||
// preload LEFT JOIN (to prevent "table name specified more than once" errors).
|
// preload LEFT JOIN (to prevent "table name specified more than once" errors).
|
||||||
if len(options.CustomSQLJoin) > 0 {
|
if len(options.CustomSQLJoin) > 0 {
|
||||||
preloadAliasSet := make(map[string]bool, len(options.Preload))
|
preloadAliasSet := make(map[string]bool, len(options.Preload))
|
||||||
for _, p := range options.Preload {
|
for i := range options.Preload {
|
||||||
if alias := common.RelationPathToBunAlias(p.Relation); alias != "" {
|
if alias := common.RelationPathToBunAlias(options.Preload[i].Relation); alias != "" {
|
||||||
preloadAliasSet[alias] = true
|
preloadAliasSet[alias] = true
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -619,16 +620,19 @@ func (h *Handler) handleRead(ctx context.Context, w common.ResponseWriter, id st
|
|||||||
logger.Debug("FetchRowNumber: Row number %d for PK %s = %s", rowNum, pkName, fetchRowNumberPKValue)
|
logger.Debug("FetchRowNumber: Row number %d for PK %s = %s", rowNum, pkName, fetchRowNumberPKValue)
|
||||||
|
|
||||||
// Now filter the main query to this specific primary key
|
// Now filter the main query to this specific primary key
|
||||||
query = query.Where(fmt.Sprintf("%s = ?", common.QuoteIdent(pkName)), fetchRowNumberPKValue)
|
tableAlias := reflection.ExtractTableNameOnly(tableName)
|
||||||
|
query = query.Where(fmt.Sprintf("%s.%s = ?", common.QuoteIdent(tableAlias), common.QuoteIdent(pkName)), fetchRowNumberPKValue)
|
||||||
} else if id != "" {
|
} else if id != "" {
|
||||||
// If ID is provided (and not FetchRowNumber), filter by ID
|
// If ID is provided (and not FetchRowNumber), filter by ID
|
||||||
pkName := reflection.GetPrimaryKeyName(model)
|
pkName := reflection.GetPrimaryKeyName(model)
|
||||||
logger.Debug("Filtering by ID=%s: %s", pkName, id)
|
logger.Debug("Filtering by ID=%s: %s", pkName, id)
|
||||||
|
|
||||||
query = query.Where(fmt.Sprintf("%s = ?", common.QuoteIdent(pkName)), id)
|
tableAlias := reflection.ExtractTableNameOnly(tableName)
|
||||||
|
query = query.Where(fmt.Sprintf("%s.%s = ?", common.QuoteIdent(tableAlias), common.QuoteIdent(pkName)), id)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Apply sorting
|
// Apply sorting
|
||||||
|
tableAlias := reflection.ExtractTableNameOnly(tableName)
|
||||||
for _, sort := range options.Sort {
|
for _, sort := range options.Sort {
|
||||||
direction := "ASC"
|
direction := "ASC"
|
||||||
if strings.EqualFold(sort.Direction, "desc") {
|
if strings.EqualFold(sort.Direction, "desc") {
|
||||||
@@ -640,9 +644,12 @@ func (h *Handler) handleRead(ctx context.Context, w common.ResponseWriter, id st
|
|||||||
if strings.HasPrefix(sort.Column, "(") && strings.HasSuffix(sort.Column, ")") {
|
if strings.HasPrefix(sort.Column, "(") && strings.HasSuffix(sort.Column, ")") {
|
||||||
// For expressions, pass as raw SQL to prevent auto-quoting
|
// For expressions, pass as raw SQL to prevent auto-quoting
|
||||||
query = query.OrderExpr(fmt.Sprintf("%s %s", sort.Column, direction))
|
query = query.OrderExpr(fmt.Sprintf("%s %s", sort.Column, direction))
|
||||||
|
} else if strings.Contains(sort.Column, ".") {
|
||||||
|
// Already qualified (e.g. alias.column) - pass as raw expression to preserve the dot
|
||||||
|
query = query.OrderExpr(fmt.Sprintf("%s %s", sort.Column, direction))
|
||||||
} else {
|
} else {
|
||||||
// Regular column - let Bun handle quoting
|
// Unqualified column - prefix with main table alias to avoid ambiguity on JOINs
|
||||||
query = query.Order(fmt.Sprintf("%s %s", sort.Column, direction))
|
query = query.OrderExpr(fmt.Sprintf("%s.%s %s", common.QuoteIdent(tableAlias), common.QuoteIdent(sort.Column), direction))
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -1360,7 +1367,7 @@ func (h *Handler) handleUpdate(ctx context.Context, w common.ResponseWriter, id
|
|||||||
|
|
||||||
// First, read the existing record from the database
|
// First, read the existing record from the database
|
||||||
existingRecord := reflect.New(reflection.GetPointerElement(reflect.TypeOf(model))).Interface()
|
existingRecord := reflect.New(reflection.GetPointerElement(reflect.TypeOf(model))).Interface()
|
||||||
selectQuery := tx.NewSelect().Model(existingRecord).Column("*").Where(fmt.Sprintf("%s = ?", common.QuoteIdent(pkName)), targetID)
|
selectQuery := tx.NewSelect().Model(existingRecord).Where(fmt.Sprintf("%s = ?", common.QuoteIdent(pkName)), targetID)
|
||||||
if err := selectQuery.ScanModel(ctx); err != nil {
|
if err := selectQuery.ScanModel(ctx); err != nil {
|
||||||
if err == sql.ErrNoRows {
|
if err == sql.ErrNoRows {
|
||||||
return fmt.Errorf("record not found with ID: %v", targetID)
|
return fmt.Errorf("record not found with ID: %v", targetID)
|
||||||
@@ -2502,14 +2509,12 @@ func (h *Handler) sendResponseWithOptions(w common.ResponseWriter, data interfac
|
|||||||
w.SetHeader("X-No-Data-Found", "true")
|
w.SetHeader("X-No-Data-Found", "true")
|
||||||
}
|
}
|
||||||
|
|
||||||
w.WriteHeader(http.StatusOK)
|
|
||||||
|
|
||||||
// Normalize single-record arrays to objects if requested
|
// Normalize single-record arrays to objects if requested
|
||||||
if options != nil && options.SingleRecordAsObject {
|
if options != nil && options.SingleRecordAsObject {
|
||||||
data = h.normalizeResultArray(data)
|
data = h.normalizeResultArray(data)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Return data as-is without wrapping in common.Response
|
w.WriteHeader(http.StatusOK)
|
||||||
|
|
||||||
if err := w.WriteJSON(data); err != nil {
|
if err := w.WriteJSON(data); err != nil {
|
||||||
logger.Error("Failed to write JSON response: %v", err)
|
logger.Error("Failed to write JSON response: %v", err)
|
||||||
@@ -2520,7 +2525,7 @@ func (h *Handler) sendResponseWithOptions(w common.ResponseWriter, data interfac
|
|||||||
// Returns the single element if data is a slice/array with exactly one element, otherwise returns data unchanged
|
// Returns the single element if data is a slice/array with exactly one element, otherwise returns data unchanged
|
||||||
func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
||||||
if data == nil {
|
if data == nil {
|
||||||
return []interface{}{}
|
return map[string]interface{}{}
|
||||||
}
|
}
|
||||||
|
|
||||||
// Use reflection to check if data is a slice or array
|
// Use reflection to check if data is a slice or array
|
||||||
@@ -2535,15 +2540,15 @@ func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
|||||||
// Return the single element
|
// Return the single element
|
||||||
return dataValue.Index(0).Interface()
|
return dataValue.Index(0).Interface()
|
||||||
} else if dataValue.Len() == 0 {
|
} else if dataValue.Len() == 0 {
|
||||||
// Keep empty array as empty array, don't convert to empty object
|
// Single-record request with no result → empty object
|
||||||
return []interface{}{}
|
return map[string]interface{}{}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if dataValue.Kind() == reflect.String {
|
if dataValue.Kind() == reflect.String {
|
||||||
str := dataValue.String()
|
str := dataValue.String()
|
||||||
if str == "" || str == "null" {
|
if str == "" || str == "null" {
|
||||||
return []interface{}{}
|
return map[string]interface{}{}
|
||||||
}
|
}
|
||||||
|
|
||||||
}
|
}
|
||||||
@@ -2552,9 +2557,6 @@ func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
|||||||
|
|
||||||
// sendFormattedResponse sends response with formatting options
|
// sendFormattedResponse sends response with formatting options
|
||||||
func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{}, metadata *common.Metadata, options ExtendedRequestOptions) {
|
func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{}, metadata *common.Metadata, options ExtendedRequestOptions) {
|
||||||
// Normalize single-record arrays to objects if requested
|
|
||||||
httpStatus := http.StatusOK
|
|
||||||
|
|
||||||
// Handle nil data - convert to empty array
|
// Handle nil data - convert to empty array
|
||||||
if data == nil {
|
if data == nil {
|
||||||
data = []interface{}{}
|
data = []interface{}{}
|
||||||
@@ -2591,7 +2593,7 @@ func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{
|
|||||||
switch options.ResponseFormat {
|
switch options.ResponseFormat {
|
||||||
case "simple":
|
case "simple":
|
||||||
// Simple format: just return the data array
|
// Simple format: just return the data array
|
||||||
w.WriteHeader(httpStatus)
|
w.WriteHeader(http.StatusOK)
|
||||||
if err := w.WriteJSON(data); err != nil {
|
if err := w.WriteJSON(data); err != nil {
|
||||||
logger.Error("Failed to write JSON response: %v", err)
|
logger.Error("Failed to write JSON response: %v", err)
|
||||||
}
|
}
|
||||||
@@ -2603,7 +2605,7 @@ func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{
|
|||||||
if metadata != nil {
|
if metadata != nil {
|
||||||
response["count"] = metadata.Total
|
response["count"] = metadata.Total
|
||||||
}
|
}
|
||||||
w.WriteHeader(httpStatus)
|
w.WriteHeader(http.StatusOK)
|
||||||
if err := w.WriteJSON(response); err != nil {
|
if err := w.WriteJSON(response); err != nil {
|
||||||
logger.Error("Failed to write JSON response: %v", err)
|
logger.Error("Failed to write JSON response: %v", err)
|
||||||
}
|
}
|
||||||
@@ -2614,7 +2616,7 @@ func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{
|
|||||||
Data: data,
|
Data: data,
|
||||||
Metadata: metadata,
|
Metadata: metadata,
|
||||||
}
|
}
|
||||||
w.WriteHeader(httpStatus)
|
w.WriteHeader(http.StatusOK)
|
||||||
if err := w.WriteJSON(response); err != nil {
|
if err := w.WriteJSON(response); err != nil {
|
||||||
logger.Error("Failed to write JSON response: %v", err)
|
logger.Error("Failed to write JSON response: %v", err)
|
||||||
}
|
}
|
||||||
@@ -2644,6 +2646,12 @@ func (h *Handler) sendError(w common.ResponseWriter, statusCode int, code, messa
|
|||||||
"_error": errorMsg,
|
"_error": errorMsg,
|
||||||
"_retval": 1,
|
"_retval": 1,
|
||||||
}
|
}
|
||||||
|
|
||||||
|
var sqlErr *common.SQLError
|
||||||
|
if errors.As(err, &sqlErr) {
|
||||||
|
response["_sql"] = sqlErr.SQL
|
||||||
|
}
|
||||||
|
|
||||||
w.SetHeader("Content-Type", "application/json")
|
w.SetHeader("Content-Type", "application/json")
|
||||||
w.WriteHeader(statusCode)
|
w.WriteHeader(statusCode)
|
||||||
if jsonErr := w.WriteJSON(response); jsonErr != nil {
|
if jsonErr := w.WriteJSON(response); jsonErr != nil {
|
||||||
|
|||||||
57
pkg/security/chain.go
Normal file
57
pkg/security/chain.go
Normal file
@@ -0,0 +1,57 @@
|
|||||||
|
package security
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"net/http"
|
||||||
|
)
|
||||||
|
|
||||||
|
// ChainAuthenticator tries each authenticator in order, returning the first success.
|
||||||
|
// Login and Logout are delegated to the primary authenticator.
|
||||||
|
type ChainAuthenticator struct {
|
||||||
|
authenticators []Authenticator
|
||||||
|
authenticateCallback func(r *http.Request) (*UserContext, error)
|
||||||
|
}
|
||||||
|
|
||||||
|
// NewChainAuthenticator creates a ChainAuthenticator from the given authenticators.
|
||||||
|
// At least one authenticator is required; the first is treated as primary for Login/Logout.
|
||||||
|
func NewChainAuthenticator(primary Authenticator, rest ...Authenticator) *ChainAuthenticator {
|
||||||
|
return &ChainAuthenticator{
|
||||||
|
authenticators: append([]Authenticator{primary}, rest...),
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
|
var lastErr error
|
||||||
|
for _, a := range c.authenticators {
|
||||||
|
if uc, err := a.Authenticate(r); err == nil {
|
||||||
|
return uc, nil
|
||||||
|
} else {
|
||||||
|
lastErr = err
|
||||||
|
}
|
||||||
|
}
|
||||||
|
if c.authenticateCallback != nil {
|
||||||
|
return c.authenticateCallback(r)
|
||||||
|
}
|
||||||
|
return nil, fmt.Errorf("all authenticators failed; last error: %w", lastErr)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) SetAuthenticateCallback(fn func(r *http.Request) (*UserContext, error)) {
|
||||||
|
c.authenticateCallback = fn
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) Login(ctx context.Context, req LoginRequest) (*LoginResponse, error) {
|
||||||
|
return c.authenticators[0].Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return c.authenticators[0].LoginWithCookie(ctx, req, w)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) Logout(ctx context.Context, req LogoutRequest) error {
|
||||||
|
return c.authenticators[0].Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (c *ChainAuthenticator) LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error {
|
||||||
|
return c.authenticators[0].LogoutWithCookie(ctx, req, w)
|
||||||
|
}
|
||||||
127
pkg/security/chain_test.go
Normal file
127
pkg/security/chain_test.go
Normal file
@@ -0,0 +1,127 @@
|
|||||||
|
package security
|
||||||
|
|
||||||
|
import (
|
||||||
|
"context"
|
||||||
|
"fmt"
|
||||||
|
"net/http"
|
||||||
|
"net/http/httptest"
|
||||||
|
"testing"
|
||||||
|
)
|
||||||
|
|
||||||
|
// stubAuthenticator is a configurable Authenticator for testing.
|
||||||
|
type stubAuthenticator struct {
|
||||||
|
userCtx *UserContext
|
||||||
|
err error
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) Authenticate(_ *http.Request) (*UserContext, error) {
|
||||||
|
return s.userCtx, s.err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) Login(_ context.Context, _ LoginRequest) (*LoginResponse, error) {
|
||||||
|
if s.err != nil {
|
||||||
|
return nil, s.err
|
||||||
|
}
|
||||||
|
return &LoginResponse{Token: "tok"}, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) LoginWithCookie(ctx context.Context, req LoginRequest, _ http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return s.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) Logout(_ context.Context, _ LogoutRequest) error {
|
||||||
|
return s.err
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) LogoutWithCookie(ctx context.Context, req LogoutRequest, _ http.ResponseWriter) error {
|
||||||
|
return s.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (s *stubAuthenticator) SetAuthenticateCallback(_ func(r *http.Request) (*UserContext, error)) {}
|
||||||
|
|
||||||
|
func TestChainAuthenticator_Authenticate(t *testing.T) {
|
||||||
|
successCtx := &UserContext{UserID: 42, UserName: "alice"}
|
||||||
|
failStub := &stubAuthenticator{err: fmt.Errorf("no token")}
|
||||||
|
okStub := &stubAuthenticator{userCtx: successCtx}
|
||||||
|
|
||||||
|
t.Run("primary succeeds", func(t *testing.T) {
|
||||||
|
chain := NewChainAuthenticator(okStub, failStub)
|
||||||
|
req := httptest.NewRequest("GET", "/", nil)
|
||||||
|
|
||||||
|
uc, err := chain.Authenticate(req)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
if uc.UserID != 42 {
|
||||||
|
t.Errorf("expected UserID 42, got %d", uc.UserID)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("primary fails, secondary succeeds", func(t *testing.T) {
|
||||||
|
chain := NewChainAuthenticator(failStub, okStub)
|
||||||
|
req := httptest.NewRequest("GET", "/", nil)
|
||||||
|
|
||||||
|
uc, err := chain.Authenticate(req)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
if uc.UserID != 42 {
|
||||||
|
t.Errorf("expected UserID 42, got %d", uc.UserID)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("all fail", func(t *testing.T) {
|
||||||
|
chain := NewChainAuthenticator(failStub, failStub)
|
||||||
|
req := httptest.NewRequest("GET", "/", nil)
|
||||||
|
|
||||||
|
_, err := chain.Authenticate(req)
|
||||||
|
if err == nil {
|
||||||
|
t.Fatal("expected error when all authenticators fail")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("three in chain, first two fail", func(t *testing.T) {
|
||||||
|
chain := NewChainAuthenticator(failStub, failStub, okStub)
|
||||||
|
req := httptest.NewRequest("GET", "/", nil)
|
||||||
|
|
||||||
|
uc, err := chain.Authenticate(req)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
if uc.UserName != "alice" {
|
||||||
|
t.Errorf("expected UserName alice, got %s", uc.UserName)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
|
func TestChainAuthenticator_LoginLogout(t *testing.T) {
|
||||||
|
primary := &stubAuthenticator{userCtx: &UserContext{UserID: 1}}
|
||||||
|
secondary := &stubAuthenticator{userCtx: &UserContext{UserID: 2}}
|
||||||
|
chain := NewChainAuthenticator(primary, secondary)
|
||||||
|
ctx := context.Background()
|
||||||
|
|
||||||
|
t.Run("login delegates to primary", func(t *testing.T) {
|
||||||
|
resp, err := chain.Login(ctx, LoginRequest{Username: "u", Password: "p"})
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
if resp.Token != "tok" {
|
||||||
|
t.Errorf("expected token from primary, got %s", resp.Token)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("logout delegates to primary", func(t *testing.T) {
|
||||||
|
if err := chain.Logout(ctx, LogoutRequest{}); err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("login error from primary is returned", func(t *testing.T) {
|
||||||
|
failPrimary := &stubAuthenticator{err: fmt.Errorf("db down")}
|
||||||
|
chain2 := NewChainAuthenticator(failPrimary, secondary)
|
||||||
|
_, err := chain2.Login(ctx, LoginRequest{})
|
||||||
|
if err == nil {
|
||||||
|
t.Fatal("expected error from primary login failure")
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
@@ -43,16 +43,31 @@ func (c *CompositeSecurityProvider) Login(ctx context.Context, req LoginRequest)
|
|||||||
return c.auth.Login(ctx, req)
|
return c.auth.Login(ctx, req)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// LoginWithCookie delegates to the authenticator
|
||||||
|
func (c *CompositeSecurityProvider) LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return c.auth.LoginWithCookie(ctx, req, w)
|
||||||
|
}
|
||||||
|
|
||||||
// Logout delegates to the authenticator
|
// Logout delegates to the authenticator
|
||||||
func (c *CompositeSecurityProvider) Logout(ctx context.Context, req LogoutRequest) error {
|
func (c *CompositeSecurityProvider) Logout(ctx context.Context, req LogoutRequest) error {
|
||||||
return c.auth.Logout(ctx, req)
|
return c.auth.Logout(ctx, req)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// LogoutWithCookie delegates to the authenticator
|
||||||
|
func (c *CompositeSecurityProvider) LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error {
|
||||||
|
return c.auth.LogoutWithCookie(ctx, req, w)
|
||||||
|
}
|
||||||
|
|
||||||
// Authenticate delegates to the authenticator
|
// Authenticate delegates to the authenticator
|
||||||
func (c *CompositeSecurityProvider) Authenticate(r *http.Request) (*UserContext, error) {
|
func (c *CompositeSecurityProvider) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
return c.auth.Authenticate(r)
|
return c.auth.Authenticate(r)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// SetAuthenticateCallback delegates to the authenticator
|
||||||
|
func (c *CompositeSecurityProvider) SetAuthenticateCallback(fn func(r *http.Request) (*UserContext, error)) {
|
||||||
|
c.auth.SetAuthenticateCallback(fn)
|
||||||
|
}
|
||||||
|
|
||||||
// GetColumnSecurity delegates to the column security provider
|
// GetColumnSecurity delegates to the column security provider
|
||||||
func (c *CompositeSecurityProvider) GetColumnSecurity(ctx context.Context, userID int, schema, table string) ([]ColumnSecurity, error) {
|
func (c *CompositeSecurityProvider) GetColumnSecurity(ctx context.Context, userID int, schema, table string) ([]ColumnSecurity, error) {
|
||||||
return c.colSec.GetColumnSecurity(ctx, userID, schema, table)
|
return c.colSec.GetColumnSecurity(ctx, userID, schema, table)
|
||||||
|
|||||||
@@ -23,14 +23,24 @@ func (m *mockAuth) Login(ctx context.Context, req LoginRequest) (*LoginResponse,
|
|||||||
return m.loginResp, m.loginErr
|
return m.loginResp, m.loginErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockAuth) LoginWithCookie(ctx context.Context, req LoginRequest, _ http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return m.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *mockAuth) Logout(ctx context.Context, req LogoutRequest) error {
|
func (m *mockAuth) Logout(ctx context.Context, req LogoutRequest) error {
|
||||||
return m.logoutErr
|
return m.logoutErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockAuth) LogoutWithCookie(ctx context.Context, req LogoutRequest, _ http.ResponseWriter) error {
|
||||||
|
return m.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *mockAuth) Authenticate(r *http.Request) (*UserContext, error) {
|
func (m *mockAuth) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
return m.authUser, m.authErr
|
return m.authUser, m.authErr
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockAuth) SetAuthenticateCallback(_ func(r *http.Request) (*UserContext, error)) {}
|
||||||
|
|
||||||
// Optional interface implementations
|
// Optional interface implementations
|
||||||
func (m *mockAuth) RefreshToken(ctx context.Context, refreshToken string) (*LoginResponse, error) {
|
func (m *mockAuth) RefreshToken(ctx context.Context, refreshToken string) (*LoginResponse, error) {
|
||||||
if !m.supportsRefresh {
|
if !m.supportsRefresh {
|
||||||
|
|||||||
@@ -83,12 +83,26 @@ type Authenticator interface {
|
|||||||
// Login authenticates credentials and returns a token
|
// Login authenticates credentials and returns a token
|
||||||
Login(ctx context.Context, req LoginRequest) (*LoginResponse, error)
|
Login(ctx context.Context, req LoginRequest) (*LoginResponse, error)
|
||||||
|
|
||||||
|
// LoginWithCookie authenticates credentials and, when cookie sessions are enabled,
|
||||||
|
// writes the session cookie to w. Implementations that do not support cookies
|
||||||
|
// should delegate to Login and ignore w.
|
||||||
|
LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error)
|
||||||
|
|
||||||
// Logout invalidates a user's session/token
|
// Logout invalidates a user's session/token
|
||||||
Logout(ctx context.Context, req LogoutRequest) error
|
Logout(ctx context.Context, req LogoutRequest) error
|
||||||
|
|
||||||
|
// LogoutWithCookie invalidates a user's session/token and, when cookie sessions are
|
||||||
|
// enabled, clears the session cookie on w. Implementations that do not support cookies
|
||||||
|
// should delegate to Logout and ignore w.
|
||||||
|
LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error
|
||||||
|
|
||||||
// Authenticate extracts and validates user from HTTP request
|
// Authenticate extracts and validates user from HTTP request
|
||||||
// Returns UserContext or error if authentication fails
|
// Returns UserContext or error if authentication fails
|
||||||
Authenticate(r *http.Request) (*UserContext, error)
|
Authenticate(r *http.Request) (*UserContext, error)
|
||||||
|
|
||||||
|
// SetAuthenticateCallback registers a fallback called when primary authentication fails.
|
||||||
|
// If the callback returns a non-nil UserContext, that result is used instead of the error.
|
||||||
|
SetAuthenticateCallback(fn func(r *http.Request) (*UserContext, error))
|
||||||
}
|
}
|
||||||
|
|
||||||
// Registrable allows providers to support user registration
|
// Registrable allows providers to support user registration
|
||||||
|
|||||||
@@ -17,8 +17,9 @@ import (
|
|||||||
// 2. Authorization: ApiKey <key>
|
// 2. Authorization: ApiKey <key>
|
||||||
// 3. X-API-Key header
|
// 3. X-API-Key header
|
||||||
type KeyStoreAuthenticator struct {
|
type KeyStoreAuthenticator struct {
|
||||||
keyStore KeyStore
|
keyStore KeyStore
|
||||||
keyType KeyType // empty = accept any type
|
keyType KeyType // empty = accept any type
|
||||||
|
authenticateCallback func(r *http.Request) (*UserContext, error)
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewKeyStoreAuthenticator creates a KeyStoreAuthenticator.
|
// NewKeyStoreAuthenticator creates a KeyStoreAuthenticator.
|
||||||
@@ -32,21 +33,42 @@ func (a *KeyStoreAuthenticator) Login(_ context.Context, _ LoginRequest) (*Login
|
|||||||
return nil, fmt.Errorf("keystore authenticator does not support login")
|
return nil, fmt.Errorf("keystore authenticator does not support login")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// LoginWithCookie is not supported for keystore authentication.
|
||||||
|
func (a *KeyStoreAuthenticator) LoginWithCookie(_ context.Context, _ LoginRequest, _ http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return nil, fmt.Errorf("keystore authenticator does not support login")
|
||||||
|
}
|
||||||
|
|
||||||
// Logout is not supported for keystore authentication.
|
// Logout is not supported for keystore authentication.
|
||||||
func (a *KeyStoreAuthenticator) Logout(_ context.Context, _ LogoutRequest) error {
|
func (a *KeyStoreAuthenticator) Logout(_ context.Context, _ LogoutRequest) error {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// LogoutWithCookie is not supported for keystore authentication.
|
||||||
|
func (a *KeyStoreAuthenticator) LogoutWithCookie(_ context.Context, _ LogoutRequest, _ http.ResponseWriter) error {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// SetAuthenticateCallback registers a fallback called when key authentication fails.
|
||||||
|
func (a *KeyStoreAuthenticator) SetAuthenticateCallback(fn func(r *http.Request) (*UserContext, error)) {
|
||||||
|
a.authenticateCallback = fn
|
||||||
|
}
|
||||||
|
|
||||||
// Authenticate extracts an API key from the request and validates it against the KeyStore.
|
// Authenticate extracts an API key from the request and validates it against the KeyStore.
|
||||||
// Returns a UserContext built from the matching UserKey on success.
|
// Returns a UserContext built from the matching UserKey on success.
|
||||||
func (a *KeyStoreAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
func (a *KeyStoreAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
rawKey := extractAPIKey(r)
|
rawKey := extractAPIKey(r)
|
||||||
if rawKey == "" {
|
if rawKey == "" {
|
||||||
|
if a.authenticateCallback != nil {
|
||||||
|
return a.authenticateCallback(r)
|
||||||
|
}
|
||||||
return nil, fmt.Errorf("API key required (Authorization: Bearer/ApiKey <key> or X-API-Key header)")
|
return nil, fmt.Errorf("API key required (Authorization: Bearer/ApiKey <key> or X-API-Key header)")
|
||||||
}
|
}
|
||||||
|
|
||||||
userKey, err := a.keyStore.ValidateKey(r.Context(), rawKey, a.keyType)
|
userKey, err := a.keyStore.ValidateKey(r.Context(), rawKey, a.keyType)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
|
if a.authenticateCallback != nil {
|
||||||
|
return a.authenticateCallback(r)
|
||||||
|
}
|
||||||
return nil, fmt.Errorf("invalid API key: %w", err)
|
return nil, fmt.Errorf("invalid API key: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -22,14 +22,24 @@ func (m *mockSecurityProvider) Login(ctx context.Context, req LoginRequest) (*Lo
|
|||||||
return m.loginResponse, m.loginError
|
return m.loginResponse, m.loginError
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockSecurityProvider) LoginWithCookie(ctx context.Context, req LoginRequest, _ http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return m.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *mockSecurityProvider) Logout(ctx context.Context, req LogoutRequest) error {
|
func (m *mockSecurityProvider) Logout(ctx context.Context, req LogoutRequest) error {
|
||||||
return m.logoutError
|
return m.logoutError
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockSecurityProvider) LogoutWithCookie(ctx context.Context, req LogoutRequest, _ http.ResponseWriter) error {
|
||||||
|
return m.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *mockSecurityProvider) Authenticate(r *http.Request) (*UserContext, error) {
|
func (m *mockSecurityProvider) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
return m.authUser, m.authError
|
return m.authUser, m.authError
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *mockSecurityProvider) SetAuthenticateCallback(_ func(r *http.Request) (*UserContext, error)) {}
|
||||||
|
|
||||||
func (m *mockSecurityProvider) GetColumnSecurity(ctx context.Context, userID int, schema, table string) ([]ColumnSecurity, error) {
|
func (m *mockSecurityProvider) GetColumnSecurity(ctx context.Context, userID int, schema, table string) ([]ColumnSecurity, error) {
|
||||||
return m.columnSecurity, nil
|
return m.columnSecurity, nil
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -30,10 +30,18 @@ func (a *HeaderAuthenticator) Login(ctx context.Context, req LoginRequest) (*Log
|
|||||||
return nil, fmt.Errorf("header authentication does not support login")
|
return nil, fmt.Errorf("header authentication does not support login")
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (a *HeaderAuthenticator) LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return a.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (a *HeaderAuthenticator) Logout(ctx context.Context, req LogoutRequest) error {
|
func (a *HeaderAuthenticator) Logout(ctx context.Context, req LogoutRequest) error {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (a *HeaderAuthenticator) LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error {
|
||||||
|
return a.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (a *HeaderAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
func (a *HeaderAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
userIDStr := r.Header.Get("X-User-ID")
|
userIDStr := r.Header.Get("X-User-ID")
|
||||||
if userIDStr == "" {
|
if userIDStr == "" {
|
||||||
@@ -70,12 +78,19 @@ type DatabaseAuthenticator struct {
|
|||||||
cacheTTL time.Duration
|
cacheTTL time.Duration
|
||||||
sqlNames *SQLNames
|
sqlNames *SQLNames
|
||||||
|
|
||||||
|
// Cookie session support (optional, gated by enableCookieSession)
|
||||||
|
enableCookieSession bool
|
||||||
|
cookieOptions SessionCookieOptions
|
||||||
|
|
||||||
// OAuth2 providers registry (multiple providers supported)
|
// OAuth2 providers registry (multiple providers supported)
|
||||||
oauth2Providers map[string]*OAuth2Provider
|
oauth2Providers map[string]*OAuth2Provider
|
||||||
oauth2ProvidersMutex sync.RWMutex
|
oauth2ProvidersMutex sync.RWMutex
|
||||||
|
|
||||||
// Passkey provider (optional)
|
// Passkey provider (optional)
|
||||||
passkeyProvider PasskeyProvider
|
passkeyProvider PasskeyProvider
|
||||||
|
|
||||||
|
// Optional fallback called when primary authentication fails
|
||||||
|
authenticateCallback func(r *http.Request) (*UserContext, error)
|
||||||
}
|
}
|
||||||
|
|
||||||
// DatabaseAuthenticatorOptions configures the database authenticator
|
// DatabaseAuthenticatorOptions configures the database authenticator
|
||||||
@@ -93,6 +108,18 @@ type DatabaseAuthenticatorOptions struct {
|
|||||||
// DBFactory is called to obtain a fresh *sql.DB when the existing connection is closed.
|
// DBFactory is called to obtain a fresh *sql.DB when the existing connection is closed.
|
||||||
// If nil, reconnection is disabled.
|
// If nil, reconnection is disabled.
|
||||||
DBFactory func() (*sql.DB, error)
|
DBFactory func() (*sql.DB, error)
|
||||||
|
// EnableCookieSession enables cookie-based session management.
|
||||||
|
// When true, Authenticate reads the session token from the cookie named by
|
||||||
|
// CookieOptions.Name (default "session_token") in addition to the Authorization header,
|
||||||
|
// and LoginWithCookie / LogoutWithCookie automatically set / clear the cookie.
|
||||||
|
EnableCookieSession bool
|
||||||
|
// CookieOptions configures the session cookie written by LoginWithCookie.
|
||||||
|
// Only used when EnableCookieSession is true.
|
||||||
|
CookieOptions SessionCookieOptions
|
||||||
|
// AuthenticateCallback is a fallback called when the primary authentication (database
|
||||||
|
// session lookup) fails. If non-nil and the callback returns a non-nil UserContext,
|
||||||
|
// that result is used in place of the failure.
|
||||||
|
AuthenticateCallback func(r *http.Request) (*UserContext, error)
|
||||||
}
|
}
|
||||||
|
|
||||||
func NewDatabaseAuthenticator(db *sql.DB) *DatabaseAuthenticator {
|
func NewDatabaseAuthenticator(db *sql.DB) *DatabaseAuthenticator {
|
||||||
@@ -114,12 +141,15 @@ func NewDatabaseAuthenticatorWithOptions(db *sql.DB, opts DatabaseAuthenticatorO
|
|||||||
sqlNames := MergeSQLNames(DefaultSQLNames(), opts.SQLNames)
|
sqlNames := MergeSQLNames(DefaultSQLNames(), opts.SQLNames)
|
||||||
|
|
||||||
return &DatabaseAuthenticator{
|
return &DatabaseAuthenticator{
|
||||||
db: db,
|
db: db,
|
||||||
dbFactory: opts.DBFactory,
|
dbFactory: opts.DBFactory,
|
||||||
cache: cacheInstance,
|
cache: cacheInstance,
|
||||||
cacheTTL: opts.CacheTTL,
|
cacheTTL: opts.CacheTTL,
|
||||||
sqlNames: sqlNames,
|
sqlNames: sqlNames,
|
||||||
passkeyProvider: opts.PasskeyProvider,
|
passkeyProvider: opts.PasskeyProvider,
|
||||||
|
enableCookieSession: opts.EnableCookieSession,
|
||||||
|
cookieOptions: opts.CookieOptions,
|
||||||
|
authenticateCallback: opts.AuthenticateCallback,
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -159,6 +189,10 @@ func (a *DatabaseAuthenticator) runDBOpWithReconnect(run func(*sql.DB) error) er
|
|||||||
return err
|
return err
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (a *DatabaseAuthenticator) SetAuthenticateCallback(fn func(r *http.Request) (*UserContext, error)) {
|
||||||
|
a.authenticateCallback = fn
|
||||||
|
}
|
||||||
|
|
||||||
func (a *DatabaseAuthenticator) Login(ctx context.Context, req LoginRequest) (*LoginResponse, error) {
|
func (a *DatabaseAuthenticator) Login(ctx context.Context, req LoginRequest) (*LoginResponse, error) {
|
||||||
// Convert LoginRequest to JSON
|
// Convert LoginRequest to JSON
|
||||||
reqJSON, err := json.Marshal(req)
|
reqJSON, err := json.Marshal(req)
|
||||||
@@ -265,6 +299,33 @@ func (a *DatabaseAuthenticator) Logout(ctx context.Context, req LogoutRequest) e
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// LoginWithCookie performs a login and, when EnableCookieSession is true, writes the
|
||||||
|
// session cookie to w using the configured CookieOptions. The LoginResponse is returned
|
||||||
|
// regardless of whether cookie sessions are enabled.
|
||||||
|
func (a *DatabaseAuthenticator) LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
resp, err := a.Login(ctx, req)
|
||||||
|
if err != nil {
|
||||||
|
return nil, err
|
||||||
|
}
|
||||||
|
if a.enableCookieSession {
|
||||||
|
SetSessionCookie(w, resp, a.cookieOptions)
|
||||||
|
}
|
||||||
|
return resp, nil
|
||||||
|
}
|
||||||
|
|
||||||
|
// LogoutWithCookie performs a logout and, when EnableCookieSession is true, clears the
|
||||||
|
// session cookie on w. The logout itself is performed regardless of the cookie flag.
|
||||||
|
func (a *DatabaseAuthenticator) LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error {
|
||||||
|
err := a.Logout(ctx, req)
|
||||||
|
if err != nil {
|
||||||
|
return err
|
||||||
|
}
|
||||||
|
if a.enableCookieSession {
|
||||||
|
ClearSessionCookie(w, a.cookieOptions)
|
||||||
|
}
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
|
||||||
func (a *DatabaseAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
func (a *DatabaseAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
// Extract session token from header or cookie
|
// Extract session token from header or cookie
|
||||||
sessionToken := r.Header.Get("Authorization")
|
sessionToken := r.Header.Get("Authorization")
|
||||||
@@ -272,10 +333,11 @@ func (a *DatabaseAuthenticator) Authenticate(r *http.Request) (*UserContext, err
|
|||||||
var tokens []string
|
var tokens []string
|
||||||
|
|
||||||
if sessionToken == "" {
|
if sessionToken == "" {
|
||||||
// Try cookie
|
if a.enableCookieSession {
|
||||||
if token := GetSessionCookie(r); token != "" {
|
if token := GetSessionCookie(r, a.cookieOptions); token != "" {
|
||||||
tokens = []string{token}
|
tokens = []string{token}
|
||||||
reference = "cookie"
|
reference = "cookie"
|
||||||
|
}
|
||||||
}
|
}
|
||||||
} else {
|
} else {
|
||||||
// Parse Authorization header which may contain multiple comma-separated tokens
|
// Parse Authorization header which may contain multiple comma-separated tokens
|
||||||
@@ -295,6 +357,9 @@ func (a *DatabaseAuthenticator) Authenticate(r *http.Request) (*UserContext, err
|
|||||||
}
|
}
|
||||||
|
|
||||||
if len(tokens) == 0 {
|
if len(tokens) == 0 {
|
||||||
|
if a.authenticateCallback != nil {
|
||||||
|
return a.authenticateCallback(r)
|
||||||
|
}
|
||||||
return nil, fmt.Errorf("session token required")
|
return nil, fmt.Errorf("session token required")
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -357,7 +422,10 @@ func (a *DatabaseAuthenticator) Authenticate(r *http.Request) (*UserContext, err
|
|||||||
return &userCtx, nil
|
return &userCtx, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// All tokens failed
|
// All tokens failed — try callback before returning error
|
||||||
|
if a.authenticateCallback != nil {
|
||||||
|
return a.authenticateCallback(r)
|
||||||
|
}
|
||||||
if lastErr != nil {
|
if lastErr != nil {
|
||||||
return nil, lastErr
|
return nil, lastErr
|
||||||
}
|
}
|
||||||
@@ -583,6 +651,14 @@ func (a *JWTAuthenticator) Logout(ctx context.Context, req LogoutRequest) error
|
|||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (a *JWTAuthenticator) LoginWithCookie(ctx context.Context, req LoginRequest, w http.ResponseWriter) (*LoginResponse, error) {
|
||||||
|
return a.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
|
func (a *JWTAuthenticator) LogoutWithCookie(ctx context.Context, req LogoutRequest, w http.ResponseWriter) error {
|
||||||
|
return a.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (a *JWTAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
func (a *JWTAuthenticator) Authenticate(r *http.Request) (*UserContext, error) {
|
||||||
authHeader := r.Header.Get("Authorization")
|
authHeader := r.Header.Get("Authorization")
|
||||||
if authHeader == "" {
|
if authHeader == "" {
|
||||||
|
|||||||
@@ -511,6 +511,10 @@ func TestDatabaseAuthenticator(t *testing.T) {
|
|||||||
})
|
})
|
||||||
|
|
||||||
t.Run("authenticate with cookie", func(t *testing.T) {
|
t.Run("authenticate with cookie", func(t *testing.T) {
|
||||||
|
cookieAuth := NewDatabaseAuthenticatorWithOptions(db, DatabaseAuthenticatorOptions{
|
||||||
|
EnableCookieSession: true,
|
||||||
|
})
|
||||||
|
|
||||||
req := httptest.NewRequest("GET", "/test", nil)
|
req := httptest.NewRequest("GET", "/test", nil)
|
||||||
req.AddCookie(&http.Cookie{
|
req.AddCookie(&http.Cookie{
|
||||||
Name: "session_token",
|
Name: "session_token",
|
||||||
@@ -524,7 +528,7 @@ func TestDatabaseAuthenticator(t *testing.T) {
|
|||||||
WithArgs("cookie-token-456", "cookie").
|
WithArgs("cookie-token-456", "cookie").
|
||||||
WillReturnRows(rows)
|
WillReturnRows(rows)
|
||||||
|
|
||||||
userCtx, err := auth.Authenticate(req)
|
userCtx, err := cookieAuth.Authenticate(req)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("expected no error, got %v", err)
|
t.Fatalf("expected no error, got %v", err)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -43,14 +43,24 @@ func (m *MockAuthenticator) Login(ctx context.Context, req security.LoginRequest
|
|||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *MockAuthenticator) LoginWithCookie(ctx context.Context, req security.LoginRequest, _ http.ResponseWriter) (*security.LoginResponse, error) {
|
||||||
|
return m.Login(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *MockAuthenticator) Logout(ctx context.Context, req security.LogoutRequest) error {
|
func (m *MockAuthenticator) Logout(ctx context.Context, req security.LogoutRequest) error {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *MockAuthenticator) LogoutWithCookie(ctx context.Context, req security.LogoutRequest, _ http.ResponseWriter) error {
|
||||||
|
return m.Logout(ctx, req)
|
||||||
|
}
|
||||||
|
|
||||||
func (m *MockAuthenticator) Authenticate(r *http.Request) (*security.UserContext, error) {
|
func (m *MockAuthenticator) Authenticate(r *http.Request) (*security.UserContext, error) {
|
||||||
return m.users["testuser"], nil
|
return m.users["testuser"], nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func (m *MockAuthenticator) SetAuthenticateCallback(_ func(r *http.Request) (*security.UserContext, error)) {}
|
||||||
|
|
||||||
func TestTwoFactorAuthenticator_Setup(t *testing.T) {
|
func TestTwoFactorAuthenticator_Setup(t *testing.T) {
|
||||||
baseAuth := NewMockAuthenticator()
|
baseAuth := NewMockAuthenticator()
|
||||||
provider := security.NewMemoryTwoFactorProvider(nil)
|
provider := security.NewMemoryTwoFactorProvider(nil)
|
||||||
|
|||||||
@@ -3,6 +3,7 @@ package websocketspec
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"encoding/json"
|
"encoding/json"
|
||||||
|
"errors"
|
||||||
"fmt"
|
"fmt"
|
||||||
"net/http"
|
"net/http"
|
||||||
"reflect"
|
"reflect"
|
||||||
@@ -17,6 +18,17 @@ import (
|
|||||||
"github.com/bitechdev/ResolveSpec/pkg/reflection"
|
"github.com/bitechdev/ResolveSpec/pkg/reflection"
|
||||||
)
|
)
|
||||||
|
|
||||||
|
// newErrorResponseFromErr creates an error response from a Go error, including the SQL
|
||||||
|
// query in the error info when the error is a database SQLError.
|
||||||
|
func newErrorResponseFromErr(id, code string, err error) *ResponseMessage {
|
||||||
|
resp := NewErrorResponse(id, code, err.Error())
|
||||||
|
var sqlErr *common.SQLError
|
||||||
|
if errors.As(err, &sqlErr) {
|
||||||
|
resp.Error.SQL = sqlErr.SQL
|
||||||
|
}
|
||||||
|
return resp
|
||||||
|
}
|
||||||
|
|
||||||
// Handler handles WebSocket connections and messages
|
// Handler handles WebSocket connections and messages
|
||||||
type Handler struct {
|
type Handler struct {
|
||||||
db common.Database
|
db common.Database
|
||||||
@@ -236,7 +248,7 @@ func (h *Handler) handleRead(conn *Connection, msg *Message, hookCtx *HookContex
|
|||||||
|
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("[WebSocketSpec] Read operation failed: %v", err)
|
logger.Error("[WebSocketSpec] Read operation failed: %v", err)
|
||||||
errResp := NewErrorResponse(msg.ID, "read_error", err.Error())
|
errResp := newErrorResponseFromErr(msg.ID, "read_error", err)
|
||||||
_ = conn.SendJSON(errResp)
|
_ = conn.SendJSON(errResp)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -272,7 +284,7 @@ func (h *Handler) handleCreate(conn *Connection, msg *Message, hookCtx *HookCont
|
|||||||
data, err := h.create(hookCtx)
|
data, err := h.create(hookCtx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("[WebSocketSpec] Create operation failed: %v", err)
|
logger.Error("[WebSocketSpec] Create operation failed: %v", err)
|
||||||
errResp := NewErrorResponse(msg.ID, "create_error", err.Error())
|
errResp := newErrorResponseFromErr(msg.ID, "create_error", err)
|
||||||
_ = conn.SendJSON(errResp)
|
_ = conn.SendJSON(errResp)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -310,7 +322,7 @@ func (h *Handler) handleUpdate(conn *Connection, msg *Message, hookCtx *HookCont
|
|||||||
data, err := h.update(hookCtx)
|
data, err := h.update(hookCtx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("[WebSocketSpec] Update operation failed: %v", err)
|
logger.Error("[WebSocketSpec] Update operation failed: %v", err)
|
||||||
errResp := NewErrorResponse(msg.ID, "update_error", err.Error())
|
errResp := newErrorResponseFromErr(msg.ID, "update_error", err)
|
||||||
_ = conn.SendJSON(errResp)
|
_ = conn.SendJSON(errResp)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
@@ -348,7 +360,7 @@ func (h *Handler) handleDelete(conn *Connection, msg *Message, hookCtx *HookCont
|
|||||||
err := h.delete(hookCtx)
|
err := h.delete(hookCtx)
|
||||||
if err != nil {
|
if err != nil {
|
||||||
logger.Error("[WebSocketSpec] Delete operation failed: %v", err)
|
logger.Error("[WebSocketSpec] Delete operation failed: %v", err)
|
||||||
errResp := NewErrorResponse(msg.ID, "delete_error", err.Error())
|
errResp := newErrorResponseFromErr(msg.ID, "delete_error", err)
|
||||||
_ = conn.SendJSON(errResp)
|
_ = conn.SendJSON(errResp)
|
||||||
return
|
return
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -99,6 +99,9 @@ type ErrorInfo struct {
|
|||||||
|
|
||||||
// Details contains additional error context
|
// Details contains additional error context
|
||||||
Details map[string]interface{} `json:"details,omitempty"`
|
Details map[string]interface{} `json:"details,omitempty"`
|
||||||
|
|
||||||
|
// SQL is the query that caused the error, populated for database errors
|
||||||
|
SQL string `json:"sql,omitempty"`
|
||||||
}
|
}
|
||||||
|
|
||||||
// RequestMessage represents a client request
|
// RequestMessage represents a client request
|
||||||
|
|||||||
Reference in New Issue
Block a user