mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-05-18 17:55:16 +00:00
Compare commits
7 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
52752d9c8b | ||
|
|
baca5ad29e | ||
|
|
53ab22ce02 | ||
|
|
09a3dc92b9 | ||
|
|
6590cd789a | ||
|
|
4244e838b1 | ||
|
|
c42fa11c1a |
@@ -300,6 +300,7 @@ type BunSelectQuery struct {
|
||||
inJoinContext bool // Track if we're in a JOIN relation context
|
||||
joinTableAlias string // Alias to use for JOIN conditions
|
||||
skipAutoDetect bool // Skip auto-detection to prevent circular calls
|
||||
preloadRelationAlias string // Relation alias used in separate-query preloads (e.g. "tprp" for relation "TPRP")
|
||||
customPreloads map[string][]func(common.SelectQuery) common.SelectQuery // Relations to load with custom implementation
|
||||
metricsEnabled bool
|
||||
}
|
||||
@@ -346,12 +347,14 @@ func (b *BunSelectQuery) ColumnExpr(query string, args ...interface{}) common.Se
|
||||
}
|
||||
|
||||
func (b *BunSelectQuery) Where(query string, args ...interface{}) common.SelectQuery {
|
||||
// If we're in a JOIN context, add table prefix to unqualified columns
|
||||
if b.inJoinContext && b.joinTableAlias != "" {
|
||||
query = addTablePrefix(query, b.joinTableAlias)
|
||||
} else if b.preloadRelationAlias != "" && b.tableName != "" {
|
||||
// Separate-query preload: the caller may have written conditions using the
|
||||
// relation name as a prefix (e.g. "TPRP.col"). Bun uses the real table name
|
||||
// as the alias, so rewrite any such references to use tableName instead.
|
||||
query = replaceRelationAlias(query, b.preloadRelationAlias, b.tableName)
|
||||
} else if b.tableAlias != "" && b.tableName != "" {
|
||||
// If we have a table alias defined, check if the query references a different alias
|
||||
// This can happen in preloads where the user expects a certain alias but Bun generates another
|
||||
query = normalizeTableAlias(query, b.tableAlias, b.tableName)
|
||||
}
|
||||
b.query = b.query.Where(query, args...)
|
||||
@@ -487,6 +490,30 @@ func normalizeTableAlias(query, expectedAlias, tableName string) string {
|
||||
return modified
|
||||
}
|
||||
|
||||
// replaceRelationAlias rewrites WHERE conditions written with a relation alias prefix
|
||||
// (e.g. "TPRP.col") to use the real table name that bun uses in separate queries
|
||||
// (e.g. "t_proposalinstance.col"). Only called for separate-query preload wrappers.
|
||||
func replaceRelationAlias(query, relationAlias, tableName string) string {
|
||||
if relationAlias == "" || tableName == "" || query == "" {
|
||||
return query
|
||||
}
|
||||
parts := strings.FieldsFunc(query, func(r rune) bool {
|
||||
return r == ' ' || r == '(' || r == ')' || r == ','
|
||||
})
|
||||
modified := query
|
||||
for _, part := range parts {
|
||||
if dotIndex := strings.Index(part, "."); dotIndex > 0 {
|
||||
prefix := part[:dotIndex]
|
||||
column := part[dotIndex+1:]
|
||||
if strings.EqualFold(prefix, relationAlias) {
|
||||
logger.Debug("Replacing relation alias '%s' with table name '%s' in preload WHERE condition", prefix, tableName)
|
||||
modified = strings.ReplaceAll(modified, part, tableName+"."+column)
|
||||
}
|
||||
}
|
||||
}
|
||||
return modified
|
||||
}
|
||||
|
||||
func isJoinKeyword(word string) bool {
|
||||
switch strings.ToUpper(word) {
|
||||
case "JOIN", "INNER", "LEFT", "RIGHT", "FULL", "OUTER", "CROSS":
|
||||
@@ -676,8 +703,20 @@ func (b *BunSelectQuery) PreloadRelation(relation string, apply ...func(common.S
|
||||
wrapper.tableAlias = provider.TableAlias()
|
||||
logger.Debug("Preload relation '%s' using table alias: %s", relation, wrapper.tableAlias)
|
||||
}
|
||||
|
||||
}
|
||||
|
||||
// Fallback: if the model didn't provide a table name, ask bun directly.
|
||||
if wrapper.tableName == "" {
|
||||
wrapper.schema, wrapper.tableName = parseTableName(sq.GetTableName(), b.driverName)
|
||||
}
|
||||
|
||||
// For separate-query preloads (has-many), bun aliases the related table using
|
||||
// the actual table name, not the relation name. Record the relation alias so
|
||||
// Where() can rewrite conditions like "TPRP.col" to "t_proposalinstance.col".
|
||||
wrapper.preloadRelationAlias = strings.ToLower(relation)
|
||||
logger.Debug("Preload relation '%s' registered alias '%s' for separate-query WHERE rewriting", relation, wrapper.preloadRelationAlias)
|
||||
|
||||
// Start with the interface value (not pointer)
|
||||
current := common.SelectQuery(wrapper)
|
||||
|
||||
|
||||
@@ -125,6 +125,13 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
||||
result.AffectedRows = 1
|
||||
result.Data = regularData
|
||||
|
||||
// Re-select the inserted row so result.Data reflects DB-generated defaults.
|
||||
if row, err := p.processSelect(ctx, tableName, id); err != nil {
|
||||
logger.Warn("Select after insert failed: table=%s, id=%v, error=%v", tableName, id, err)
|
||||
} else if len(row) > 0 {
|
||||
result.Data = row
|
||||
}
|
||||
|
||||
// Process child relations after parent insert (to get parent ID)
|
||||
if err := p.processChildRelations(ctx, "insert", id, relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||
logger.Error("Failed to process child relations after insert: table=%s, parentID=%v, relations=%+v, error=%v", tableName, id, relationFields, err)
|
||||
@@ -146,9 +153,16 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
||||
result.AffectedRows = rows
|
||||
result.Data = regularData
|
||||
|
||||
// Re-select the updated row so result.Data reflects current DB state.
|
||||
if row, err := p.processSelect(ctx, tableName, result.ID); err != nil {
|
||||
logger.Warn("Select after update failed: table=%s, id=%v, error=%v", tableName, result.ID, err)
|
||||
} else if len(row) > 0 {
|
||||
result.Data = row
|
||||
}
|
||||
|
||||
// Process child relations for update
|
||||
if err := p.processChildRelations(ctx, "update", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||
logger.Error("Failed to process child relations after update: table=%s, parentID=%v, relations=%+v, error=%v", tableName, data[pkName], relationFields, err)
|
||||
logger.Error("Failed to process child relations after update: table=%s, parentID=%v, relations=%+v, error=%v", tableName, data[pkName], regularData, err)
|
||||
return nil, fmt.Errorf("failed to process child relations: %w", err)
|
||||
}
|
||||
} else {
|
||||
@@ -160,7 +174,7 @@ func (p *NestedCUDProcessor) ProcessNestedCUD(
|
||||
// Process child relations first (for referential integrity)
|
||||
if err := p.processChildRelations(ctx, "delete", data[pkName], relationFields, result.RelationData, modelType, parentIDs); err != nil {
|
||||
logger.Error("Failed to process child relations before delete: table=%s, id=%v, relations=%+v, error=%v", tableName, data[pkName], relationFields, err)
|
||||
return nil, fmt.Errorf("failed to process child relations before delete: %w", err)
|
||||
return nil, nil
|
||||
}
|
||||
|
||||
rows, err := p.processDelete(ctx, tableName, data[pkName])
|
||||
@@ -234,10 +248,12 @@ func (p *NestedCUDProcessor) injectForeignKeys(data map[string]interface{}, mode
|
||||
return
|
||||
}
|
||||
|
||||
for parentKey, parentID := range parentIDs {
|
||||
dbColName := reflection.GetForeignKeyColumn(modelType, parentKey)
|
||||
pkCol := reflection.GetPrimaryKeyName(reflect.New(modelType).Interface())
|
||||
|
||||
if dbColName == "" {
|
||||
for parentKey, parentID := range parentIDs {
|
||||
dbColNames := reflection.GetForeignKeyColumn(modelType, parentKey)
|
||||
|
||||
if len(dbColNames) == 0 {
|
||||
// No explicit tag found — fall back to naming convention by scanning scalar fields.
|
||||
for i := 0; i < modelType.NumField(); i++ {
|
||||
field := modelType.Field(i)
|
||||
@@ -248,13 +264,16 @@ func (p *NestedCUDProcessor) injectForeignKeys(data map[string]interface{}, mode
|
||||
strings.EqualFold(jsonName, parentKey+"_id") ||
|
||||
strings.EqualFold(jsonName, parentKey+"id") ||
|
||||
strings.EqualFold(field.Name, parentKey+"ID") {
|
||||
dbColName = reflection.GetColumnName(field)
|
||||
dbColNames = []string{reflection.GetColumnName(field)}
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
if dbColName != "" {
|
||||
for _, dbColName := range dbColNames {
|
||||
if pkCol != "" && strings.EqualFold(dbColName, pkCol) {
|
||||
continue
|
||||
}
|
||||
if _, exists := data[dbColName]; !exists {
|
||||
logger.Debug("Injecting foreign key: %s = %v", dbColName, parentID)
|
||||
data[dbColName] = parentID
|
||||
@@ -289,6 +308,20 @@ func (p *NestedCUDProcessor) processInsert(
|
||||
return id, nil
|
||||
}
|
||||
|
||||
// processSelect fetches the row identified by id from tableName into a flat map.
|
||||
// Used to populate result.Data with the actual DB state after insert/update.
|
||||
func (p *NestedCUDProcessor) processSelect(ctx context.Context, tableName string, id interface{}) (map[string]interface{}, error) {
|
||||
pkName := reflection.GetPrimaryKeyName(tableName)
|
||||
var row map[string]interface{}
|
||||
if err := p.db.NewSelect().
|
||||
Table(tableName).
|
||||
Where(fmt.Sprintf("%s = ?", QuoteIdent(pkName)), id).
|
||||
Scan(ctx, &row); err != nil {
|
||||
return nil, fmt.Errorf("select after write failed: %w", err)
|
||||
}
|
||||
return row, nil
|
||||
}
|
||||
|
||||
// processUpdate handles update operation
|
||||
func (p *NestedCUDProcessor) processUpdate(
|
||||
ctx context.Context,
|
||||
|
||||
@@ -973,23 +973,31 @@ func GetRelationType(model interface{}, fieldName string) RelationType {
|
||||
return RelationUnknown
|
||||
}
|
||||
|
||||
// GetForeignKeyColumn returns the DB column name of the foreign key that the
|
||||
// relation field identified by parentKey owns on modelType.
|
||||
// GetForeignKeyColumn returns the DB column names of the foreign key(s) that
|
||||
// relate parentKey to modelType. Composite keys (e.g. bun "join:a=b,join:c=d"
|
||||
// or GORM "foreignKey:ColA,ColB") yield multiple entries. Returns nil when no
|
||||
// tag is found (caller should fall back to convention).
|
||||
//
|
||||
// It checks tags in priority order:
|
||||
// 1. Bun join: tag — e.g. `bun:"rel:belongs-to,join:department_id=id"` → "department_id"
|
||||
// 2. GORM foreignKey: tag — e.g. `gorm:"foreignKey:DepartmentID"` → column of DepartmentID field
|
||||
// 3. Returns "" when no tag is found (caller should fall back to convention)
|
||||
// Two lookup strategies are tried in order:
|
||||
//
|
||||
// parentKey is matched case-insensitively against the field name and JSON tag.
|
||||
func GetForeignKeyColumn(modelType reflect.Type, parentKey string) string {
|
||||
// 1. Relation-field match: find a field whose name/json equals parentKey, then
|
||||
// read its bun join: or GORM foreignKey: tag and return the local columns.
|
||||
// e.g. parentKey="department", field `Department bun:"join:dept_id=id"` → ["dept_id"]
|
||||
//
|
||||
// 2. Join left-side scan: scan every bun join tag in the struct for pairs whose
|
||||
// left side equals parentKey and return the right-side (child FK) columns.
|
||||
// e.g. parentKey="rid_mastertaskitem", field `Children bun:"join:rid_mastertaskitem=rid_parentmastertaskitem"` → ["rid_parentmastertaskitem"]
|
||||
// Strategy 1 is skipped if the matched field is a declared relation (rel:) or
|
||||
// has a GORM tag but carries no explicit FK — callers should use convention.
|
||||
func GetForeignKeyColumn(modelType reflect.Type, parentKey string) []string {
|
||||
for modelType.Kind() == reflect.Ptr || modelType.Kind() == reflect.Slice {
|
||||
modelType = modelType.Elem()
|
||||
}
|
||||
if modelType.Kind() != reflect.Struct {
|
||||
return ""
|
||||
return nil
|
||||
}
|
||||
|
||||
// Strategy 1: match parentKey against a field's name/json tag.
|
||||
for i := 0; i < modelType.NumField(); i++ {
|
||||
field := modelType.Field(i)
|
||||
|
||||
@@ -999,34 +1007,72 @@ func GetForeignKeyColumn(modelType reflect.Type, parentKey string) string {
|
||||
continue
|
||||
}
|
||||
|
||||
// Bun: join:local_col=foreign_col
|
||||
for _, part := range strings.Split(field.Tag.Get("bun"), ",") {
|
||||
bunTag := field.Tag.Get("bun")
|
||||
|
||||
// Bun: join:local_col=foreign_col (one join: part per pair)
|
||||
var bunCols []string
|
||||
for _, part := range strings.Split(bunTag, ",") {
|
||||
part = strings.TrimSpace(part)
|
||||
if strings.HasPrefix(part, "join:") {
|
||||
// join: may contain multiple pairs separated by spaces: "join:a=b join:c=d"
|
||||
// but typically it's a single pair; take the first local column
|
||||
pair := strings.TrimPrefix(part, "join:")
|
||||
if idx := strings.Index(pair, "="); idx > 0 {
|
||||
return pair[:idx]
|
||||
bunCols = append(bunCols, pair[:idx])
|
||||
}
|
||||
}
|
||||
}
|
||||
if len(bunCols) > 0 {
|
||||
return bunCols
|
||||
}
|
||||
|
||||
// GORM: foreignKey:FieldName
|
||||
// GORM: foreignKey:FieldA,FieldB
|
||||
for _, part := range strings.Split(field.Tag.Get("gorm"), ";") {
|
||||
part = strings.TrimSpace(part)
|
||||
if strings.HasPrefix(part, "foreignKey:") {
|
||||
fkFieldName := strings.TrimPrefix(part, "foreignKey:")
|
||||
var cols []string
|
||||
for _, fkFieldName := range strings.Split(strings.TrimPrefix(part, "foreignKey:"), ",") {
|
||||
fkFieldName = strings.TrimSpace(fkFieldName)
|
||||
if fkField, ok := modelType.FieldByName(fkFieldName); ok {
|
||||
return getColumnNameFromField(fkField)
|
||||
cols = append(cols, getColumnNameFromField(fkField))
|
||||
}
|
||||
}
|
||||
if len(cols) > 0 {
|
||||
return cols
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return ""
|
||||
// The field matched by name/json but has no explicit FK tag. If it is a
|
||||
// declared relation field (rel:) or carries a GORM tag, the caller should
|
||||
// use naming convention — don't fall through to strategy 2. Otherwise the
|
||||
// matched field is a plain scalar column; proceed to the join left-side scan.
|
||||
if strings.Contains(bunTag, "rel:") || field.Tag.Get("gorm") != "" {
|
||||
return nil
|
||||
}
|
||||
break
|
||||
}
|
||||
|
||||
return ""
|
||||
// Strategy 2: scan every field's bun join tag for pairs whose left side (the
|
||||
// parent's column) matches parentKey; the right side is the child FK column.
|
||||
// This handles cases where parentKey is a raw column name rather than a
|
||||
// relation field name (e.g. self-referential or has-many relationships).
|
||||
seen := map[string]bool{}
|
||||
var cols []string
|
||||
for i := 0; i < modelType.NumField(); i++ {
|
||||
for _, part := range strings.Split(modelType.Field(i).Tag.Get("bun"), ",") {
|
||||
part = strings.TrimSpace(part)
|
||||
if strings.HasPrefix(part, "join:") {
|
||||
pair := strings.TrimPrefix(part, "join:")
|
||||
if idx := strings.Index(pair, "="); idx > 0 {
|
||||
left, right := pair[:idx], pair[idx+1:]
|
||||
if strings.EqualFold(left, parentKey) && !seen[right] {
|
||||
seen[right] = true
|
||||
cols = append(cols, right)
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
}
|
||||
return cols // nil if empty
|
||||
}
|
||||
|
||||
// GetRelationModel gets the model type for a relation field
|
||||
|
||||
@@ -15,6 +15,13 @@ type bunEmployee struct {
|
||||
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id" json:"department"`
|
||||
}
|
||||
|
||||
// bunCompositeEmployee has a composite bun join: (two join: parts).
|
||||
type bunCompositeEmployee struct {
|
||||
DeptID string `bun:"dept_id" json:"dept_id"`
|
||||
TenantID string `bun:"tenant_id" json:"tenant_id"`
|
||||
Department *fkDept `bun:"rel:belongs-to,join:dept_id=id,join:tenant_id=id" json:"department"`
|
||||
}
|
||||
|
||||
// gormEmployee uses gorm foreignKey: tag (mirrors testmodels.Employee).
|
||||
type gormEmployee struct {
|
||||
DepartmentID string `json:"department_id"`
|
||||
@@ -23,6 +30,24 @@ type gormEmployee struct {
|
||||
Manager *fkDept `gorm:"foreignKey:ManagerID;references:ID" json:"manager"`
|
||||
}
|
||||
|
||||
// gormCompositeEmployee has a composite GORM foreignKey.
|
||||
type gormCompositeEmployee struct {
|
||||
DeptID string `json:"dept_id"`
|
||||
TenantID string `json:"tenant_id"`
|
||||
Department *fkDept `gorm:"foreignKey:DeptID,TenantID" json:"department"`
|
||||
}
|
||||
|
||||
// selfRefItem mimics a self-referential model (like mastertaskitem) where the
|
||||
// parent PK column appears as the left side of a has-many join tag.
|
||||
type selfRefItem struct {
|
||||
RidItem int32 `json:"rid_item" bun:"rid_item,type:integer,pk"`
|
||||
RidParentItem int32 `json:"rid_parentitem" bun:"rid_parentitem,type:integer"`
|
||||
// has-one (single parent pointer)
|
||||
Parent *selfRefItem `json:"Parent,omitempty" bun:"rel:has-one,join:rid_item=rid_parentitem"`
|
||||
// has-many (child collection) — same join, duplicate right-side must be deduped
|
||||
Children []*selfRefItem `json:"Children,omitempty" bun:"rel:has-many,join:rid_item=rid_parentitem"`
|
||||
}
|
||||
|
||||
// conventionEmployee has no explicit FK tag — relies on naming convention.
|
||||
type conventionEmployee struct {
|
||||
DepartmentID string `json:"department_id"`
|
||||
@@ -39,20 +64,26 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
||||
name string
|
||||
modelType reflect.Type
|
||||
parentKey string
|
||||
want string
|
||||
want []string
|
||||
}{
|
||||
// Bun join: tag
|
||||
{
|
||||
name: "bun join tag returns local column",
|
||||
modelType: reflect.TypeOf(bunEmployee{}),
|
||||
parentKey: "department",
|
||||
want: "dept_id",
|
||||
want: []string{"dept_id"},
|
||||
},
|
||||
{
|
||||
name: "bun join tag matched via json tag (case-insensitive)",
|
||||
modelType: reflect.TypeOf(bunEmployee{}),
|
||||
parentKey: "Department",
|
||||
want: "dept_id",
|
||||
want: []string{"dept_id"},
|
||||
},
|
||||
{
|
||||
name: "bun composite join returns all local columns",
|
||||
modelType: reflect.TypeOf(bunCompositeEmployee{}),
|
||||
parentKey: "department",
|
||||
want: []string{"dept_id", "tenant_id"},
|
||||
},
|
||||
|
||||
// GORM foreignKey: tag
|
||||
@@ -60,19 +91,33 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
||||
name: "gorm foreignKey resolves to column name",
|
||||
modelType: reflect.TypeOf(gormEmployee{}),
|
||||
parentKey: "department",
|
||||
want: "department_id",
|
||||
want: []string{"department_id"},
|
||||
},
|
||||
{
|
||||
name: "gorm foreignKey resolves second relation",
|
||||
modelType: reflect.TypeOf(gormEmployee{}),
|
||||
parentKey: "manager",
|
||||
want: "manager_id",
|
||||
want: []string{"manager_id"},
|
||||
},
|
||||
{
|
||||
name: "gorm foreignKey matched case-insensitively",
|
||||
modelType: reflect.TypeOf(gormEmployee{}),
|
||||
parentKey: "Department",
|
||||
want: "department_id",
|
||||
want: []string{"department_id"},
|
||||
},
|
||||
{
|
||||
name: "gorm composite foreignKey returns all columns",
|
||||
modelType: reflect.TypeOf(gormCompositeEmployee{}),
|
||||
parentKey: "department",
|
||||
want: []string{"dept_id", "tenant_id"},
|
||||
},
|
||||
|
||||
// Join left-side scan (parentKey is a raw column name, not a relation field name)
|
||||
{
|
||||
name: "self-referential: parent PK column returns child FK column",
|
||||
modelType: reflect.TypeOf(selfRefItem{}),
|
||||
parentKey: "rid_item",
|
||||
want: []string{"rid_parentitem"},
|
||||
},
|
||||
|
||||
// Pointer and slice unwrapping
|
||||
@@ -80,43 +125,43 @@ func TestGetForeignKeyColumn(t *testing.T) {
|
||||
name: "pointer to struct is unwrapped",
|
||||
modelType: reflect.TypeOf(&gormEmployee{}),
|
||||
parentKey: "department",
|
||||
want: "department_id",
|
||||
want: []string{"department_id"},
|
||||
},
|
||||
{
|
||||
name: "slice of struct is unwrapped",
|
||||
modelType: reflect.TypeOf([]gormEmployee{}),
|
||||
parentKey: "department",
|
||||
want: "department_id",
|
||||
want: []string{"department_id"},
|
||||
},
|
||||
|
||||
// No tag — returns "" so caller can fall back to convention
|
||||
// No tag — returns nil so caller can fall back to convention
|
||||
{
|
||||
name: "relation with no FK tag returns empty string",
|
||||
name: "relation with no FK tag returns nil",
|
||||
modelType: reflect.TypeOf(conventionEmployee{}),
|
||||
parentKey: "department",
|
||||
want: "",
|
||||
want: nil,
|
||||
},
|
||||
|
||||
// Unknown parent key
|
||||
{
|
||||
name: "unknown parent key returns empty string",
|
||||
name: "unknown parent key returns nil",
|
||||
modelType: reflect.TypeOf(gormEmployee{}),
|
||||
parentKey: "nonexistent",
|
||||
want: "",
|
||||
want: nil,
|
||||
},
|
||||
{
|
||||
name: "non-struct type returns empty string",
|
||||
name: "non-struct type returns nil",
|
||||
modelType: reflect.TypeOf(""),
|
||||
parentKey: "department",
|
||||
want: "",
|
||||
want: nil,
|
||||
},
|
||||
}
|
||||
|
||||
for _, tt := range tests {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
got := GetForeignKeyColumn(tt.modelType, tt.parentKey)
|
||||
if got != tt.want {
|
||||
t.Errorf("GetForeignKeyColumn(%v, %q) = %q, want %q", tt.modelType, tt.parentKey, got, tt.want)
|
||||
if !reflect.DeepEqual(got, tt.want) {
|
||||
t.Errorf("GetForeignKeyColumn(%v, %q) = %v, want %v", tt.modelType, tt.parentKey, got, tt.want)
|
||||
}
|
||||
})
|
||||
}
|
||||
|
||||
@@ -9,29 +9,29 @@ import (
|
||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||
)
|
||||
|
||||
// Test that normalizeResultArray returns empty array when no records found without ID
|
||||
// Test that normalizeResultArray returns empty object when no records found (single-record mode)
|
||||
func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
||||
handler := &Handler{}
|
||||
|
||||
tests := []struct {
|
||||
name string
|
||||
input interface{}
|
||||
shouldBeEmptyArr bool
|
||||
shouldBeEmptyObj bool
|
||||
}{
|
||||
{
|
||||
name: "nil should return empty array",
|
||||
name: "nil should return empty object",
|
||||
input: nil,
|
||||
shouldBeEmptyArr: true,
|
||||
shouldBeEmptyObj: true,
|
||||
},
|
||||
{
|
||||
name: "empty slice should return empty array",
|
||||
name: "empty slice should return empty object",
|
||||
input: []*EmptyTestModel{},
|
||||
shouldBeEmptyArr: true,
|
||||
shouldBeEmptyObj: true,
|
||||
},
|
||||
{
|
||||
name: "single element should return the element",
|
||||
input: []*EmptyTestModel{{ID: 1, Name: "test"}},
|
||||
shouldBeEmptyArr: false,
|
||||
shouldBeEmptyObj: false,
|
||||
},
|
||||
{
|
||||
name: "multiple elements should return the slice",
|
||||
@@ -39,7 +39,7 @@ func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
||||
{ID: 1, Name: "test1"},
|
||||
{ID: 2, Name: "test2"},
|
||||
},
|
||||
shouldBeEmptyArr: false,
|
||||
shouldBeEmptyObj: false,
|
||||
},
|
||||
}
|
||||
|
||||
@@ -47,25 +47,25 @@ func TestNormalizeResultArray_EmptyArrayWhenNoID(t *testing.T) {
|
||||
t.Run(tt.name, func(t *testing.T) {
|
||||
result := handler.normalizeResultArray(tt.input)
|
||||
|
||||
// For cases that should return empty array
|
||||
if tt.shouldBeEmptyArr {
|
||||
emptyArr, ok := result.([]interface{})
|
||||
// For cases that should return empty object
|
||||
if tt.shouldBeEmptyObj {
|
||||
emptyObj, ok := result.(map[string]interface{})
|
||||
if !ok {
|
||||
t.Errorf("Expected empty array []interface{}{}, got %T: %v", result, result)
|
||||
t.Errorf("Expected empty object map[string]interface{}{}, got %T: %v", result, result)
|
||||
return
|
||||
}
|
||||
if len(emptyArr) != 0 {
|
||||
t.Errorf("Expected empty array with length 0, got length %d", len(emptyArr))
|
||||
if len(emptyObj) != 0 {
|
||||
t.Errorf("Expected empty object with length 0, got length %d", len(emptyObj))
|
||||
}
|
||||
|
||||
// Verify it serializes to [] and not null
|
||||
// Verify it serializes to {} and not null
|
||||
jsonBytes, err := json.Marshal(result)
|
||||
if err != nil {
|
||||
t.Errorf("Failed to marshal result: %v", err)
|
||||
return
|
||||
}
|
||||
if string(jsonBytes) != "[]" {
|
||||
t.Errorf("Expected JSON '[]', got '%s'", string(jsonBytes))
|
||||
if string(jsonBytes) != "{}" {
|
||||
t.Errorf("Expected JSON '{}', got '%s'", string(jsonBytes))
|
||||
}
|
||||
}
|
||||
})
|
||||
@@ -138,12 +138,12 @@ func TestSendResponseWithOptions_NoDataFoundHeader(t *testing.T) {
|
||||
t.Errorf("Expected X-No-Data-Found header to be 'true', got '%s'", mockWriter.headers["X-No-Data-Found"])
|
||||
}
|
||||
|
||||
// Check status code is 200
|
||||
if mockWriter.statusCode != 200 {
|
||||
t.Errorf("Expected status code 200, got %d", mockWriter.statusCode)
|
||||
// Check status code is 204 when no records found
|
||||
if mockWriter.statusCode != 204 {
|
||||
t.Errorf("Expected status code 204, got %d", mockWriter.statusCode)
|
||||
}
|
||||
|
||||
// Verify the body is an empty array
|
||||
// Verify the body is an empty array (list request, SingleRecordAsObject not set)
|
||||
if mockWriter.body == nil {
|
||||
t.Error("Expected body to be set, got nil")
|
||||
} else {
|
||||
|
||||
@@ -2502,14 +2502,16 @@ func (h *Handler) sendResponseWithOptions(w common.ResponseWriter, data interfac
|
||||
w.SetHeader("X-No-Data-Found", "true")
|
||||
}
|
||||
|
||||
w.WriteHeader(http.StatusOK)
|
||||
|
||||
// Normalize single-record arrays to objects if requested
|
||||
if options != nil && options.SingleRecordAsObject {
|
||||
data = h.normalizeResultArray(data)
|
||||
}
|
||||
|
||||
// Return data as-is without wrapping in common.Response
|
||||
if dataLen == 0 {
|
||||
w.WriteHeader(http.StatusNoContent)
|
||||
} else {
|
||||
w.WriteHeader(http.StatusOK)
|
||||
}
|
||||
|
||||
if err := w.WriteJSON(data); err != nil {
|
||||
logger.Error("Failed to write JSON response: %v", err)
|
||||
@@ -2520,7 +2522,7 @@ func (h *Handler) sendResponseWithOptions(w common.ResponseWriter, data interfac
|
||||
// Returns the single element if data is a slice/array with exactly one element, otherwise returns data unchanged
|
||||
func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
||||
if data == nil {
|
||||
return []interface{}{}
|
||||
return map[string]interface{}{}
|
||||
}
|
||||
|
||||
// Use reflection to check if data is a slice or array
|
||||
@@ -2535,15 +2537,15 @@ func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
||||
// Return the single element
|
||||
return dataValue.Index(0).Interface()
|
||||
} else if dataValue.Len() == 0 {
|
||||
// Keep empty array as empty array, don't convert to empty object
|
||||
return []interface{}{}
|
||||
// Single-record request with no result → empty object
|
||||
return map[string]interface{}{}
|
||||
}
|
||||
}
|
||||
|
||||
if dataValue.Kind() == reflect.String {
|
||||
str := dataValue.String()
|
||||
if str == "" || str == "null" {
|
||||
return []interface{}{}
|
||||
return map[string]interface{}{}
|
||||
}
|
||||
|
||||
}
|
||||
@@ -2552,9 +2554,6 @@ func (h *Handler) normalizeResultArray(data interface{}) interface{} {
|
||||
|
||||
// sendFormattedResponse sends response with formatting options
|
||||
func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{}, metadata *common.Metadata, options ExtendedRequestOptions) {
|
||||
// Normalize single-record arrays to objects if requested
|
||||
httpStatus := http.StatusOK
|
||||
|
||||
// Handle nil data - convert to empty array
|
||||
if data == nil {
|
||||
data = []interface{}{}
|
||||
@@ -2566,8 +2565,10 @@ func (h *Handler) sendFormattedResponse(w common.ResponseWriter, data interface{
|
||||
dataLen := reflection.Len(data)
|
||||
|
||||
// Add X-No-Data-Found header when no records were found
|
||||
httpStatus := http.StatusOK
|
||||
if dataLen == 0 {
|
||||
w.SetHeader("X-No-Data-Found", "true")
|
||||
httpStatus = http.StatusNoContent
|
||||
}
|
||||
|
||||
// Apply normalization after header is set
|
||||
|
||||
Reference in New Issue
Block a user