fix(handler): update default sort retrieval logic

test(types): add test for ResolveSortColumns with descending order
2026-07-30 06:07:38 +00:00 · 2026-07-29 10:23:08 +02:00 · 2026-07-29 10:15:52 +02:00
3 changed files with 14 additions and 2 deletions
@@ -26,6 +26,18 @@ func TestResolveSortColumns(t *testing.T) {
 	}
 }

+func TestResolveSortColumnsDesc(t *testing.T) {
+	sort := []SortOption{
+		{Column: PrimaryKeySortColumn, Direction: "desc"},
+	}
+
+	got := ResolveSortColumns(sort, "id")
+	want := []SortOption{{Column: "id", Direction: "desc"}}
+	if !reflect.DeepEqual(got, want) {
+		t.Errorf("ResolveSortColumns() = %v, want %v", got, want)
+	}
+}
+
 func TestResolveSortColumnsEmptyPK(t *testing.T) {
 	sort := []SortOption{
 		{Column: PrimaryKeySortColumn, Direction: "asc"},
@@ -73,7 +73,7 @@ func (h *Handler) getDefaultSort(schema, name string) []common.SortOption {
 	if h.defaultSort == nil {
 		return nil
 	}
-	if sort, ok := h.defaultSort[defaultSortKey(schema, name)]; ok {
+	if sort := h.defaultSort[defaultSortKey(schema, name)]; len(sort) > 0 {
 		return sort
 	}
 	return h.defaultSort[defaultSortKey("", "")]
@@ -82,7 +82,7 @@ func (h *Handler) getDefaultSort(schema, name string) []common.SortOption {
 	if h.defaultSort == nil {
 		return nil
 	}
-	if sort, ok := h.defaultSort[defaultSortKey(schema, name)]; ok {
+	if sort := h.defaultSort[defaultSortKey(schema, name)]; len(sort) > 0 {
 		return sort
 	}
 	return h.defaultSort[defaultSortKey("", "")]
Author	SHA1	Message	Date
Hein	a172c73ab0	fix(handler): update default sort retrieval logic Tests / Unit Tests (push) Failing after 10s Details Tests / Integration Tests (push) Failing after 13s Details Build , Vet Test, and Lint / Run Vet Tests (1.23.x) (push) Successful in 2m5s Details Build , Vet Test, and Lint / Lint Code (push) Failing after 5m44s Details Build , Vet Test, and Lint / Build (push) Successful in 7m12s Details Build , Vet Test, and Lint / Run Vet Tests (1.24.x) (push) Successful in 8m11s Details	2026-07-29 10:23:08 +02:00
Hein	ef28959c4d	test(types): add test for ResolveSortColumns with descending order	2026-07-29 10:15:52 +02:00