mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-08-28 12:02:35 +00:00
Compare commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
dab4940ace | ||
|
|
c7178e0a2b | ||
|
|
0261f121e8 | ||
|
|
93dc1008ee | ||
|
|
c60565e4e0 | ||
|
|
16cc7d350e |
@@ -1040,3 +1040,21 @@ func BuildInCondition(column string, v interface{}) (query string, args []interf
|
|||||||
}
|
}
|
||||||
return fmt.Sprintf("%s IN (%s)", column, strings.Join(placeholders, ",")), values
|
return fmt.Sprintf("%s IN (%s)", column, strings.Join(placeholders, ",")), values
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// BuildArrayOverlapCondition builds a parameterized condition testing whether an
|
||||||
|
// array column has at least one element in common with the given value(s), using
|
||||||
|
// PostgreSQL's array overlap operator (&&). Unlike a text-cast ILIKE, this performs
|
||||||
|
// real element-wise containment (no substring false positives) and can use a GIN
|
||||||
|
// index on the column. A single value is treated as a one-element array.
|
||||||
|
// Returns ("", nil) if the value is empty.
|
||||||
|
func BuildArrayOverlapCondition(column string, v interface{}) (query string, args []interface{}) {
|
||||||
|
values := FilterValueToSlice(v)
|
||||||
|
if len(values) == 0 {
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
|
placeholders := make([]string, len(values))
|
||||||
|
for i := range values {
|
||||||
|
placeholders[i] = "?"
|
||||||
|
}
|
||||||
|
return fmt.Sprintf("%s && ARRAY[%s]", column, strings.Join(placeholders, ",")), values
|
||||||
|
}
|
||||||
|
|||||||
+147
-89
@@ -542,8 +542,8 @@ func TestSplitByAND(t *testing.T) {
|
|||||||
expected: []string{"col1 between 1 and 5", "col2 between 10 and 20"},
|
expected: []string{"col1 between 1 and 5", "col2 between 10 and 20"},
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "complex OR block with multiple BETWEENs (real-world case)",
|
name: "complex OR block with multiple BETWEENs (real-world case)",
|
||||||
input: "tbl.applicationdate between '2025-08-31' and '1970-01-01'\n or tbl.capturedate between '2025-08-31' and '1970-01-01'\n or tbl.startdate between '2025-08-31' AND '1970-01-01'",
|
input: "tbl.applicationdate between '2025-08-31' and '1970-01-01'\n or tbl.capturedate between '2025-08-31' and '1970-01-01'\n or tbl.startdate between '2025-08-31' AND '1970-01-01'",
|
||||||
expected: []string{"tbl.applicationdate between '2025-08-31' and '1970-01-01'\n or tbl.capturedate between '2025-08-31' and '1970-01-01'\n or tbl.startdate between '2025-08-31' AND '1970-01-01'"},
|
expected: []string{"tbl.applicationdate between '2025-08-31' and '1970-01-01'\n or tbl.capturedate between '2025-08-31' and '1970-01-01'\n or tbl.startdate between '2025-08-31' AND '1970-01-01'"},
|
||||||
},
|
},
|
||||||
// Quote-aware cases: AND inside a string literal must not split.
|
// Quote-aware cases: AND inside a string literal must not split.
|
||||||
@@ -889,93 +889,151 @@ func TestSanitizeWhereClause_PreservesParenthesesWithOR(t *testing.T) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func TestAddTablePrefixToColumns_ComplexConditions(t *testing.T) {
|
func TestAddTablePrefixToColumns_ComplexConditions(t *testing.T) {
|
||||||
tests := []struct {
|
tests := []struct {
|
||||||
name string
|
name string
|
||||||
where string
|
where string
|
||||||
tableName string
|
tableName string
|
||||||
expected string
|
expected string
|
||||||
}{
|
}{
|
||||||
{
|
{
|
||||||
name: "Parentheses with true AND condition - should not prefix true",
|
name: "Parentheses with true AND condition - should not prefix true",
|
||||||
where: "(true AND status = 'active')",
|
where: "(true AND status = 'active')",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "(true AND mastertask.status = 'active')",
|
expected: "(true AND mastertask.status = 'active')",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Parentheses with multiple conditions including true",
|
name: "Parentheses with multiple conditions including true",
|
||||||
where: "(true AND status = 'active' AND id > 5)",
|
where: "(true AND status = 'active' AND id > 5)",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "(true AND mastertask.status = 'active' AND mastertask.id > 5)",
|
expected: "(true AND mastertask.status = 'active' AND mastertask.id > 5)",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Nested parentheses with true",
|
name: "Nested parentheses with true",
|
||||||
where: "((true AND status = 'active'))",
|
where: "((true AND status = 'active'))",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "((true AND mastertask.status = 'active'))",
|
expected: "((true AND mastertask.status = 'active'))",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Mixed: false AND valid conditions",
|
name: "Mixed: false AND valid conditions",
|
||||||
where: "(false AND name = 'test')",
|
where: "(false AND name = 'test')",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "(false AND mastertask.name = 'test')",
|
expected: "(false AND mastertask.name = 'test')",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Mixed: null AND valid conditions",
|
name: "Mixed: null AND valid conditions",
|
||||||
where: "(null AND status = 'active')",
|
where: "(null AND status = 'active')",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "(null AND mastertask.status = 'active')",
|
expected: "(null AND mastertask.status = 'active')",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Multiple true conditions in parentheses",
|
name: "Multiple true conditions in parentheses",
|
||||||
where: "(true AND true AND status = 'active')",
|
where: "(true AND true AND status = 'active')",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "(true AND true AND mastertask.status = 'active')",
|
expected: "(true AND true AND mastertask.status = 'active')",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Simple true without parens - should not prefix",
|
name: "Simple true without parens - should not prefix",
|
||||||
where: "true",
|
where: "true",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "true",
|
expected: "true",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Simple condition without parens - should prefix",
|
name: "Simple condition without parens - should prefix",
|
||||||
where: "status = 'active'",
|
where: "status = 'active'",
|
||||||
tableName: "mastertask",
|
tableName: "mastertask",
|
||||||
expected: "mastertask.status = 'active'",
|
expected: "mastertask.status = 'active'",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Unregistered table with true - should not prefix true",
|
name: "Unregistered table with true - should not prefix true",
|
||||||
where: "(true AND status = 'active')",
|
where: "(true AND status = 'active')",
|
||||||
tableName: "unregistered_table",
|
tableName: "unregistered_table",
|
||||||
expected: "(true AND unregistered_table.status = 'active')",
|
expected: "(true AND unregistered_table.status = 'active')",
|
||||||
},
|
},
|
||||||
// BETWEEN regression: date literals inside BETWEEN must not be prefixed as columns.
|
// BETWEEN regression: date literals inside BETWEEN must not be prefixed as columns.
|
||||||
{
|
{
|
||||||
name: "BETWEEN date range - second date must not be prefixed",
|
name: "BETWEEN date range - second date must not be prefixed",
|
||||||
where: "applicationdate between '2025-08-31' and '1970-01-01'",
|
where: "applicationdate between '2025-08-31' and '1970-01-01'",
|
||||||
tableName: "unregistered_table",
|
tableName: "unregistered_table",
|
||||||
expected: "unregistered_table.applicationdate between '2025-08-31' and '1970-01-01'",
|
expected: "unregistered_table.applicationdate between '2025-08-31' and '1970-01-01'",
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Already-prefixed BETWEEN column - unchanged",
|
name: "Already-prefixed BETWEEN column - unchanged",
|
||||||
where: `"v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01'`,
|
where: `"v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01'`,
|
||||||
tableName: "v_webui_clients",
|
tableName: "v_webui_clients",
|
||||||
expected: `"v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01'`,
|
expected: `"v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01'`,
|
||||||
},
|
},
|
||||||
{
|
{
|
||||||
name: "Complex OR block with multiple BETWEENs - date values must not be prefixed",
|
name: "Complex OR block with multiple BETWEENs - date values must not be prefixed",
|
||||||
where: `("v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01' or "v_webui_clients".clientcapturedate between '2025-08-31' and '1970-01-01' or "v_webui_clients".startdate between '2025-08-31' AND '1970-01-01')`,
|
where: `("v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01' or "v_webui_clients".clientcapturedate between '2025-08-31' and '1970-01-01' or "v_webui_clients".startdate between '2025-08-31' AND '1970-01-01')`,
|
||||||
tableName: "v_webui_clients",
|
tableName: "v_webui_clients",
|
||||||
expected: `("v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01' or "v_webui_clients".clientcapturedate between '2025-08-31' and '1970-01-01' or "v_webui_clients".startdate between '2025-08-31' AND '1970-01-01')`,
|
expected: `("v_webui_clients".applicationdate between '2025-08-31' and '1970-01-01' or "v_webui_clients".clientcapturedate between '2025-08-31' and '1970-01-01' or "v_webui_clients".startdate between '2025-08-31' AND '1970-01-01')`,
|
||||||
},
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
result := AddTablePrefixToColumns(tt.where, tt.tableName)
|
||||||
|
if result != tt.expected {
|
||||||
|
t.Errorf("AddTablePrefixToColumns(%q, %q) = %q; want %q", tt.where, tt.tableName, result, tt.expected)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tt := range tests {
|
func TestBuildArrayOverlapCondition(t *testing.T) {
|
||||||
t.Run(tt.name, func(t *testing.T) {
|
tests := []struct {
|
||||||
result := AddTablePrefixToColumns(tt.where, tt.tableName)
|
name string
|
||||||
if result != tt.expected {
|
column string
|
||||||
t.Errorf("AddTablePrefixToColumns(%q, %q) = %q; want %q", tt.where, tt.tableName, result, tt.expected)
|
value interface{}
|
||||||
}
|
expectedCond string
|
||||||
})
|
expectedArgs int
|
||||||
}
|
}{
|
||||||
|
{
|
||||||
|
name: "single scalar value",
|
||||||
|
column: "tags",
|
||||||
|
value: "urgent",
|
||||||
|
expectedCond: "tags && ARRAY[?]",
|
||||||
|
expectedArgs: 1,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "multiple values",
|
||||||
|
column: "tags",
|
||||||
|
value: []string{"urgent", "billing", "vip"},
|
||||||
|
expectedCond: "tags && ARRAY[?,?,?]",
|
||||||
|
expectedArgs: 3,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "JSON-decoded []interface{} value",
|
||||||
|
column: "tags",
|
||||||
|
value: []interface{}{"urgent", "billing"},
|
||||||
|
expectedCond: "tags && ARRAY[?,?]",
|
||||||
|
expectedArgs: 2,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "nil value",
|
||||||
|
column: "tags",
|
||||||
|
value: nil,
|
||||||
|
expectedCond: "",
|
||||||
|
expectedArgs: 0,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "empty slice value",
|
||||||
|
column: "tags",
|
||||||
|
value: []string{},
|
||||||
|
expectedCond: "",
|
||||||
|
expectedArgs: 0,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, tt := range tests {
|
||||||
|
t.Run(tt.name, func(t *testing.T) {
|
||||||
|
cond, args := BuildArrayOverlapCondition(tt.column, tt.value)
|
||||||
|
if cond != tt.expectedCond {
|
||||||
|
t.Errorf("BuildArrayOverlapCondition(%q, %v) condition = %q; want %q", tt.column, tt.value, cond, tt.expectedCond)
|
||||||
|
}
|
||||||
|
if len(args) != tt.expectedArgs {
|
||||||
|
t.Errorf("BuildArrayOverlapCondition(%q, %v) args = %d; want %d", tt.column, tt.value, len(args), tt.expectedArgs)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -51,7 +51,7 @@ func (h *Handler) ParseParameters(r *http.Request) *RequestParameters {
|
|||||||
FieldFilters: make(map[string]string),
|
FieldFilters: make(map[string]string),
|
||||||
SearchFilters: make(map[string]string),
|
SearchFilters: make(map[string]string),
|
||||||
SearchOps: make(map[string]FilterOperator),
|
SearchOps: make(map[string]FilterOperator),
|
||||||
Limit: 20, // Default limit
|
Limit: 100000, // Default limit
|
||||||
Offset: 0, // Default offset
|
Offset: 0, // Default offset
|
||||||
ResponseFormat: "simple", // Default format
|
ResponseFormat: "simple", // Default format
|
||||||
ComplexAPI: false, // Default to simple API
|
ComplexAPI: false, // Default to simple API
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import (
|
|||||||
"fmt"
|
"fmt"
|
||||||
"reflect"
|
"reflect"
|
||||||
"sync"
|
"sync"
|
||||||
|
"time"
|
||||||
)
|
)
|
||||||
|
|
||||||
// ModelRules defines the permissions and security settings for a model
|
// ModelRules defines the permissions and security settings for a model
|
||||||
@@ -59,12 +60,44 @@ func NewModelRegistry() *DefaultModelRegistry {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// lockRetryAttempts/lockRetryDelay bound how long the try-lock helpers below
|
||||||
|
// will spin before giving up, so a contended registriesMutex can never hang
|
||||||
|
// a caller of GetDefaultRegistry/SetDefaultRegistry.
|
||||||
|
const (
|
||||||
|
lockRetryAttempts = 20
|
||||||
|
lockRetryDelay = 1 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
|
// GetDefaultRegistry returns the current default registry. It uses a
|
||||||
|
// bounded TryRLock instead of a blocking RLock so it can never hang;
|
||||||
|
// if the lock can't be acquired in time it falls back to the last known
|
||||||
|
// value without synchronization.
|
||||||
func GetDefaultRegistry() *DefaultModelRegistry {
|
func GetDefaultRegistry() *DefaultModelRegistry {
|
||||||
|
for i := 0; i < lockRetryAttempts; i++ {
|
||||||
|
if registriesMutex.TryRLock() {
|
||||||
|
defer registriesMutex.RUnlock()
|
||||||
|
return defaultRegistry
|
||||||
|
}
|
||||||
|
time.Sleep(lockRetryDelay)
|
||||||
|
}
|
||||||
return defaultRegistry
|
return defaultRegistry
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// SetDefaultRegistry replaces the default registry. It uses a bounded
|
||||||
|
// TryLock instead of a blocking Lock so it can never hang; if the lock
|
||||||
|
// can't be acquired in time the call is a no-op.
|
||||||
func SetDefaultRegistry(registry *DefaultModelRegistry) {
|
func SetDefaultRegistry(registry *DefaultModelRegistry) {
|
||||||
registriesMutex.Lock()
|
acquired := false
|
||||||
|
for i := 0; i < lockRetryAttempts; i++ {
|
||||||
|
if registriesMutex.TryLock() {
|
||||||
|
acquired = true
|
||||||
|
break
|
||||||
|
}
|
||||||
|
time.Sleep(lockRetryDelay)
|
||||||
|
}
|
||||||
|
if !acquired {
|
||||||
|
return
|
||||||
|
}
|
||||||
defer registriesMutex.Unlock()
|
defer registriesMutex.Unlock()
|
||||||
|
|
||||||
foundAt := -1
|
foundAt := -1
|
||||||
@@ -90,8 +123,34 @@ func AddRegistry(registry *DefaultModelRegistry) {
|
|||||||
registries = append(registries, registry)
|
registries = append(registries, registry)
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// tryLock attempts to acquire the registry's write lock, retrying briefly.
|
||||||
|
// Returns false if it could not be acquired within the bound.
|
||||||
|
func (r *DefaultModelRegistry) tryLock() bool {
|
||||||
|
for i := 0; i < lockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(lockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// tryRLock attempts to acquire the registry's read lock, retrying briefly.
|
||||||
|
// Returns false if it could not be acquired within the bound.
|
||||||
|
func (r *DefaultModelRegistry) tryRLock() bool {
|
||||||
|
for i := 0; i < lockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryRLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(lockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
func (r *DefaultModelRegistry) RegisterModel(name string, model interface{}) error {
|
func (r *DefaultModelRegistry) RegisterModel(name string, model interface{}) error {
|
||||||
r.mutex.Lock()
|
if !r.tryLock() {
|
||||||
|
return fmt.Errorf("failed to register model %s: registry locked", name)
|
||||||
|
}
|
||||||
defer r.mutex.Unlock()
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
if _, exists := r.models[name]; exists {
|
if _, exists := r.models[name]; exists {
|
||||||
@@ -137,7 +196,9 @@ func (r *DefaultModelRegistry) RegisterModel(name string, model interface{}) err
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (r *DefaultModelRegistry) GetModel(name string) (interface{}, error) {
|
func (r *DefaultModelRegistry) GetModel(name string) (interface{}, error) {
|
||||||
r.mutex.RLock()
|
if !r.tryRLock() {
|
||||||
|
return nil, fmt.Errorf("failed to get model %s: registry locked", name)
|
||||||
|
}
|
||||||
defer r.mutex.RUnlock()
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
model, exists := r.models[name]
|
model, exists := r.models[name]
|
||||||
@@ -149,7 +210,9 @@ func (r *DefaultModelRegistry) GetModel(name string) (interface{}, error) {
|
|||||||
}
|
}
|
||||||
|
|
||||||
func (r *DefaultModelRegistry) GetAllModels() map[string]interface{} {
|
func (r *DefaultModelRegistry) GetAllModels() map[string]interface{} {
|
||||||
r.mutex.RLock()
|
if !r.tryRLock() {
|
||||||
|
return make(map[string]interface{})
|
||||||
|
}
|
||||||
defer r.mutex.RUnlock()
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
result := make(map[string]interface{})
|
result := make(map[string]interface{})
|
||||||
@@ -253,14 +316,26 @@ func IterateModels(fn func(name string, model interface{})) {
|
|||||||
// GetModels returns a list of all models from all registries
|
// GetModels returns a list of all models from all registries
|
||||||
// Models are collected in registry order, with duplicates included
|
// Models are collected in registry order, with duplicates included
|
||||||
func GetModels() []interface{} {
|
func GetModels() []interface{} {
|
||||||
registriesMutex.RLock()
|
acquired := false
|
||||||
|
for i := 0; i < lockRetryAttempts; i++ {
|
||||||
|
if registriesMutex.TryRLock() {
|
||||||
|
acquired = true
|
||||||
|
break
|
||||||
|
}
|
||||||
|
time.Sleep(lockRetryDelay)
|
||||||
|
}
|
||||||
|
if !acquired {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
defer registriesMutex.RUnlock()
|
defer registriesMutex.RUnlock()
|
||||||
|
|
||||||
var models []interface{}
|
var models []interface{}
|
||||||
seen := make(map[string]bool)
|
seen := make(map[string]bool)
|
||||||
|
|
||||||
for _, registry := range registries {
|
for _, registry := range registries {
|
||||||
registry.mutex.RLock()
|
if !registry.tryRLock() {
|
||||||
|
continue
|
||||||
|
}
|
||||||
for name, model := range registry.models {
|
for name, model := range registry.models {
|
||||||
// Only add the first occurrence of each model name
|
// Only add the first occurrence of each model name
|
||||||
if !seen[name] {
|
if !seen[name] {
|
||||||
|
|||||||
@@ -17,6 +17,7 @@ package resolvemcp
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"net/http"
|
"net/http"
|
||||||
|
"runtime/debug"
|
||||||
|
|
||||||
"github.com/gorilla/mux"
|
"github.com/gorilla/mux"
|
||||||
"github.com/uptrace/bun"
|
"github.com/uptrace/bun"
|
||||||
@@ -25,6 +26,7 @@ import (
|
|||||||
|
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/database"
|
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/database"
|
||||||
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/modelregistry"
|
"github.com/bitechdev/ResolveSpec/pkg/modelregistry"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -82,11 +84,20 @@ func SetupMuxRoutes(muxRouter *mux.Router, handler *Handler) {
|
|||||||
// - GET {basePath}/sse — SSE connection endpoint
|
// - GET {basePath}/sse — SSE connection endpoint
|
||||||
// - POST {basePath}/message — JSON-RPC message endpoint
|
// - POST {basePath}/message — JSON-RPC message endpoint
|
||||||
func SetupBunRouterRoutes(router *bunrouter.Router, handler *Handler) {
|
func SetupBunRouterRoutes(router *bunrouter.Router, handler *Handler) {
|
||||||
|
defer func() {
|
||||||
|
if rec := recover(); rec != nil {
|
||||||
|
logger.Error("panic in resolvemcp.SetupBunRouterRoutes: %v\n%s", rec, debug.Stack())
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
basePath := handler.config.BasePath
|
basePath := handler.config.BasePath
|
||||||
h := handler.SSEServer()
|
h := handler.SSEServer()
|
||||||
|
|
||||||
router.GET(basePath+"/sse", bunrouter.HTTPHandler(h))
|
router.GET(basePath+"/sse", bunrouter.HTTPHandler(h))
|
||||||
|
logger.Info("Registered resolvemcp bunrouter route GET %s/sse", basePath)
|
||||||
|
|
||||||
router.POST(basePath+"/message", bunrouter.HTTPHandler(h))
|
router.POST(basePath+"/message", bunrouter.HTTPHandler(h))
|
||||||
|
logger.Info("Registered resolvemcp bunrouter route POST %s/message", basePath)
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewSSEServer returns an http.Handler that serves MCP over SSE.
|
// NewSSEServer returns an http.Handler that serves MCP over SSE.
|
||||||
|
|||||||
@@ -57,6 +57,36 @@ func TestBuildFilterCondition(t *testing.T) {
|
|||||||
expectedCondition: "CAST(email AS TEXT) LIKE ?",
|
expectedCondition: "CAST(email AS TEXT) LIKE ?",
|
||||||
expectedArgsCount: 1,
|
expectedArgsCount: 1,
|
||||||
},
|
},
|
||||||
|
{
|
||||||
|
name: "CONTAINS operator with single value",
|
||||||
|
filter: common.FilterOption{
|
||||||
|
Column: "tags",
|
||||||
|
Operator: "contains",
|
||||||
|
Value: "urgent",
|
||||||
|
},
|
||||||
|
expectedCondition: "tags && ARRAY[?]",
|
||||||
|
expectedArgsCount: 1,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "CONTAINS operator with multiple values",
|
||||||
|
filter: common.FilterOption{
|
||||||
|
Column: "tags",
|
||||||
|
Operator: "contains",
|
||||||
|
Value: []string{"urgent", "billing"},
|
||||||
|
},
|
||||||
|
expectedCondition: "tags && ARRAY[?,?]",
|
||||||
|
expectedArgsCount: 2,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: "CONTAINS operator with empty value",
|
||||||
|
filter: common.FilterOption{
|
||||||
|
Column: "tags",
|
||||||
|
Operator: "contains",
|
||||||
|
Value: nil,
|
||||||
|
},
|
||||||
|
expectedCondition: "",
|
||||||
|
expectedArgsCount: 0,
|
||||||
|
},
|
||||||
}
|
}
|
||||||
|
|
||||||
for _, tt := range tests {
|
for _, tt := range tests {
|
||||||
|
|||||||
@@ -1895,6 +1895,11 @@ func (h *Handler) buildFilterCondition(filter common.FilterOption) (conditionStr
|
|||||||
if condition == "" {
|
if condition == "" {
|
||||||
return "", nil
|
return "", nil
|
||||||
}
|
}
|
||||||
|
case "contains":
|
||||||
|
condition, args = common.BuildArrayOverlapCondition(filter.Column, filter.Value)
|
||||||
|
if condition == "" {
|
||||||
|
return "", nil
|
||||||
|
}
|
||||||
default:
|
default:
|
||||||
return "", nil
|
return "", nil
|
||||||
}
|
}
|
||||||
@@ -1939,6 +1944,11 @@ func (h *Handler) applyFilter(query common.SelectQuery, filter common.FilterOpti
|
|||||||
if condition == "" {
|
if condition == "" {
|
||||||
return query
|
return query
|
||||||
}
|
}
|
||||||
|
case "contains":
|
||||||
|
condition, args = common.BuildArrayOverlapCondition(filter.Column, filter.Value)
|
||||||
|
if condition == "" {
|
||||||
|
return query
|
||||||
|
}
|
||||||
default:
|
default:
|
||||||
return query
|
return query
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -3,6 +3,8 @@ package resolvespec
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
@@ -82,6 +84,7 @@ type HookFunc func(*HookContext) error
|
|||||||
// HookRegistry manages all registered hooks
|
// HookRegistry manages all registered hooks
|
||||||
type HookRegistry struct {
|
type HookRegistry struct {
|
||||||
hooks map[HookType][]HookFunc
|
hooks map[HookType][]HookFunc
|
||||||
|
mutex sync.RWMutex
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewHookRegistry creates a new hook registry
|
// NewHookRegistry creates a new hook registry
|
||||||
@@ -91,8 +94,46 @@ func NewHookRegistry() *HookRegistry {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// hookLockRetryAttempts/hookLockRetryDelay bound how long the try-lock
|
||||||
|
// helpers below will spin before giving up, so a contended mutex can
|
||||||
|
// never hang a caller.
|
||||||
|
const (
|
||||||
|
hookLockRetryAttempts = 20
|
||||||
|
hookLockRetryDelay = 1 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
|
// tryLock attempts to acquire the write lock, retrying briefly. Returns
|
||||||
|
// false if it could not be acquired within the bound.
|
||||||
|
func (r *HookRegistry) tryLock() bool {
|
||||||
|
for i := 0; i < hookLockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(hookLockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// tryRLock attempts to acquire the read lock, retrying briefly. Returns
|
||||||
|
// false if it could not be acquired within the bound.
|
||||||
|
func (r *HookRegistry) tryRLock() bool {
|
||||||
|
for i := 0; i < hookLockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryRLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(hookLockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
// Register adds a new hook for the specified hook type
|
// Register adds a new hook for the specified hook type
|
||||||
func (r *HookRegistry) Register(hookType HookType, hook HookFunc) {
|
func (r *HookRegistry) Register(hookType HookType, hook HookFunc) {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to register resolvespec hook for %s: registry locked", hookType)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
if r.hooks == nil {
|
if r.hooks == nil {
|
||||||
r.hooks = make(map[HookType][]HookFunc)
|
r.hooks = make(map[HookType][]HookFunc)
|
||||||
}
|
}
|
||||||
@@ -110,8 +151,13 @@ func (r *HookRegistry) RegisterMultiple(hookTypes []HookType, hook HookFunc) {
|
|||||||
// Execute runs all hooks for the specified type in order
|
// Execute runs all hooks for the specified type in order
|
||||||
// If any hook returns an error, execution stops and the error is returned
|
// If any hook returns an error, execution stops and the error is returned
|
||||||
func (r *HookRegistry) Execute(hookType HookType, ctx *HookContext) error {
|
func (r *HookRegistry) Execute(hookType HookType, ctx *HookContext) error {
|
||||||
hooks, exists := r.hooks[hookType]
|
if !r.tryRLock() {
|
||||||
if !exists || len(hooks) == 0 {
|
return fmt.Errorf("hook execution failed: registry locked")
|
||||||
|
}
|
||||||
|
hooks := append([]HookFunc(nil), r.hooks[hookType]...)
|
||||||
|
r.mutex.RUnlock()
|
||||||
|
|
||||||
|
if len(hooks) == 0 {
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -145,18 +191,35 @@ func (r *HookRegistry) ExecuteBeforeOp(hookType HookType, ctx *HookContext) erro
|
|||||||
|
|
||||||
// Clear removes all hooks for the specified type
|
// Clear removes all hooks for the specified type
|
||||||
func (r *HookRegistry) Clear(hookType HookType) {
|
func (r *HookRegistry) Clear(hookType HookType) {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to clear resolvespec hooks for %s: registry locked", hookType)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
delete(r.hooks, hookType)
|
delete(r.hooks, hookType)
|
||||||
logger.Info("Cleared all resolvespec hooks for %s", hookType)
|
logger.Info("Cleared all resolvespec hooks for %s", hookType)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ClearAll removes all registered hooks
|
// ClearAll removes all registered hooks
|
||||||
func (r *HookRegistry) ClearAll() {
|
func (r *HookRegistry) ClearAll() {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to clear all resolvespec hooks: registry locked")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
r.hooks = make(map[HookType][]HookFunc)
|
r.hooks = make(map[HookType][]HookFunc)
|
||||||
logger.Info("Cleared all resolvespec hooks")
|
logger.Info("Cleared all resolvespec hooks")
|
||||||
}
|
}
|
||||||
|
|
||||||
// Count returns the number of hooks registered for a specific type
|
// Count returns the number of hooks registered for a specific type
|
||||||
func (r *HookRegistry) Count(hookType HookType) int {
|
func (r *HookRegistry) Count(hookType HookType) int {
|
||||||
|
if !r.tryRLock() {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
if hooks, exists := r.hooks[hookType]; exists {
|
if hooks, exists := r.hooks[hookType]; exists {
|
||||||
return len(hooks)
|
return len(hooks)
|
||||||
}
|
}
|
||||||
@@ -170,6 +233,11 @@ func (r *HookRegistry) HasHooks(hookType HookType) bool {
|
|||||||
|
|
||||||
// GetAllHookTypes returns all hook types that have registered hooks
|
// GetAllHookTypes returns all hook types that have registered hooks
|
||||||
func (r *HookRegistry) GetAllHookTypes() []HookType {
|
func (r *HookRegistry) GetAllHookTypes() []HookType {
|
||||||
|
if !r.tryRLock() {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
types := make([]HookType, 0, len(r.hooks))
|
types := make([]HookType, 0, len(r.hooks))
|
||||||
for hookType := range r.hooks {
|
for hookType := range r.hooks {
|
||||||
types = append(types, hookType)
|
types = append(types, hookType)
|
||||||
|
|||||||
+105
-88
@@ -2,6 +2,7 @@ package resolvespec
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"net/http"
|
"net/http"
|
||||||
|
"runtime/debug"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/gorilla/mux"
|
"github.com/gorilla/mux"
|
||||||
@@ -12,6 +13,7 @@ import (
|
|||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/database"
|
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/database"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/router"
|
"github.com/bitechdev/ResolveSpec/pkg/common/adapters/router"
|
||||||
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/modelregistry"
|
"github.com/bitechdev/ResolveSpec/pkg/modelregistry"
|
||||||
)
|
)
|
||||||
|
|
||||||
@@ -244,6 +246,11 @@ func wrapBunRouterHandler(handler bunrouter.HandlerFunc, authMiddleware Middlewa
|
|||||||
// Accepts bunrouter.Router or bunrouter.Group
|
// Accepts bunrouter.Router or bunrouter.Group
|
||||||
// authMiddleware is optional - if provided, routes will be protected with the middleware
|
// authMiddleware is optional - if provided, routes will be protected with the middleware
|
||||||
func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware MiddlewareFunc) {
|
func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware MiddlewareFunc) {
|
||||||
|
defer func() {
|
||||||
|
if rec := recover(); rec != nil {
|
||||||
|
logger.Error("panic in resolvespec.SetupBunRouterRoutes: %v\n%s", rec, debug.Stack())
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
// CORS config
|
// CORS config
|
||||||
corsConfig := common.DefaultCORSConfig()
|
corsConfig := common.DefaultCORSConfig()
|
||||||
@@ -269,112 +276,122 @@ func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware M
|
|||||||
|
|
||||||
// Loop through each registered model and create explicit routes
|
// Loop through each registered model and create explicit routes
|
||||||
for fullName := range allModels {
|
for fullName := range allModels {
|
||||||
// Parse the full name (e.g., "public.users" or just "users")
|
func() {
|
||||||
schema, entity := parseModelName(fullName)
|
defer func() {
|
||||||
|
if rec := recover(); rec != nil {
|
||||||
|
logger.Error("panic registering resolvespec routes for model %s: %v\n%s", fullName, rec, debug.Stack())
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
// Build the route paths
|
// Parse the full name (e.g., "public.users" or just "users")
|
||||||
entityPath := buildRoutePath(schema, entity)
|
schema, entity := parseModelName(fullName)
|
||||||
entityWithIDPath := entityPath + "/:id"
|
|
||||||
|
|
||||||
// Create closure variables to capture current schema and entity
|
// Build the route paths
|
||||||
currentSchema := schema
|
entityPath := buildRoutePath(schema, entity)
|
||||||
currentEntity := entity
|
entityWithIDPath := entityPath + "/:id"
|
||||||
|
|
||||||
// POST route without ID
|
// Create closure variables to capture current schema and entity
|
||||||
postEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
currentSchema := schema
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
currentEntity := entity
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
// POST route without ID
|
||||||
params := map[string]string{
|
postEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
"schema": currentSchema,
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
"entity": currentEntity,
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
r.Handle("POST", entityPath, wrapBunRouterHandler(postEntityHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
// POST route with ID
|
||||||
return nil
|
postEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
}
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
r.Handle("POST", entityPath, wrapBunRouterHandler(postEntityHandler, authMiddleware))
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
// POST route with ID
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
postEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
return nil
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("POST", entityWithIDPath, wrapBunRouterHandler(postEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
// GET route without ID
|
||||||
return nil
|
getEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
}
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
r.Handle("POST", entityWithIDPath, wrapBunRouterHandler(postEntityWithIDHandler, authMiddleware))
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// GET route without ID
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
getEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
return nil
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
}
|
||||||
|
r.Handle("GET", entityPath, wrapBunRouterHandler(getEntityHandler, authMiddleware))
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
// GET route with ID
|
||||||
return nil
|
getEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
}
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
r.Handle("GET", entityPath, wrapBunRouterHandler(getEntityHandler, authMiddleware))
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
// GET route with ID
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
getEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
return nil
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("GET", entityWithIDPath, wrapBunRouterHandler(getEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
// OPTIONS route without ID (returns metadata)
|
||||||
return nil
|
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
||||||
}
|
r.Handle("OPTIONS", entityPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
r.Handle("GET", entityWithIDPath, wrapBunRouterHandler(getEntityWithIDHandler, authMiddleware))
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
optionsCorsConfig := corsConfig
|
||||||
|
optionsCorsConfig.AllowedMethods = []string{"GET", "POST", "OPTIONS"}
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// OPTIONS route without ID (returns metadata)
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
return nil
|
||||||
r.Handle("OPTIONS", entityPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
})
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
optionsCorsConfig := corsConfig
|
|
||||||
optionsCorsConfig.AllowedMethods = []string{"GET", "POST", "OPTIONS"}
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
// OPTIONS route with ID (returns metadata)
|
||||||
return nil
|
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
||||||
})
|
r.Handle("OPTIONS", entityWithIDPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
|
reqAdapter := router.NewHTTPRequest(req.Request)
|
||||||
|
optionsCorsConfig := corsConfig
|
||||||
|
optionsCorsConfig.AllowedMethods = []string{"POST", "OPTIONS"}
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// OPTIONS route with ID (returns metadata)
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
return nil
|
||||||
r.Handle("OPTIONS", entityWithIDPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
})
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewHTTPRequest(req.Request)
|
|
||||||
optionsCorsConfig := corsConfig
|
|
||||||
optionsCorsConfig.AllowedMethods = []string{"POST", "OPTIONS"}
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
logger.Info("Registered resolvespec bunrouter routes for model %s at %s", fullName, entityPath)
|
||||||
return nil
|
}()
|
||||||
})
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -88,7 +88,7 @@ This will match any records where the column contains the search term (case-inse
|
|||||||
Search with specific operators (AND logic).
|
Search with specific operators (AND logic).
|
||||||
|
|
||||||
**Supported Operators:**
|
**Supported Operators:**
|
||||||
- `contains` - Contains substring (case-insensitive)
|
- `contains` - Contains substring (case-insensitive). Implemented as `CAST(col AS TEXT) ILIKE '%value%'` for every column type, including arrays (stringifies the array, then substring-matches). **Not** array containment — no GIN index use, and can false-positive on partial matches within array elements. resolvespec (a different spec package in this repo) defines `contains` differently: real PostgreSQL array-overlap (`&&`). Don't assume the two behave the same.
|
||||||
- `beginswith` / `startswith` - Starts with (case-insensitive)
|
- `beginswith` / `startswith` - Starts with (case-insensitive)
|
||||||
- `endswith` - Ends with (case-insensitive)
|
- `endswith` - Ends with (case-insensitive)
|
||||||
- `equals` / `eq` - Exact match
|
- `equals` / `eq` - Exact match
|
||||||
|
|||||||
@@ -96,6 +96,8 @@ X-Limit: 50
|
|||||||
|
|
||||||
**Available Operators**: `eq`, `neq`, `gt`, `gte`, `lt`, `lte`, `contains`, `startswith`, `endswith`, `between`, `betweeninclusive`, `in`, `empty`, `notempty`
|
**Available Operators**: `eq`, `neq`, `gt`, `gte`, `lt`, `lte`, `contains`, `startswith`, `endswith`, `between`, `betweeninclusive`, `in`, `empty`, `notempty`
|
||||||
|
|
||||||
|
> Note: `contains` here is a text-cast ILIKE substring match (works on any column type, including arrays, by stringifying first) — not array containment. resolvespec's `contains` operator has different semantics (real array overlap). See [HEADERS.md](HEADERS.md) for details.
|
||||||
|
|
||||||
For complete header documentation, see [HEADERS.md](HEADERS.md).
|
For complete header documentation, see [HEADERS.md](HEADERS.md).
|
||||||
|
|
||||||
## Lifecycle Hooks
|
## Lifecycle Hooks
|
||||||
|
|||||||
@@ -3,6 +3,8 @@ package restheadspec
|
|||||||
import (
|
import (
|
||||||
"context"
|
"context"
|
||||||
"fmt"
|
"fmt"
|
||||||
|
"sync"
|
||||||
|
"time"
|
||||||
|
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/common"
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
||||||
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
"github.com/bitechdev/ResolveSpec/pkg/logger"
|
||||||
@@ -89,6 +91,7 @@ type HookFunc func(*HookContext) error
|
|||||||
// HookRegistry manages all registered hooks
|
// HookRegistry manages all registered hooks
|
||||||
type HookRegistry struct {
|
type HookRegistry struct {
|
||||||
hooks map[HookType][]HookFunc
|
hooks map[HookType][]HookFunc
|
||||||
|
mutex sync.RWMutex
|
||||||
}
|
}
|
||||||
|
|
||||||
// NewHookRegistry creates a new hook registry
|
// NewHookRegistry creates a new hook registry
|
||||||
@@ -98,8 +101,46 @@ func NewHookRegistry() *HookRegistry {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// hookLockRetryAttempts/hookLockRetryDelay bound how long the try-lock
|
||||||
|
// helpers below will spin before giving up, so a contended mutex can
|
||||||
|
// never hang a caller.
|
||||||
|
const (
|
||||||
|
hookLockRetryAttempts = 20
|
||||||
|
hookLockRetryDelay = 1 * time.Millisecond
|
||||||
|
)
|
||||||
|
|
||||||
|
// tryLock attempts to acquire the write lock, retrying briefly. Returns
|
||||||
|
// false if it could not be acquired within the bound.
|
||||||
|
func (r *HookRegistry) tryLock() bool {
|
||||||
|
for i := 0; i < hookLockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(hookLockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
|
// tryRLock attempts to acquire the read lock, retrying briefly. Returns
|
||||||
|
// false if it could not be acquired within the bound.
|
||||||
|
func (r *HookRegistry) tryRLock() bool {
|
||||||
|
for i := 0; i < hookLockRetryAttempts; i++ {
|
||||||
|
if r.mutex.TryRLock() {
|
||||||
|
return true
|
||||||
|
}
|
||||||
|
time.Sleep(hookLockRetryDelay)
|
||||||
|
}
|
||||||
|
return false
|
||||||
|
}
|
||||||
|
|
||||||
// Register adds a new hook for the specified hook type
|
// Register adds a new hook for the specified hook type
|
||||||
func (r *HookRegistry) Register(hookType HookType, hook HookFunc) {
|
func (r *HookRegistry) Register(hookType HookType, hook HookFunc) {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to register hook for %s: registry locked", hookType)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
if r.hooks == nil {
|
if r.hooks == nil {
|
||||||
r.hooks = make(map[HookType][]HookFunc)
|
r.hooks = make(map[HookType][]HookFunc)
|
||||||
}
|
}
|
||||||
@@ -117,8 +158,13 @@ func (r *HookRegistry) RegisterMultiple(hookTypes []HookType, hook HookFunc) {
|
|||||||
// Execute runs all hooks for the specified type in order
|
// Execute runs all hooks for the specified type in order
|
||||||
// If any hook returns an error, execution stops and the error is returned
|
// If any hook returns an error, execution stops and the error is returned
|
||||||
func (r *HookRegistry) Execute(hookType HookType, ctx *HookContext) error {
|
func (r *HookRegistry) Execute(hookType HookType, ctx *HookContext) error {
|
||||||
hooks, exists := r.hooks[hookType]
|
if !r.tryRLock() {
|
||||||
if !exists || len(hooks) == 0 {
|
return fmt.Errorf("hook execution failed: registry locked")
|
||||||
|
}
|
||||||
|
hooks := append([]HookFunc(nil), r.hooks[hookType]...)
|
||||||
|
r.mutex.RUnlock()
|
||||||
|
|
||||||
|
if len(hooks) == 0 {
|
||||||
// logger.Debug("No hooks registered for %s", hookType)
|
// logger.Debug("No hooks registered for %s", hookType)
|
||||||
return nil
|
return nil
|
||||||
}
|
}
|
||||||
@@ -154,18 +200,35 @@ func (r *HookRegistry) ExecuteBeforeOp(hookType HookType, ctx *HookContext) erro
|
|||||||
|
|
||||||
// Clear removes all hooks for the specified type
|
// Clear removes all hooks for the specified type
|
||||||
func (r *HookRegistry) Clear(hookType HookType) {
|
func (r *HookRegistry) Clear(hookType HookType) {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to clear hooks for %s: registry locked", hookType)
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
delete(r.hooks, hookType)
|
delete(r.hooks, hookType)
|
||||||
logger.Info("Cleared all hooks for %s", hookType)
|
logger.Info("Cleared all hooks for %s", hookType)
|
||||||
}
|
}
|
||||||
|
|
||||||
// ClearAll removes all registered hooks
|
// ClearAll removes all registered hooks
|
||||||
func (r *HookRegistry) ClearAll() {
|
func (r *HookRegistry) ClearAll() {
|
||||||
|
if !r.tryLock() {
|
||||||
|
logger.Error("Failed to clear all hooks: registry locked")
|
||||||
|
return
|
||||||
|
}
|
||||||
|
defer r.mutex.Unlock()
|
||||||
|
|
||||||
r.hooks = make(map[HookType][]HookFunc)
|
r.hooks = make(map[HookType][]HookFunc)
|
||||||
logger.Info("Cleared all hooks")
|
logger.Info("Cleared all hooks")
|
||||||
}
|
}
|
||||||
|
|
||||||
// Count returns the number of hooks registered for a specific type
|
// Count returns the number of hooks registered for a specific type
|
||||||
func (r *HookRegistry) Count(hookType HookType) int {
|
func (r *HookRegistry) Count(hookType HookType) int {
|
||||||
|
if !r.tryRLock() {
|
||||||
|
return 0
|
||||||
|
}
|
||||||
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
if hooks, exists := r.hooks[hookType]; exists {
|
if hooks, exists := r.hooks[hookType]; exists {
|
||||||
return len(hooks)
|
return len(hooks)
|
||||||
}
|
}
|
||||||
@@ -179,6 +242,11 @@ func (r *HookRegistry) HasHooks(hookType HookType) bool {
|
|||||||
|
|
||||||
// GetAllHookTypes returns all hook types that have registered hooks
|
// GetAllHookTypes returns all hook types that have registered hooks
|
||||||
func (r *HookRegistry) GetAllHookTypes() []HookType {
|
func (r *HookRegistry) GetAllHookTypes() []HookType {
|
||||||
|
if !r.tryRLock() {
|
||||||
|
return nil
|
||||||
|
}
|
||||||
|
defer r.mutex.RUnlock()
|
||||||
|
|
||||||
types := make([]HookType, 0, len(r.hooks))
|
types := make([]HookType, 0, len(r.hooks))
|
||||||
for hookType := range r.hooks {
|
for hookType := range r.hooks {
|
||||||
types = append(types, hookType)
|
types = append(types, hookType)
|
||||||
|
|||||||
+151
-135
@@ -55,6 +55,7 @@ package restheadspec
|
|||||||
|
|
||||||
import (
|
import (
|
||||||
"net/http"
|
"net/http"
|
||||||
|
"runtime/debug"
|
||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"github.com/gorilla/mux"
|
"github.com/gorilla/mux"
|
||||||
@@ -308,6 +309,11 @@ func wrapBunRouterHandler(handler bunrouter.HandlerFunc, authMiddleware Middlewa
|
|||||||
// Accepts bunrouter.Router or bunrouter.Group
|
// Accepts bunrouter.Router or bunrouter.Group
|
||||||
// authMiddleware is optional - if provided, routes will be protected with the middleware
|
// authMiddleware is optional - if provided, routes will be protected with the middleware
|
||||||
func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware MiddlewareFunc) {
|
func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware MiddlewareFunc) {
|
||||||
|
defer func() {
|
||||||
|
if rec := recover(); rec != nil {
|
||||||
|
logger.Error("panic in restheadspec.SetupBunRouterRoutes: %v\n%s", rec, debug.Stack())
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
// CORS config
|
// CORS config
|
||||||
corsConfig := common.DefaultCORSConfig()
|
corsConfig := common.DefaultCORSConfig()
|
||||||
@@ -333,171 +339,181 @@ func SetupBunRouterRoutes(r BunRouterHandler, handler *Handler, authMiddleware M
|
|||||||
|
|
||||||
// Loop through each registered model and create explicit routes
|
// Loop through each registered model and create explicit routes
|
||||||
for fullName := range allModels {
|
for fullName := range allModels {
|
||||||
// Parse the full name (e.g., "public.users" or just "users")
|
func() {
|
||||||
schema, entity := parseModelName(fullName)
|
defer func() {
|
||||||
|
if rec := recover(); rec != nil {
|
||||||
|
logger.Error("panic registering restheadspec routes for model %s: %v\n%s", fullName, rec, debug.Stack())
|
||||||
|
}
|
||||||
|
}()
|
||||||
|
|
||||||
// Build the route paths
|
// Parse the full name (e.g., "public.users" or just "users")
|
||||||
entityPath := buildRoutePath(schema, entity)
|
schema, entity := parseModelName(fullName)
|
||||||
entityWithIDPath := entityPath + "/:id"
|
|
||||||
metadataPath := entityPath + "/metadata"
|
|
||||||
|
|
||||||
// Create closure variables to capture current schema and entity
|
// Build the route paths
|
||||||
currentSchema := schema
|
entityPath := buildRoutePath(schema, entity)
|
||||||
currentEntity := entity
|
entityWithIDPath := entityPath + "/:id"
|
||||||
|
metadataPath := entityPath + "/metadata"
|
||||||
|
|
||||||
// GET and POST for /{schema}/{entity}
|
// Create closure variables to capture current schema and entity
|
||||||
getEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
currentSchema := schema
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
currentEntity := entity
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
// GET and POST for /{schema}/{entity}
|
||||||
params := map[string]string{
|
getEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
"schema": currentSchema,
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
"entity": currentEntity,
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
|
return nil
|
||||||
}
|
}
|
||||||
|
r.Handle("GET", entityPath, wrapBunRouterHandler(getEntityHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
postEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
return nil
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
}
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
r.Handle("GET", entityPath, wrapBunRouterHandler(getEntityHandler, authMiddleware))
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
postEntityHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
return nil
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
}
|
||||||
|
r.Handle("POST", entityPath, wrapBunRouterHandler(postEntityHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
// GET, POST, PUT, PATCH, DELETE for /{schema}/{entity}/:id
|
||||||
return nil
|
getEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
}
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
r.Handle("POST", entityPath, wrapBunRouterHandler(postEntityHandler, authMiddleware))
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
// GET, POST, PUT, PATCH, DELETE for /{schema}/{entity}/:id
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
getEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
return nil
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("GET", entityWithIDPath, wrapBunRouterHandler(getEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
postEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
return nil
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
}
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
r.Handle("GET", entityWithIDPath, wrapBunRouterHandler(getEntityWithIDHandler, authMiddleware))
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
postEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
return nil
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("POST", entityWithIDPath, wrapBunRouterHandler(postEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
putEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
return nil
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
}
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
r.Handle("POST", entityWithIDPath, wrapBunRouterHandler(postEntityWithIDHandler, authMiddleware))
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
putEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
return nil
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("PUT", entityWithIDPath, wrapBunRouterHandler(putEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
patchEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
return nil
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
}
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
r.Handle("PUT", entityWithIDPath, wrapBunRouterHandler(putEntityWithIDHandler, authMiddleware))
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
patchEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
return nil
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("PATCH", entityWithIDPath, wrapBunRouterHandler(patchEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
deleteEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
return nil
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
}
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
r.Handle("PATCH", entityWithIDPath, wrapBunRouterHandler(patchEntityWithIDHandler, authMiddleware))
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
"id": req.Param("id"),
|
||||||
|
}
|
||||||
|
|
||||||
deleteEntityWithIDHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
handler.Handle(respAdapter, reqAdapter, params)
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
return nil
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
"id": req.Param("id"),
|
|
||||||
}
|
}
|
||||||
|
r.Handle("DELETE", entityWithIDPath, wrapBunRouterHandler(deleteEntityWithIDHandler, authMiddleware))
|
||||||
|
|
||||||
handler.Handle(respAdapter, reqAdapter, params)
|
// Metadata endpoint
|
||||||
return nil
|
metadataHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
}
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
r.Handle("DELETE", entityWithIDPath, wrapBunRouterHandler(deleteEntityWithIDHandler, authMiddleware))
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// Metadata endpoint
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
metadataHandler := func(w http.ResponseWriter, req bunrouter.Request) error {
|
return nil
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, corsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
}
|
||||||
|
r.Handle("GET", metadataPath, wrapBunRouterHandler(metadataHandler, authMiddleware))
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
// OPTIONS route without ID (returns metadata)
|
||||||
return nil
|
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
||||||
}
|
r.Handle("OPTIONS", entityPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
r.Handle("GET", metadataPath, wrapBunRouterHandler(metadataHandler, authMiddleware))
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
|
optionsCorsConfig := corsConfig
|
||||||
|
optionsCorsConfig.AllowedMethods = []string{"GET", "POST", "OPTIONS"}
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// OPTIONS route without ID (returns metadata)
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
return nil
|
||||||
r.Handle("OPTIONS", entityPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
})
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
optionsCorsConfig := corsConfig
|
|
||||||
optionsCorsConfig.AllowedMethods = []string{"GET", "POST", "OPTIONS"}
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
// OPTIONS route with ID (returns metadata)
|
||||||
return nil
|
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
||||||
})
|
r.Handle("OPTIONS", entityWithIDPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
||||||
|
respAdapter := router.NewHTTPResponseWriter(w)
|
||||||
|
reqAdapter := router.NewBunRouterRequest(req)
|
||||||
|
optionsCorsConfig := corsConfig
|
||||||
|
optionsCorsConfig.AllowedMethods = []string{"GET", "PUT", "PATCH", "DELETE", "POST", "OPTIONS"}
|
||||||
|
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
||||||
|
params := map[string]string{
|
||||||
|
"schema": currentSchema,
|
||||||
|
"entity": currentEntity,
|
||||||
|
}
|
||||||
|
|
||||||
// OPTIONS route with ID (returns metadata)
|
handler.HandleGet(respAdapter, reqAdapter, params)
|
||||||
// Don't apply auth middleware to OPTIONS - CORS preflight must not require auth
|
return nil
|
||||||
r.Handle("OPTIONS", entityWithIDPath, func(w http.ResponseWriter, req bunrouter.Request) error {
|
})
|
||||||
respAdapter := router.NewHTTPResponseWriter(w)
|
|
||||||
reqAdapter := router.NewBunRouterRequest(req)
|
|
||||||
optionsCorsConfig := corsConfig
|
|
||||||
optionsCorsConfig.AllowedMethods = []string{"GET", "PUT", "PATCH", "DELETE", "POST", "OPTIONS"}
|
|
||||||
common.SetCORSHeaders(respAdapter, reqAdapter, optionsCorsConfig)
|
|
||||||
params := map[string]string{
|
|
||||||
"schema": currentSchema,
|
|
||||||
"entity": currentEntity,
|
|
||||||
}
|
|
||||||
|
|
||||||
handler.HandleGet(respAdapter, reqAdapter, params)
|
logger.Info("Registered restheadspec bunrouter routes for model %s at %s", fullName, entityPath)
|
||||||
return nil
|
}()
|
||||||
})
|
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -551,11 +551,27 @@ func (a *DatabaseAuthenticator) RefreshToken(ctx context.Context, refreshToken s
|
|||||||
return nil, fmt.Errorf("failed to parse user context: %w", err)
|
return nil, fmt.Errorf("failed to parse user context: %w", err)
|
||||||
}
|
}
|
||||||
|
|
||||||
return &LoginResponse{
|
// A resolvespec_refresh_token implementation that issues its own rotating
|
||||||
|
// refresh token (independent of the access/session token) returns it
|
||||||
|
// under claims.refresh_token, since UserContext has no dedicated field
|
||||||
|
// for it. Surface that into LoginResponse.RefreshToken so callers don't
|
||||||
|
// need to reach into User.Claims themselves. claims.expires_in
|
||||||
|
// (seconds) similarly overrides the default access-token ExpiresIn when
|
||||||
|
// the procedure provides a real value. Implementations that don't set
|
||||||
|
// these claims keep today's behavior unchanged (empty RefreshToken,
|
||||||
|
// 24h ExpiresIn default).
|
||||||
|
resp := &LoginResponse{
|
||||||
Token: userCtx.SessionID, // New session token from stored procedure
|
Token: userCtx.SessionID, // New session token from stored procedure
|
||||||
User: &userCtx,
|
User: &userCtx,
|
||||||
ExpiresIn: int64(24 * time.Hour.Seconds()),
|
ExpiresIn: int64(24 * time.Hour.Seconds()),
|
||||||
}, nil
|
}
|
||||||
|
if refreshToken, ok := userCtx.Claims["refresh_token"].(string); ok && refreshToken != "" {
|
||||||
|
resp.RefreshToken = refreshToken
|
||||||
|
}
|
||||||
|
if expiresIn, ok := userCtx.Claims["expires_in"].(float64); ok && expiresIn > 0 {
|
||||||
|
resp.ExpiresIn = int64(expiresIn)
|
||||||
|
}
|
||||||
|
return resp, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
// JWTAuthenticator provides JWT token-based authentication
|
// JWTAuthenticator provides JWT token-based authentication
|
||||||
@@ -912,8 +928,20 @@ func (p *DatabaseRowSecurityProvider) GetRowSecurity(ctx context.Context, userRe
|
|||||||
return RowSecurity{}, ErrDirectModeUnsupported
|
return RowSecurity{}, ErrDirectModeUnsupported
|
||||||
}
|
}
|
||||||
|
|
||||||
var template string
|
// resolvespec_row_security's p_user_id is a scalar integer. GetUserRef() may
|
||||||
var hasBlock bool
|
// hand back the full *UserContext so non-DB providers can inspect claims;
|
||||||
|
// unwrap it here before it reaches the SQL args.
|
||||||
|
switch v := userRef.(type) {
|
||||||
|
case *UserContext:
|
||||||
|
if v != nil {
|
||||||
|
userRef = v.UserID
|
||||||
|
}
|
||||||
|
case UserContext:
|
||||||
|
userRef = v.UserID
|
||||||
|
}
|
||||||
|
|
||||||
|
var template sql.NullString
|
||||||
|
var hasBlock sql.NullBool
|
||||||
|
|
||||||
runQuery := func() error {
|
runQuery := func() error {
|
||||||
query := fmt.Sprintf(`SELECT p_template, p_block FROM %s($1, $2, $3)`, p.sqlNames.RowSecurity)
|
query := fmt.Sprintf(`SELECT p_template, p_block FROM %s($1, $2, $3)`, p.sqlNames.RowSecurity)
|
||||||
@@ -933,8 +961,8 @@ func (p *DatabaseRowSecurityProvider) GetRowSecurity(ctx context.Context, userRe
|
|||||||
Schema: schema,
|
Schema: schema,
|
||||||
Tablename: table,
|
Tablename: table,
|
||||||
UserID: userRef,
|
UserID: userRef,
|
||||||
Template: template,
|
Template: template.String,
|
||||||
HasBlock: hasBlock,
|
HasBlock: hasBlock.Bool,
|
||||||
}, nil
|
}, nil
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -793,6 +793,49 @@ func TestDatabaseAuthenticatorRefreshToken(t *testing.T) {
|
|||||||
t.Errorf("unfulfilled expectations: %v", err)
|
t.Errorf("unfulfilled expectations: %v", err)
|
||||||
}
|
}
|
||||||
})
|
})
|
||||||
|
|
||||||
|
// A resolvespec_refresh_token implementation that rotates its own
|
||||||
|
// independent refresh token (not just reusing the session/access token)
|
||||||
|
// has nowhere else to put the new refresh token and real access-token
|
||||||
|
// expiry than under UserContext.Claims, since UserContext has no
|
||||||
|
// dedicated fields for either. RefreshToken must surface those claims
|
||||||
|
// keys into LoginResponse.RefreshToken/ExpiresIn rather than silently
|
||||||
|
// dropping them (see the "successful token refresh" case above, which
|
||||||
|
// covers an implementation that has no independent refresh token at all
|
||||||
|
// and gets the 24h default instead).
|
||||||
|
t.Run("surfaces rotated refresh token and expiry from claims", func(t *testing.T) {
|
||||||
|
refreshToken := "refresh-token-abc"
|
||||||
|
|
||||||
|
sessionRows := sqlmock.NewRows([]string{"p_success", "p_error", "p_user"}).
|
||||||
|
AddRow(true, nil, `{"user_id":1,"user_name":"testuser"}`)
|
||||||
|
mock.ExpectQuery(`SELECT p_success, p_error, p_user::text FROM resolvespec_session`).
|
||||||
|
WithArgs(refreshToken, "refresh").
|
||||||
|
WillReturnRows(sessionRows)
|
||||||
|
|
||||||
|
refreshRows := sqlmock.NewRows([]string{"p_success", "p_error", "p_user"}).
|
||||||
|
AddRow(true, nil, `{"user_id":1,"user_name":"testuser","session_id":"new-access-789","claims":{"refresh_token":"new-refresh-def","expires_in":900}}`)
|
||||||
|
mock.ExpectQuery(`SELECT p_success, p_error, p_user::text FROM resolvespec_refresh_token`).
|
||||||
|
WithArgs(refreshToken, sqlmock.AnyArg()).
|
||||||
|
WillReturnRows(refreshRows)
|
||||||
|
|
||||||
|
resp, err := auth.RefreshToken(ctx, refreshToken)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("expected no error, got %v", err)
|
||||||
|
}
|
||||||
|
if resp.Token != "new-access-789" {
|
||||||
|
t.Errorf("expected token new-access-789, got %s", resp.Token)
|
||||||
|
}
|
||||||
|
if resp.RefreshToken != "new-refresh-def" {
|
||||||
|
t.Errorf("expected rotated refresh token new-refresh-def, got %q", resp.RefreshToken)
|
||||||
|
}
|
||||||
|
if resp.ExpiresIn != 900 {
|
||||||
|
t.Errorf("expected ExpiresIn 900 from claims, got %d", resp.ExpiresIn)
|
||||||
|
}
|
||||||
|
|
||||||
|
if err := mock.ExpectationsWereMet(); err != nil {
|
||||||
|
t.Errorf("unfulfilled expectations: %v", err)
|
||||||
|
}
|
||||||
|
})
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestDatabaseAuthenticatorReconnectsClosedDBPaths(t *testing.T) {
|
func TestDatabaseAuthenticatorReconnectsClosedDBPaths(t *testing.T) {
|
||||||
|
|||||||
Reference in New Issue
Block a user