mirror of
https://github.com/bitechdev/ResolveSpec.git
synced 2026-09-30 12:01:59 +00:00
Implements the fixes from audit/pkg/dbmanager.audit.md. - Stop closing the shared *sql.DB to recover from errors. Adapter factories and the health checker no longer call Reconnect; Reconnect is atomic and operator-only. - Postgres uses a custom driver.Connector: Reconnect retires pooled connections by generation without closing the pool, so held Bun/GORM handles keep working. Verified against a live server restart. - Add TCP keepalive, TCP_USER_TIMEOUT, a bounded reuse ping and statement_timeout as a runtime parameter; drop the 2 min timeout floor. - Health check pings without holding the connection lock. - Listener: single goroutine pair, bounded Close without UNLISTEN, and serialised use of the pgx connection (fixes conn busy and a close race). - Fix Connect/Close/Connect/Close panic, idempotent Connect, dial outside the manager lock, clean up on partial failure. - SQLite: pin :memory: to one connection, pragmas via DSN. - Escape credentials in Postgres/MSSQL/Mongo DSNs; sslmode defaults to prefer. Wire retry settings, publish metrics, fix logger calls. - NewConnectionFromDB: Close is a no-op with a warning (caller owns the pool); Reconnect only pings. - Document correct usage in the README; mark the audit with what was done. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
282 lines
7.3 KiB
Go
282 lines
7.3 KiB
Go
package dbmanager
|
|
|
|
import (
|
|
"context"
|
|
"database/sql"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/uptrace/bun"
|
|
"go.mongodb.org/mongo-driver/mongo"
|
|
"gorm.io/gorm"
|
|
|
|
"github.com/bitechdev/ResolveSpec/pkg/common"
|
|
|
|
_ "github.com/mattn/go-sqlite3"
|
|
)
|
|
|
|
type healthCheckStubConnection struct {
|
|
healthErr error
|
|
reconnectCalls int
|
|
}
|
|
|
|
func (c *healthCheckStubConnection) Name() string { return "stub" }
|
|
func (c *healthCheckStubConnection) Type() DatabaseType { return DatabaseTypePostgreSQL }
|
|
func (c *healthCheckStubConnection) Bun() (*bun.DB, error) { return nil, fmt.Errorf("not implemented") }
|
|
func (c *healthCheckStubConnection) GORM() (*gorm.DB, error) {
|
|
return nil, fmt.Errorf("not implemented")
|
|
}
|
|
func (c *healthCheckStubConnection) Native() (*sql.DB, error) {
|
|
return nil, fmt.Errorf("not implemented")
|
|
}
|
|
func (c *healthCheckStubConnection) DB() (*sql.DB, error) { return nil, fmt.Errorf("not implemented") }
|
|
func (c *healthCheckStubConnection) Database() (common.Database, error) {
|
|
return nil, fmt.Errorf("not implemented")
|
|
}
|
|
func (c *healthCheckStubConnection) MongoDB() (*mongo.Client, error) {
|
|
return nil, fmt.Errorf("not implemented")
|
|
}
|
|
func (c *healthCheckStubConnection) Connect(ctx context.Context) error { return nil }
|
|
func (c *healthCheckStubConnection) Close() error { return nil }
|
|
func (c *healthCheckStubConnection) HealthCheck(ctx context.Context) error { return c.healthErr }
|
|
func (c *healthCheckStubConnection) Reconnect(ctx context.Context) error {
|
|
c.reconnectCalls++
|
|
return nil
|
|
}
|
|
func (c *healthCheckStubConnection) Stats() *ConnectionStats { return &ConnectionStats{} }
|
|
|
|
func TestBackgroundHealthChecker(t *testing.T) {
|
|
// Create a SQLite in-memory database
|
|
db, err := sql.Open("sqlite3", ":memory:")
|
|
if err != nil {
|
|
t.Fatalf("Failed to open database: %v", err)
|
|
}
|
|
defer db.Close()
|
|
|
|
// Create manager config with a short health check interval for testing
|
|
cfg := ManagerConfig{
|
|
DefaultConnection: "test",
|
|
Connections: map[string]ConnectionConfig{
|
|
"test": {
|
|
Name: "test",
|
|
Type: DatabaseTypeSQLite,
|
|
FilePath: ":memory:",
|
|
},
|
|
},
|
|
HealthCheckInterval: 1 * time.Second, // Short interval for testing
|
|
EnableAutoReconnect: true,
|
|
}
|
|
|
|
// Create manager
|
|
mgr, err := NewManager(cfg)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create manager: %v", err)
|
|
}
|
|
|
|
// Connect - this should start the background health checker
|
|
ctx := context.Background()
|
|
err = mgr.Connect(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Failed to connect: %v", err)
|
|
}
|
|
defer mgr.Close()
|
|
|
|
// Get the connection to verify it's healthy
|
|
conn, err := mgr.Get("test")
|
|
if err != nil {
|
|
t.Fatalf("Failed to get connection: %v", err)
|
|
}
|
|
|
|
// Verify initial health check
|
|
err = conn.HealthCheck(ctx)
|
|
if err != nil {
|
|
t.Errorf("Initial health check failed: %v", err)
|
|
}
|
|
|
|
// Wait for a few health check cycles
|
|
time.Sleep(3 * time.Second)
|
|
|
|
// Get stats to verify the connection is still healthy
|
|
stats := conn.Stats()
|
|
if stats == nil {
|
|
t.Fatal("Expected stats to be returned")
|
|
}
|
|
|
|
if !stats.Connected {
|
|
t.Error("Expected connection to still be connected")
|
|
}
|
|
|
|
if stats.HealthCheckStatus == "" {
|
|
t.Error("Expected health check status to be set")
|
|
}
|
|
|
|
// Verify the manager has started the health checker
|
|
if cm, ok := mgr.(*connectionManager); ok {
|
|
if cm.healthTicker == nil {
|
|
t.Error("Expected health ticker to be running")
|
|
}
|
|
}
|
|
}
|
|
|
|
func TestDefaultHealthCheckInterval(t *testing.T) {
|
|
// Verify the default health check interval is 15 seconds
|
|
defaults := DefaultManagerConfig()
|
|
|
|
expectedInterval := 15 * time.Second
|
|
if defaults.HealthCheckInterval != expectedInterval {
|
|
t.Errorf("Expected default health check interval to be %v, got %v",
|
|
expectedInterval, defaults.HealthCheckInterval)
|
|
}
|
|
}
|
|
|
|
func TestApplyDefaultsHealthCheckInterval(t *testing.T) {
|
|
cfg := ManagerConfig{}
|
|
cfg.ApplyDefaults()
|
|
if cfg.HealthCheckInterval != 15*time.Second {
|
|
t.Errorf("Expected health check interval to be 15s, got %v", cfg.HealthCheckInterval)
|
|
}
|
|
|
|
// A negative interval disables the background checker and is preserved.
|
|
cfg = ManagerConfig{HealthCheckInterval: -1}
|
|
cfg.ApplyDefaults()
|
|
if cfg.HealthCheckInterval >= 0 {
|
|
t.Errorf("Expected negative interval to be preserved, got %v", cfg.HealthCheckInterval)
|
|
}
|
|
}
|
|
|
|
func TestManagerHealthCheck(t *testing.T) {
|
|
// Create a SQLite in-memory database
|
|
db, err := sql.Open("sqlite3", ":memory:")
|
|
if err != nil {
|
|
t.Fatalf("Failed to open database: %v", err)
|
|
}
|
|
defer db.Close()
|
|
|
|
// Create manager config
|
|
cfg := ManagerConfig{
|
|
DefaultConnection: "test",
|
|
Connections: map[string]ConnectionConfig{
|
|
"test": {
|
|
Name: "test",
|
|
Type: DatabaseTypeSQLite,
|
|
FilePath: ":memory:",
|
|
},
|
|
},
|
|
HealthCheckInterval: 15 * time.Second,
|
|
EnableAutoReconnect: true,
|
|
}
|
|
|
|
// Create and connect manager
|
|
mgr, err := NewManager(cfg)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create manager: %v", err)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
err = mgr.Connect(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Failed to connect: %v", err)
|
|
}
|
|
defer mgr.Close()
|
|
|
|
// Perform health check on all connections
|
|
err = mgr.HealthCheck(ctx)
|
|
if err != nil {
|
|
t.Errorf("Health check failed: %v", err)
|
|
}
|
|
|
|
// Get stats
|
|
stats := mgr.Stats()
|
|
if stats == nil {
|
|
t.Fatal("Expected stats to be returned")
|
|
}
|
|
|
|
if stats.TotalConnections != 1 {
|
|
t.Errorf("Expected 1 total connection, got %d", stats.TotalConnections)
|
|
}
|
|
|
|
if stats.HealthyCount != 1 {
|
|
t.Errorf("Expected 1 healthy connection, got %d", stats.HealthyCount)
|
|
}
|
|
|
|
if stats.UnhealthyCount != 0 {
|
|
t.Errorf("Expected 0 unhealthy connections, got %d", stats.UnhealthyCount)
|
|
}
|
|
}
|
|
|
|
func TestManagerStatsAfterClose(t *testing.T) {
|
|
cfg := ManagerConfig{
|
|
DefaultConnection: "test",
|
|
Connections: map[string]ConnectionConfig{
|
|
"test": {
|
|
Name: "test",
|
|
Type: DatabaseTypeSQLite,
|
|
FilePath: ":memory:",
|
|
},
|
|
},
|
|
HealthCheckInterval: 15 * time.Second,
|
|
}
|
|
|
|
mgr, err := NewManager(cfg)
|
|
if err != nil {
|
|
t.Fatalf("Failed to create manager: %v", err)
|
|
}
|
|
|
|
ctx := context.Background()
|
|
err = mgr.Connect(ctx)
|
|
if err != nil {
|
|
t.Fatalf("Failed to connect: %v", err)
|
|
}
|
|
|
|
// Close the manager
|
|
err = mgr.Close()
|
|
if err != nil {
|
|
t.Errorf("Failed to close manager: %v", err)
|
|
}
|
|
|
|
// Stats should show no connections
|
|
stats := mgr.Stats()
|
|
if stats.TotalConnections != 0 {
|
|
t.Errorf("Expected 0 total connections after close, got %d", stats.TotalConnections)
|
|
}
|
|
}
|
|
|
|
func TestPerformHealthCheckSkipsReconnectForTransientFailures(t *testing.T) {
|
|
conn := &healthCheckStubConnection{
|
|
healthErr: fmt.Errorf("connection 'primary' health check: dial tcp 127.0.0.1:5432: connect: connection refused"),
|
|
}
|
|
|
|
mgr := &connectionManager{
|
|
connections: map[string]Connection{"primary": conn},
|
|
config: ManagerConfig{
|
|
EnableAutoReconnect: true,
|
|
},
|
|
}
|
|
|
|
mgr.performHealthCheck()
|
|
|
|
if conn.reconnectCalls != 0 {
|
|
t.Fatalf("expected no reconnect attempts for transient health failure, got %d", conn.reconnectCalls)
|
|
}
|
|
}
|
|
|
|
func TestPerformHealthCheckNeverReconnects(t *testing.T) {
|
|
conn := &healthCheckStubConnection{
|
|
healthErr: NewConnectionError("primary", "health check", fmt.Errorf("sql: database is closed")),
|
|
}
|
|
|
|
mgr := &connectionManager{
|
|
connections: map[string]Connection{"primary": conn},
|
|
config: ManagerConfig{
|
|
EnableAutoReconnect: true,
|
|
},
|
|
}
|
|
|
|
mgr.performHealthCheck()
|
|
|
|
if conn.reconnectCalls != 0 {
|
|
t.Fatalf("health check must not close the shared pool via Reconnect, got %d", conn.reconnectCalls)
|
|
}
|
|
}
|