wdevs/amcs
5
0
Fork 0
Code Issues 5 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

feat(observability): add MCP tool name logging in access log
Some checks failed
CI / build-and-test (push) Failing after -32m45s
Details

Browse Source 
* Include tool name from request in access log entries
* Update user agent header in HTTP requests
* Add tests for MCP tool name logging
This commit is contained in:
Warky
2026-04-21 22:35:42 +02:00
parent 9a9fa4f384
commit 512b16f8fe
6 changed files with 111 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
internal/requestip/requestip.go
View File

@@ -11,10 +11,9 @@ import (
//
// Header precedence:
// 1) X-Real-IP
// 2) X-Forwarded-Host
// 3) X-Forwarded-For (first value)
// 4) Forwarded (for=...)
// 5) RemoteAddr (host part)
// 2) X-Forwarded-For (first value)
// 3) Forwarded (for=...)
// 4) RemoteAddr (host part)
func FromRequest(r *http.Request) string {
if r == nil {
return ""
@@ -23,9 +22,6 @@ func FromRequest(r *http.Request) string {
if v := firstAddressToken(r.Header.Get("X-Real-IP")); v != "" {
return stripPort(v)
}
if v := firstAddressToken(r.Header.Get("X-Forwarded-Host")); v != "" {
return stripPort(v)
}
if v := firstAddressToken(r.Header.Get("X-Forwarded-For")); v != "" {
return stripPort(v)
}

12
internal/requestip/requestip_test.go
View File

@@ -9,7 +9,7 @@ import (
func TestFromRequestPrefersXRealIP(t *testing.T) {
req := httptest.NewRequest(http.MethodGet, "/", nil)
req.RemoteAddr = "10.0.0.10:5555"
req.Header.Set("X-Forwarded-Host", "proxy.example.com")
req.Header.Set("X-Forwarded-For", "198.51.100.1")
req.Header.Set("X-Real-IP", "203.0.113.10")
if got := FromRequest(req); got != "203.0.113.10" {
@@ -17,16 +17,6 @@ func TestFromRequestPrefersXRealIP(t *testing.T) {
}
}
func TestFromRequestUsesXForwardedHostWhenRealIPMissing(t *testing.T) {
req := httptest.NewRequest(http.MethodGet, "/", nil)
req.RemoteAddr = "10.0.0.10:5555"
req.Header.Set("X-Forwarded-Host", "203.0.113.22")
if got := FromRequest(req); got != "203.0.113.22" {
t.Fatalf("FromRequest() = %q, want %q", got, "203.0.113.22")
}
}
func TestFromRequestUsesXForwardedForFirstValue(t *testing.T) {
req := httptest.NewRequest(http.MethodGet, "/", nil)
req.RemoteAddr = "10.0.0.10:5555"