feat(metadata): add stripThinkingBlocks function and related tests

2026-03-27 00:05:41 +02:00
parent a5c7b90f49
commit 6af02a2ba1
2 changed files with 114 additions and 0 deletions
--- a/internal/ai/compat/client_test.go
+++ b/internal/ai/compat/client_test.go
@@ -54,6 +54,95 @@ func TestEmbedRetriesTransientFailures(t *testing.T) {
 	}
 }

+func TestExtractMetadataStripsThinkingBlocks(t *testing.T) {
+	cases := []struct {
+		name    string
+		content string
+	}{
+		{
+			name:    "think tag with braces inside",
+			content: "<think>\nLet me map {this} to the schema carefully.\n</think>\n{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"idea\",\"source\":\"\"}",
+		},
+		{
+			name:    "thinking tag",
+			content: "<thinking>reasoning {here}</thinking>{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"idea\",\"source\":\"\"}",
+		},
+	}
+
+	for _, tc := range cases {
+		t.Run(tc.name, func(t *testing.T) {
+			content := tc.content
+			server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+				_ = json.NewEncoder(w).Encode(map[string]any{
+					"choices": []map[string]any{
+						{"message": map[string]any{"content": content}},
+					},
+				})
+			}))
+			defer server.Close()
+
+			client := New(Config{
+				Name:          "test",
+				BaseURL:       server.URL,
+				APIKey:        "secret",
+				MetadataModel: "meta-model",
+				HTTPClient:    server.Client(),
+				Log:           discardLogger(),
+			})
+
+			metadata, err := client.ExtractMetadata(context.Background(), "hello")
+			if err != nil {
+				t.Fatalf("ExtractMetadata() error = %v", err)
+			}
+			if metadata.Type != "idea" {
+				t.Fatalf("metadata type = %q, want idea", metadata.Type)
+			}
+		})
+	}
+}
+
+func TestExtractMetadataFallbackModel(t *testing.T) {
+	var calls atomic.Int32
+
+	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+		var req chatCompletionsRequest
+		_ = json.NewDecoder(r.Body).Decode(&req)
+
+		if req.Model == "primary-model" {
+			calls.Add(1)
+			http.Error(w, "model unavailable", http.StatusServiceUnavailable)
+			return
+		}
+		_ = json.NewEncoder(w).Encode(map[string]any{
+			"choices": []map[string]any{
+				{"message": map[string]any{"content": "{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"task\",\"source\":\"\"}"}},
+			},
+		})
+	}))
+	defer server.Close()
+
+	client := New(Config{
+		Name:                  "test",
+		BaseURL:               server.URL,
+		APIKey:                "secret",
+		MetadataModel:         "primary-model",
+		FallbackMetadataModel: "fallback-model",
+		HTTPClient:            server.Client(),
+		Log:                   discardLogger(),
+	})
+
+	metadata, err := client.ExtractMetadata(context.Background(), "hello")
+	if err != nil {
+		t.Fatalf("ExtractMetadata() error = %v", err)
+	}
+	if metadata.Type != "task" {
+		t.Fatalf("metadata type = %q, want task", metadata.Type)
+	}
+	if calls.Load() == 0 {
+		t.Fatal("primary model was never called")
+	}
+}
+
 func TestExtractMetadataParsesCodeFencedJSON(t *testing.T) {
 	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
 		_ = json.NewEncoder(w).Encode(map[string]any{