wdevs/amcs
5
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 3 Wiki Activity

fix: scope project skills by tenant #44

Merged
warkanum merged 1 commits from issue-42-tenant-skills into main 2026-08-19 04:30:23 +00:00
Conversation 0 Commits 1 Files Changed 3
+75 -7
sgcommand commented 2026-08-17 22:17:05 +00:00
Member
Copy Link
Copy Source

Summary

Fix tenant isolation for project skills. Project-skill add/remove/list operations now constrain both the project and referenced skill to the active tenant when tenant context is present, preventing cross-tenant visibility and assignment.

Verification

  • go test ./internal/store -v — passed
  • go test ./internal/tools -v — passed
  • go test ./internal/store ./internal/tools — passed
  • git diff --check — passed
  • Full go test ./... was attempted by the worker but is blocked by repository environment/setup issues (missing ui/dist and sandbox-restricted test listener sockets).

Model selection: Tuesday primary Claude Code claude-sonnet-4-6 failed before repository access with OAuth HTTP 401; Codex gpt-5.5 completed the implementation, and the dispatcher independently verified the focused tests, commit, and remote SHA.

Closes #42

## Summary Fix tenant isolation for project skills. Project-skill add/remove/list operations now constrain both the project and referenced skill to the active tenant when tenant context is present, preventing cross-tenant visibility and assignment. ## Verification - `go test ./internal/store -v` — passed - `go test ./internal/tools -v` — passed - `go test ./internal/store ./internal/tools` — passed - `git diff --check` — passed - Full `go test ./...` was attempted by the worker but is blocked by repository environment/setup issues (missing `ui/dist` and sandbox-restricted test listener sockets). Model selection: Tuesday primary Claude Code `claude-sonnet-4-6` failed before repository access with OAuth HTTP 401; Codex `gpt-5.5` completed the implementation, and the dispatcher independently verified the focused tests, commit, and remote SHA. Closes #42
sgcommand added 1 commit 2026-08-17 22:17:06 +00:00
fix: scope project skills by tenant
CI / build-and-test (push) Failing after 20s
Details
CI / build-and-test (pull_request) Failing after 14s
Details
912b87404f
warkanum merged commit 01ff774aa2 into main 2026-08-19 04:30:23 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
debugging
integration
planned
ux
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) warkanum (Warky)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/amcs#44