Some checks failed
CI / build-and-test (push) Failing after -32m5s
- Implemented TraitsTab.svelte to handle CRUD operations for agent traits. - Integrated grid for displaying traits with context menu actions for add, edit, and delete. - Added trait instruction editing functionality with a dedicated editor. - Updated AdminShell to include PersonasPage for navigation. - Enhanced AppSidebar with a new entry for Personas. - Extended ShellPage type to include 'personas'. - Defined new types for AgentPersona, AgentPart, and AgentTrait in types.ts.
1.5 KiB
1.5 KiB
Completed personas UI reachability and fixed the missing backend ResolveSpec registrations that blocked it.
- Added Personas navigation/page wiring in the Svelte admin shell.
- Added a personas overview page with tabs for personas, parts, and traits.
- Expanded the persona inspector to load linked parts, traits, skills, guardrails, and arc state.
- Found that
/api/rs/public/agent_partsand related persona routes were missing becauseinternal/app/resolvespec_admin.gomanually whitelists ResolveSpec models. - Registered persona-related ResolveSpec models:
agent_personas,agent_parts,agent_traits, persona join tables, arc tables, andpersona_arc. - Allowed ResolveSpec mutations for
agent_personas,agent_parts, andagent_traits. - Verified the
internal/apppackage still compiles withenv GOCACHE=/tmp/amcs-go-cache go test -run '^$' ./internal/app.
Follow-up:
- Automated ResolveSpec model registration generation with
relspec templ. - Added
scripts/templates/resolvespec_models.tmpl. - Updated
scripts/generate-models.shto generateinternal/app/resolvespec_models_generated.go. - Removed the handwritten
resolveSpecModels()frominternal/app/resolvespec_admin.go. - Extended
scripts/patch-generated-models.shto fix current relspec output quirks:- incorrect
persona_arcprimary-key cast - unused
resolvespec_commonimports in join-table models
- incorrect
- Added focused tests covering persona entity presence and persona mutation allowlisting.