diff --git a/.github/workflows/integration.yml b/.github/workflows/integration.yml index be06f92..58a158d 100644 --- a/.github/workflows/integration.yml +++ b/.github/workflows/integration.yml @@ -19,12 +19,6 @@ jobs: POSTGRES_DB: broker_test POSTGRES_USER: user POSTGRES_PASSWORD: password - ports: - # No fixed host port: Docker assigns a free one, avoiding - # "port is already allocated" collisions with other jobs on a - # shared runner. The assigned port is read below via the - # `job.services.postgres.ports` context. - - 5432/tcp options: >- --health-cmd="pg_isready -U user" --health-interval=5s @@ -43,6 +37,12 @@ jobs: - name: Run all tests env: - TEST_DB_HOST: 127.0.0.1 - TEST_DB_PORT: ${{ job.services.postgres.ports['5432'] }} + # act_runner runs this job in its own container alongside the + # postgres service container, both on the job's Docker network. + # "localhost" from inside the job container is the job container + # itself, not the runner host, so the service must be reached by + # its network alias (the services: key) and container-internal + # port -- not a published host port. + TEST_DB_HOST: postgres + TEST_DB_PORT: 5432 run: make test-ci TEST_DB_HOST="$TEST_DB_HOST" TEST_DB_PORT="$TEST_DB_PORT"