Compare commits
2 Commits
| Author | SHA1 | Date | |
|---|---|---|---|
| 120ffc6a5a | |||
| b20ad35485 |
@@ -5,6 +5,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
||||||
|
"git.warky.dev/wdevs/relspecgo/pkg/writers"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TemplateData represents the data passed to the template for code generation
|
// TemplateData represents the data passed to the template for code generation
|
||||||
@@ -133,8 +134,10 @@ func NewModelData(table *models.Table, schema string, typeMapper *TypeMapper) *M
|
|||||||
// Find primary key
|
// Find primary key
|
||||||
for _, col := range table.Columns {
|
for _, col := range table.Columns {
|
||||||
if col.IsPrimaryKey {
|
if col.IsPrimaryKey {
|
||||||
model.PrimaryKeyField = SnakeCaseToPascalCase(col.Name)
|
// Sanitize column name to remove backticks
|
||||||
model.IDColumnName = col.Name
|
safeName := writers.SanitizeStructTagValue(col.Name)
|
||||||
|
model.PrimaryKeyField = SnakeCaseToPascalCase(safeName)
|
||||||
|
model.IDColumnName = safeName
|
||||||
// Check if PK type is a SQL type (contains resolvespec_common or sql_types)
|
// Check if PK type is a SQL type (contains resolvespec_common or sql_types)
|
||||||
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
||||||
model.PrimaryKeyIsSQL = strings.Contains(goType, "resolvespec_common") || strings.Contains(goType, "sql_types")
|
model.PrimaryKeyIsSQL = strings.Contains(goType, "resolvespec_common") || strings.Contains(goType, "sql_types")
|
||||||
@@ -154,10 +157,13 @@ func NewModelData(table *models.Table, schema string, typeMapper *TypeMapper) *M
|
|||||||
|
|
||||||
// columnToField converts a models.Column to FieldData
|
// columnToField converts a models.Column to FieldData
|
||||||
func columnToField(col *models.Column, table *models.Table, typeMapper *TypeMapper) *FieldData {
|
func columnToField(col *models.Column, table *models.Table, typeMapper *TypeMapper) *FieldData {
|
||||||
fieldName := SnakeCaseToPascalCase(col.Name)
|
// Sanitize column name first to remove backticks before generating field name
|
||||||
|
safeName := writers.SanitizeStructTagValue(col.Name)
|
||||||
|
fieldName := SnakeCaseToPascalCase(safeName)
|
||||||
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
||||||
bunTag := typeMapper.BuildBunTag(col, table)
|
bunTag := typeMapper.BuildBunTag(col, table)
|
||||||
jsonTag := col.Name // Use column name for JSON tag
|
// Use same sanitized name for JSON tag
|
||||||
|
jsonTag := safeName
|
||||||
|
|
||||||
return &FieldData{
|
return &FieldData{
|
||||||
Name: fieldName,
|
Name: fieldName,
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
||||||
|
"git.warky.dev/wdevs/relspecgo/pkg/writers"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TypeMapper handles type conversions between SQL and Go types for Bun
|
// TypeMapper handles type conversions between SQL and Go types for Bun
|
||||||
@@ -164,11 +165,14 @@ func (tm *TypeMapper) BuildBunTag(column *models.Column, table *models.Table) st
|
|||||||
var parts []string
|
var parts []string
|
||||||
|
|
||||||
// Column name comes first (no prefix)
|
// Column name comes first (no prefix)
|
||||||
parts = append(parts, column.Name)
|
// Sanitize to remove backticks which would break struct tag syntax
|
||||||
|
safeName := writers.SanitizeStructTagValue(column.Name)
|
||||||
|
parts = append(parts, safeName)
|
||||||
|
|
||||||
// Add type if specified
|
// Add type if specified
|
||||||
if column.Type != "" {
|
if column.Type != "" {
|
||||||
typeStr := column.Type
|
// Sanitize type to remove backticks
|
||||||
|
typeStr := writers.SanitizeStructTagValue(column.Type)
|
||||||
if column.Length > 0 {
|
if column.Length > 0 {
|
||||||
typeStr = fmt.Sprintf("%s(%d)", typeStr, column.Length)
|
typeStr = fmt.Sprintf("%s(%d)", typeStr, column.Length)
|
||||||
} else if column.Precision > 0 {
|
} else if column.Precision > 0 {
|
||||||
@@ -188,7 +192,9 @@ func (tm *TypeMapper) BuildBunTag(column *models.Column, table *models.Table) st
|
|||||||
|
|
||||||
// Default value
|
// Default value
|
||||||
if column.Default != nil {
|
if column.Default != nil {
|
||||||
parts = append(parts, fmt.Sprintf("default:%v", column.Default))
|
// Sanitize default value to remove backticks
|
||||||
|
safeDefault := writers.SanitizeStructTagValue(fmt.Sprintf("%v", column.Default))
|
||||||
|
parts = append(parts, fmt.Sprintf("default:%s", safeDefault))
|
||||||
}
|
}
|
||||||
|
|
||||||
// Nullable (Bun uses nullzero for nullable fields)
|
// Nullable (Bun uses nullzero for nullable fields)
|
||||||
@@ -263,7 +269,7 @@ func (tm *TypeMapper) NeedsFmtImport(generateGetIDStr bool) bool {
|
|||||||
|
|
||||||
// GetSQLTypesImport returns the import path for sql_types (ResolveSpec common)
|
// GetSQLTypesImport returns the import path for sql_types (ResolveSpec common)
|
||||||
func (tm *TypeMapper) GetSQLTypesImport() string {
|
func (tm *TypeMapper) GetSQLTypesImport() string {
|
||||||
return "github.com/bitechdev/ResolveSpec/pkg/common"
|
return "github.com/bitechdev/ResolveSpec/pkg/spectypes"
|
||||||
}
|
}
|
||||||
|
|
||||||
// GetBunImport returns the import path for Bun
|
// GetBunImport returns the import path for Bun
|
||||||
|
|||||||
@@ -239,7 +239,7 @@ func (w *Writer) addRelationshipFields(modelData *ModelData, table *models.Table
|
|||||||
|
|
||||||
// Create relationship field (has-one in Bun, similar to belongs-to in GORM)
|
// Create relationship field (has-one in Bun, similar to belongs-to in GORM)
|
||||||
refModelName := w.getModelName(constraint.ReferencedTable)
|
refModelName := w.getModelName(constraint.ReferencedTable)
|
||||||
fieldName := w.generateRelationshipFieldName(constraint.ReferencedTable)
|
fieldName := w.generateRelationshipFieldName(constraint)
|
||||||
relationTag := w.typeMapper.BuildRelationshipTag(constraint, "has-one")
|
relationTag := w.typeMapper.BuildRelationshipTag(constraint, "has-one")
|
||||||
|
|
||||||
modelData.AddRelationshipField(&FieldData{
|
modelData.AddRelationshipField(&FieldData{
|
||||||
@@ -267,7 +267,7 @@ func (w *Writer) addRelationshipFields(modelData *ModelData, table *models.Table
|
|||||||
if constraint.ReferencedTable == table.Name && constraint.ReferencedSchema == schema.Name {
|
if constraint.ReferencedTable == table.Name && constraint.ReferencedSchema == schema.Name {
|
||||||
// Add has-many relationship
|
// Add has-many relationship
|
||||||
otherModelName := w.getModelName(otherTable.Name)
|
otherModelName := w.getModelName(otherTable.Name)
|
||||||
fieldName := w.generateRelationshipFieldName(otherTable.Name) + "s" // Pluralize
|
fieldName := w.generateRelationshipFieldName(constraint) + "s" // Pluralize
|
||||||
relationTag := w.typeMapper.BuildRelationshipTag(constraint, "has-many")
|
relationTag := w.typeMapper.BuildRelationshipTag(constraint, "has-many")
|
||||||
|
|
||||||
modelData.AddRelationshipField(&FieldData{
|
modelData.AddRelationshipField(&FieldData{
|
||||||
@@ -310,10 +310,19 @@ func (w *Writer) getModelName(tableName string) string {
|
|||||||
return modelName
|
return modelName
|
||||||
}
|
}
|
||||||
|
|
||||||
// generateRelationshipFieldName generates a field name for a relationship
|
// generateRelationshipFieldName generates a field name for a relationship based on the foreign key column
|
||||||
func (w *Writer) generateRelationshipFieldName(tableName string) string {
|
func (w *Writer) generateRelationshipFieldName(constraint *models.Constraint) string {
|
||||||
// Use just the prefix (3 letters) for relationship fields
|
// Use the foreign key column name to ensure uniqueness
|
||||||
return GeneratePrefix(tableName)
|
// If there are multiple columns, use the first one
|
||||||
|
if len(constraint.Columns) > 0 {
|
||||||
|
columnName := constraint.Columns[0]
|
||||||
|
// Convert to PascalCase for proper Go field naming
|
||||||
|
// e.g., "rid_filepointer_request" -> "RidFilepointerRequest"
|
||||||
|
return "Rel" + SnakeCaseToPascalCase(columnName)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Fallback to table-based prefix if no columns defined
|
||||||
|
return "Rel" + GeneratePrefix(constraint.ReferencedTable)
|
||||||
}
|
}
|
||||||
|
|
||||||
// getPackageName returns the package name from options or defaults to "models"
|
// getPackageName returns the package name from options or defaults to "models"
|
||||||
|
|||||||
@@ -175,14 +175,118 @@ func TestWriter_WriteDatabase_MultiFile(t *testing.T) {
|
|||||||
postsStr := string(postsContent)
|
postsStr := string(postsContent)
|
||||||
|
|
||||||
// Verify relationship is present with Bun format
|
// Verify relationship is present with Bun format
|
||||||
if !strings.Contains(postsStr, "USE") {
|
// Should now be RelUserID instead of USE
|
||||||
t.Errorf("Missing relationship field USE")
|
if !strings.Contains(postsStr, "RelUserID") {
|
||||||
|
t.Errorf("Missing relationship field RelUserID (new naming convention)")
|
||||||
}
|
}
|
||||||
if !strings.Contains(postsStr, "rel:has-one") {
|
if !strings.Contains(postsStr, "rel:has-one") {
|
||||||
t.Errorf("Missing Bun relationship tag: %s", postsStr)
|
t.Errorf("Missing Bun relationship tag: %s", postsStr)
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestWriter_MultipleReferencesToSameTable(t *testing.T) {
|
||||||
|
// Test scenario: api_event table with multiple foreign keys to filepointer table
|
||||||
|
db := models.InitDatabase("testdb")
|
||||||
|
schema := models.InitSchema("org")
|
||||||
|
|
||||||
|
// Filepointer table
|
||||||
|
filepointer := models.InitTable("filepointer", "org")
|
||||||
|
filepointer.Columns["id_filepointer"] = &models.Column{
|
||||||
|
Name: "id_filepointer",
|
||||||
|
Type: "bigserial",
|
||||||
|
NotNull: true,
|
||||||
|
IsPrimaryKey: true,
|
||||||
|
}
|
||||||
|
schema.Tables = append(schema.Tables, filepointer)
|
||||||
|
|
||||||
|
// API event table with two foreign keys to filepointer
|
||||||
|
apiEvent := models.InitTable("api_event", "org")
|
||||||
|
apiEvent.Columns["id_api_event"] = &models.Column{
|
||||||
|
Name: "id_api_event",
|
||||||
|
Type: "bigserial",
|
||||||
|
NotNull: true,
|
||||||
|
IsPrimaryKey: true,
|
||||||
|
}
|
||||||
|
apiEvent.Columns["rid_filepointer_request"] = &models.Column{
|
||||||
|
Name: "rid_filepointer_request",
|
||||||
|
Type: "bigint",
|
||||||
|
NotNull: false,
|
||||||
|
}
|
||||||
|
apiEvent.Columns["rid_filepointer_response"] = &models.Column{
|
||||||
|
Name: "rid_filepointer_response",
|
||||||
|
Type: "bigint",
|
||||||
|
NotNull: false,
|
||||||
|
}
|
||||||
|
|
||||||
|
// Add constraints
|
||||||
|
apiEvent.Constraints["fk_request"] = &models.Constraint{
|
||||||
|
Name: "fk_request",
|
||||||
|
Type: models.ForeignKeyConstraint,
|
||||||
|
Columns: []string{"rid_filepointer_request"},
|
||||||
|
ReferencedTable: "filepointer",
|
||||||
|
ReferencedSchema: "org",
|
||||||
|
ReferencedColumns: []string{"id_filepointer"},
|
||||||
|
}
|
||||||
|
apiEvent.Constraints["fk_response"] = &models.Constraint{
|
||||||
|
Name: "fk_response",
|
||||||
|
Type: models.ForeignKeyConstraint,
|
||||||
|
Columns: []string{"rid_filepointer_response"},
|
||||||
|
ReferencedTable: "filepointer",
|
||||||
|
ReferencedSchema: "org",
|
||||||
|
ReferencedColumns: []string{"id_filepointer"},
|
||||||
|
}
|
||||||
|
|
||||||
|
schema.Tables = append(schema.Tables, apiEvent)
|
||||||
|
db.Schemas = append(db.Schemas, schema)
|
||||||
|
|
||||||
|
// Create writer
|
||||||
|
tmpDir := t.TempDir()
|
||||||
|
opts := &writers.WriterOptions{
|
||||||
|
PackageName: "models",
|
||||||
|
OutputPath: tmpDir,
|
||||||
|
Metadata: map[string]interface{}{
|
||||||
|
"multi_file": true,
|
||||||
|
},
|
||||||
|
}
|
||||||
|
|
||||||
|
writer := NewWriter(opts)
|
||||||
|
err := writer.WriteDatabase(db)
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("WriteDatabase failed: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
// Read the api_event file
|
||||||
|
apiEventContent, err := os.ReadFile(filepath.Join(tmpDir, "sql_org_api_event.go"))
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Failed to read api_event file: %v", err)
|
||||||
|
}
|
||||||
|
|
||||||
|
contentStr := string(apiEventContent)
|
||||||
|
|
||||||
|
// Verify both relationships have unique names based on column names
|
||||||
|
expectations := []struct {
|
||||||
|
fieldName string
|
||||||
|
tag string
|
||||||
|
}{
|
||||||
|
{"RelRIDFilepointerRequest", "join:rid_filepointer_request=id_filepointer"},
|
||||||
|
{"RelRIDFilepointerResponse", "join:rid_filepointer_response=id_filepointer"},
|
||||||
|
}
|
||||||
|
|
||||||
|
for _, exp := range expectations {
|
||||||
|
if !strings.Contains(contentStr, exp.fieldName) {
|
||||||
|
t.Errorf("Missing relationship field: %s\nGenerated:\n%s", exp.fieldName, contentStr)
|
||||||
|
}
|
||||||
|
if !strings.Contains(contentStr, exp.tag) {
|
||||||
|
t.Errorf("Missing relationship tag: %s\nGenerated:\n%s", exp.tag, contentStr)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
// Verify NO duplicate field names (old behavior would create duplicate "FIL" fields)
|
||||||
|
if strings.Contains(contentStr, "FIL *ModelFilepointer") {
|
||||||
|
t.Errorf("Found old prefix-based naming (FIL), should use column-based naming")
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
func TestTypeMapper_SQLTypeToGoType_Bun(t *testing.T) {
|
func TestTypeMapper_SQLTypeToGoType_Bun(t *testing.T) {
|
||||||
mapper := NewTypeMapper()
|
mapper := NewTypeMapper()
|
||||||
|
|
||||||
|
|||||||
@@ -4,6 +4,7 @@ import (
|
|||||||
"sort"
|
"sort"
|
||||||
|
|
||||||
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
||||||
|
"git.warky.dev/wdevs/relspecgo/pkg/writers"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TemplateData represents the data passed to the template for code generation
|
// TemplateData represents the data passed to the template for code generation
|
||||||
@@ -131,8 +132,10 @@ func NewModelData(table *models.Table, schema string, typeMapper *TypeMapper) *M
|
|||||||
// Find primary key
|
// Find primary key
|
||||||
for _, col := range table.Columns {
|
for _, col := range table.Columns {
|
||||||
if col.IsPrimaryKey {
|
if col.IsPrimaryKey {
|
||||||
model.PrimaryKeyField = SnakeCaseToPascalCase(col.Name)
|
// Sanitize column name to remove backticks
|
||||||
model.IDColumnName = col.Name
|
safeName := writers.SanitizeStructTagValue(col.Name)
|
||||||
|
model.PrimaryKeyField = SnakeCaseToPascalCase(safeName)
|
||||||
|
model.IDColumnName = safeName
|
||||||
break
|
break
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
@@ -149,10 +152,13 @@ func NewModelData(table *models.Table, schema string, typeMapper *TypeMapper) *M
|
|||||||
|
|
||||||
// columnToField converts a models.Column to FieldData
|
// columnToField converts a models.Column to FieldData
|
||||||
func columnToField(col *models.Column, table *models.Table, typeMapper *TypeMapper) *FieldData {
|
func columnToField(col *models.Column, table *models.Table, typeMapper *TypeMapper) *FieldData {
|
||||||
fieldName := SnakeCaseToPascalCase(col.Name)
|
// Sanitize column name first to remove backticks before generating field name
|
||||||
|
safeName := writers.SanitizeStructTagValue(col.Name)
|
||||||
|
fieldName := SnakeCaseToPascalCase(safeName)
|
||||||
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
goType := typeMapper.SQLTypeToGoType(col.Type, col.NotNull)
|
||||||
gormTag := typeMapper.BuildGormTag(col, table)
|
gormTag := typeMapper.BuildGormTag(col, table)
|
||||||
jsonTag := col.Name // Use column name for JSON tag
|
// Use same sanitized name for JSON tag
|
||||||
|
jsonTag := safeName
|
||||||
|
|
||||||
return &FieldData{
|
return &FieldData{
|
||||||
Name: fieldName,
|
Name: fieldName,
|
||||||
|
|||||||
@@ -5,6 +5,7 @@ import (
|
|||||||
"strings"
|
"strings"
|
||||||
|
|
||||||
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
"git.warky.dev/wdevs/relspecgo/pkg/models"
|
||||||
|
"git.warky.dev/wdevs/relspecgo/pkg/writers"
|
||||||
)
|
)
|
||||||
|
|
||||||
// TypeMapper handles type conversions between SQL and Go types
|
// TypeMapper handles type conversions between SQL and Go types
|
||||||
@@ -199,12 +200,15 @@ func (tm *TypeMapper) BuildGormTag(column *models.Column, table *models.Table) s
|
|||||||
var parts []string
|
var parts []string
|
||||||
|
|
||||||
// Always include column name (lowercase as per user requirement)
|
// Always include column name (lowercase as per user requirement)
|
||||||
parts = append(parts, fmt.Sprintf("column:%s", column.Name))
|
// Sanitize to remove backticks which would break struct tag syntax
|
||||||
|
safeName := writers.SanitizeStructTagValue(column.Name)
|
||||||
|
parts = append(parts, fmt.Sprintf("column:%s", safeName))
|
||||||
|
|
||||||
// Add type if specified
|
// Add type if specified
|
||||||
if column.Type != "" {
|
if column.Type != "" {
|
||||||
// Include length, precision, scale if present
|
// Include length, precision, scale if present
|
||||||
typeStr := column.Type
|
// Sanitize type to remove backticks
|
||||||
|
typeStr := writers.SanitizeStructTagValue(column.Type)
|
||||||
if column.Length > 0 {
|
if column.Length > 0 {
|
||||||
typeStr = fmt.Sprintf("%s(%d)", typeStr, column.Length)
|
typeStr = fmt.Sprintf("%s(%d)", typeStr, column.Length)
|
||||||
} else if column.Precision > 0 {
|
} else if column.Precision > 0 {
|
||||||
@@ -234,7 +238,9 @@ func (tm *TypeMapper) BuildGormTag(column *models.Column, table *models.Table) s
|
|||||||
|
|
||||||
// Default value
|
// Default value
|
||||||
if column.Default != nil {
|
if column.Default != nil {
|
||||||
parts = append(parts, fmt.Sprintf("default:%v", column.Default))
|
// Sanitize default value to remove backticks
|
||||||
|
safeDefault := writers.SanitizeStructTagValue(fmt.Sprintf("%v", column.Default))
|
||||||
|
parts = append(parts, fmt.Sprintf("default:%s", safeDefault))
|
||||||
}
|
}
|
||||||
|
|
||||||
// Check for unique constraint
|
// Check for unique constraint
|
||||||
@@ -331,5 +337,5 @@ func (tm *TypeMapper) NeedsFmtImport(generateGetIDStr bool) bool {
|
|||||||
|
|
||||||
// GetSQLTypesImport returns the import path for sql_types
|
// GetSQLTypesImport returns the import path for sql_types
|
||||||
func (tm *TypeMapper) GetSQLTypesImport() string {
|
func (tm *TypeMapper) GetSQLTypesImport() string {
|
||||||
return "github.com/bitechdev/ResolveSpec/pkg/common/sql_types"
|
return "github.com/bitechdev/ResolveSpec/pkg/spectypes"
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -61,3 +61,26 @@ func SanitizeFilename(name string) string {
|
|||||||
|
|
||||||
return name
|
return name
|
||||||
}
|
}
|
||||||
|
|
||||||
|
// SanitizeStructTagValue sanitizes a value to be safely used inside Go struct tags.
|
||||||
|
// Go struct tags are delimited by backticks, so any backtick in the value would break the syntax.
|
||||||
|
// This function:
|
||||||
|
// - Removes DBML/DCTX comments in brackets
|
||||||
|
// - Removes all quotes (double, single, and backticks)
|
||||||
|
// - Returns a clean identifier safe for use in struct tags and field names
|
||||||
|
func SanitizeStructTagValue(value string) string {
|
||||||
|
// Remove DBML/DCTX style comments in brackets (e.g., [note: 'description'])
|
||||||
|
commentRegex := regexp.MustCompile(`\s*\[.*?\]\s*`)
|
||||||
|
value = commentRegex.ReplaceAllString(value, "")
|
||||||
|
|
||||||
|
// Trim whitespace
|
||||||
|
value = strings.TrimSpace(value)
|
||||||
|
|
||||||
|
// Remove all quotes: backticks, double quotes, and single quotes
|
||||||
|
// This ensures the value is clean for use as Go identifiers and struct tag values
|
||||||
|
value = strings.ReplaceAll(value, "`", "")
|
||||||
|
value = strings.ReplaceAll(value, `"`, "")
|
||||||
|
value = strings.ReplaceAll(value, `'`, "")
|
||||||
|
|
||||||
|
return value
|
||||||
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user