wdevs/relspecgo
5
0
Fork 0
Code Issues 4 Pull Requests Actions Packages Releases 83 Wiki Activity

test(sqltypes): cover scalar conversions and constructors #51

Merged
warkanum merged 1 commits from issue-45-test-coverage into master 2026-10-03 18:11:40 +00:00
Conversation 0 Commits 1 Files Changed 1
+157
sgcommand commented 2026-10-03 10:31:11 +00:00
Member
Copy Link
Copy Source

Summary

Adds a focused pkg/sqltypes test slice for the coverage plan: scalar Value, Int64/Float64 conversions, SqlDate JSON null/invalid handling, now constructors, NewSql, NewSqlFloat32, and ToJSONDT.

Issue: #45

Verification

  • GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test ./pkg/sqltypes
  • GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test -race ./pkg/sqltypes
  • GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test -cover ./pkg/sqltypes (69.8%)
  • GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test ./...
  • GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go vet ./pkg/sqltypes
  • git diff --check

Branch: issue-45-test-coverage
Commit: fd9c37cd25d3f003fe902bce1f519ef52daa58fa

## Summary Adds a focused `pkg/sqltypes` test slice for the coverage plan: scalar `Value`, `Int64`/`Float64` conversions, `SqlDate` JSON null/invalid handling, now constructors, `NewSql`, `NewSqlFloat32`, and `ToJSONDT`. Issue: #45 ## Verification - `GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test ./pkg/sqltypes` - `GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test -race ./pkg/sqltypes` - `GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test -cover ./pkg/sqltypes` (69.8%) - `GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go test ./...` - `GOTMPDIR=/home/hermes/.tmp GOCACHE=/home/hermes/.cache/go go vet ./pkg/sqltypes` - `git diff --check` Branch: `issue-45-test-coverage` Commit: `fd9c37cd25d3f003fe902bce1f519ef52daa58fa`
sgcommand added 1 commit 2026-10-03 10:31:11 +00:00
test(sqltypes): cover scalar conversions and constructors fd9c37cd25
warkanum merged commit f1b9079b2d into master 2026-10-03 18:11:40 +00:00
warkanum deleted branch issue-45-test-coverage 2026-10-03 18:11:40 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Medium
3
The priority is medium
Priority
Low
4
The priority is low
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
Status
Abandoned
3
Somebody has started to work on this but abandoned work
No labels
Milestone
No items
No Milestone
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) support warkanum (Warky)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/relspecgo#51