feat(config): add restart options for unit configuration
* include Restart, RestartSec, and RestartRetries fields * update service file generation to support restart settings * add tests for restart behavior in unit generation
This commit is contained in:
@@ -20,6 +20,9 @@ type Unit struct {
|
|||||||
Delay string `yaml:"delay,omitempty"` // e.g. "5s"
|
Delay string `yaml:"delay,omitempty"` // e.g. "5s"
|
||||||
Enabled bool `yaml:"enabled"`
|
Enabled bool `yaml:"enabled"`
|
||||||
DisabledReason string `yaml:"disabled_reason,omitempty"`
|
DisabledReason string `yaml:"disabled_reason,omitempty"`
|
||||||
|
Restart bool `yaml:"restart,omitempty"` // enable Restart=on-failure
|
||||||
|
RestartSec int `yaml:"restart_sec,omitempty"` // seconds between restarts
|
||||||
|
RestartRetries int `yaml:"restart_retries,omitempty"` // max restart attempts (StartLimitBurst)
|
||||||
}
|
}
|
||||||
|
|
||||||
// Config is the root config structure.
|
// Config is the root config structure.
|
||||||
|
|||||||
@@ -20,8 +20,13 @@ Requires={{.}}{{end}}
|
|||||||
Type=simple
|
Type=simple
|
||||||
ExecStart={{.ExecStart}}
|
ExecStart={{.ExecStart}}
|
||||||
ExecStop={{.ExecStop}}
|
ExecStop={{.ExecStop}}
|
||||||
|
{{- if .Unit.Restart}}
|
||||||
Restart=on-failure
|
Restart=on-failure
|
||||||
RestartSec=5
|
RestartSec={{.Unit.RestartSec}}
|
||||||
|
{{- if gt .Unit.RestartRetries 0}}
|
||||||
|
StartLimitBurst={{.Unit.RestartRetries}}
|
||||||
|
{{- end}}
|
||||||
|
{{- end}}
|
||||||
|
|
||||||
[Install]
|
[Install]
|
||||||
WantedBy=multi-user.target
|
WantedBy=multi-user.target
|
||||||
@@ -38,8 +43,13 @@ After=default.target
|
|||||||
Type=simple
|
Type=simple
|
||||||
ExecStart={{.ExecStart}}
|
ExecStart={{.ExecStart}}
|
||||||
ExecStop={{.ExecStop}}
|
ExecStop={{.ExecStop}}
|
||||||
|
{{- if .Unit.Restart}}
|
||||||
Restart=on-failure
|
Restart=on-failure
|
||||||
RestartSec=5
|
RestartSec={{.Unit.RestartSec}}
|
||||||
|
{{- if gt .Unit.RestartRetries 0}}
|
||||||
|
StartLimitBurst={{.Unit.RestartRetries}}
|
||||||
|
{{- end}}
|
||||||
|
{{- end}}
|
||||||
|
|
||||||
[Install]
|
[Install]
|
||||||
WantedBy=default.target
|
WantedBy=default.target
|
||||||
|
|||||||
@@ -50,7 +50,6 @@ func TestGenerate_SystemUnit(t *testing.T) {
|
|||||||
"WantedBy=multi-user.target",
|
"WantedBy=multi-user.target",
|
||||||
"ExecStart=/usr/bin/podman start -a nginx",
|
"ExecStart=/usr/bin/podman start -a nginx",
|
||||||
"ExecStop=/usr/bin/podman stop nginx",
|
"ExecStop=/usr/bin/podman stop nginx",
|
||||||
"Restart=on-failure",
|
|
||||||
"Generated by unitdore",
|
"Generated by unitdore",
|
||||||
}
|
}
|
||||||
|
|
||||||
@@ -66,6 +65,9 @@ func TestGenerate_SystemUnit(t *testing.T) {
|
|||||||
if strings.Contains(content, "Requires=") {
|
if strings.Contains(content, "Requires=") {
|
||||||
t.Errorf("Generate() podman system unit should not contain Requires= (podman is daemonless):\n%s", content)
|
t.Errorf("Generate() podman system unit should not contain Requires= (podman is daemonless):\n%s", content)
|
||||||
}
|
}
|
||||||
|
if strings.Contains(content, "Restart=") {
|
||||||
|
t.Errorf("Generate() restart should be disabled by default:\n%s", content)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
func TestGenerate_UserUnit(t *testing.T) {
|
func TestGenerate_UserUnit(t *testing.T) {
|
||||||
@@ -100,6 +102,51 @@ func TestGenerate_UserUnit(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
func TestGenerate_WithRestart(t *testing.T) {
|
||||||
|
t.Run("restart with retries", func(t *testing.T) {
|
||||||
|
u := config.Unit{
|
||||||
|
Name: "nginx",
|
||||||
|
Runtime: "podman",
|
||||||
|
Enabled: true,
|
||||||
|
Restart: true,
|
||||||
|
RestartSec: 5,
|
||||||
|
RestartRetries: 3,
|
||||||
|
}
|
||||||
|
content, err := Generate(u, "", "")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Generate() error: %v", err)
|
||||||
|
}
|
||||||
|
for _, want := range []string{"Restart=on-failure", "RestartSec=5", "StartLimitBurst=3"} {
|
||||||
|
if !strings.Contains(content, want) {
|
||||||
|
t.Errorf("Generate() missing %q in output:\n%s", want, content)
|
||||||
|
}
|
||||||
|
}
|
||||||
|
})
|
||||||
|
|
||||||
|
t.Run("restart without retries", func(t *testing.T) {
|
||||||
|
u := config.Unit{
|
||||||
|
Name: "nginx",
|
||||||
|
Runtime: "podman",
|
||||||
|
Enabled: true,
|
||||||
|
Restart: true,
|
||||||
|
RestartSec: 10,
|
||||||
|
}
|
||||||
|
content, err := Generate(u, "", "")
|
||||||
|
if err != nil {
|
||||||
|
t.Fatalf("Generate() error: %v", err)
|
||||||
|
}
|
||||||
|
if !strings.Contains(content, "Restart=on-failure") {
|
||||||
|
t.Errorf("Generate() missing Restart=on-failure:\n%s", content)
|
||||||
|
}
|
||||||
|
if !strings.Contains(content, "RestartSec=10") {
|
||||||
|
t.Errorf("Generate() missing RestartSec=10:\n%s", content)
|
||||||
|
}
|
||||||
|
if strings.Contains(content, "StartLimitBurst") {
|
||||||
|
t.Errorf("Generate() should not contain StartLimitBurst when retries=0:\n%s", content)
|
||||||
|
}
|
||||||
|
})
|
||||||
|
}
|
||||||
|
|
||||||
func TestGenerate_CustomCommand(t *testing.T) {
|
func TestGenerate_CustomCommand(t *testing.T) {
|
||||||
u := config.Unit{
|
u := config.Unit{
|
||||||
Name: "custom",
|
Name: "custom",
|
||||||
|
|||||||
Reference in New Issue
Block a user