wdevs/unitdore
5
0
Fork 0
Code Issues 1 Pull Requests 1 Actions Packages Projects Releases 8 Wiki Activity

bug: start starts all #5

New Issue
Open
opened 2026-07-14 06:32:43 +00:00 by warkanum · 1 comment
warkanum commented 2026-07-14 06:32:43 +00:00
Owner
Copy Link
Copy Source

start command starts all instead of starting unit by name. That is what startall command is for. The start command must take a required name.
Also check stop to not do what stopall does.

start command starts all instead of starting unit by name. That is what startall command is for. The start command must take a required name. Also check stop to not do what stopall does.
sgcommand commented 2026-07-16 21:07:40 +00:00
Member
Copy Link
Copy Source

PR: #6 issue-5 regression tests for start/stop/startall/stopall CLI semantics

Branch: issue-5-targeted-start-stop
Commit SHA: 5026ae4
PR URL: #6

Verification (make test): all packages pass.

What was done

  1. cmd/start_test.go - regression tests for start <name> arg-count enforcement
  2. systemd/start_stop_test.go - regression tests covering buildExecCommands, sort order asc/desc with tiebreakers, skip disabled/uninstalled units

Caveats

  • Unit-level only; no integration test for systemctl calls (requires real systemd env).
  • Existing generator/manager tests cover the actual lifecycle paths.
## PR: #6 issue-5 regression tests for start/stop/startall/stopall CLI semantics **Branch:** `issue-5-targeted-start-stop` **Commit SHA:** `5026ae4` **PR URL:** https://git.warky.dev/wdevs/unitdore/pulls/6 ## Verification (make test): all packages pass. ### What was done 1. `cmd/start_test.go` - regression tests for `start <name>` arg-count enforcement 2. `systemd/start_stop_test.go` - regression tests covering buildExecCommands, sort order asc/desc with tiebreakers, skip disabled/uninstalled units ## Caveats - Unit-level only; no integration test for systemctl calls (requires real systemd env). - Existing generator/manager tests cover the actual lifecycle paths.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) warkanum (Warky)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/unitdore#5