amcs/internal/ai/compat/client_test.go

package compat

import (
	"context"
	"encoding/json"
	"io"
	"log/slog"
	"net/http"
	"net/http/httptest"
	"sync/atomic"
	"testing"
)

func discardLogger() *slog.Logger {
	return slog.New(slog.NewTextHandler(io.Discard, nil))
}

func TestEmbedRetriesTransientFailures(t *testing.T) {
	var calls atomic.Int32

	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		if calls.Add(1) < 3 {
			http.Error(w, "temporary failure", http.StatusServiceUnavailable)
			return
		}
		_ = json.NewEncoder(w).Encode(map[string]any{
			"data": []map[string]any{
				{"embedding": []float32{1, 2, 3}},
			},
		})
	}))
	defer server.Close()

	client := New(Config{
		Name:           "test",
		BaseURL:        server.URL,
		APIKey:         "secret",
		EmbeddingModel: "embed-model",
		MetadataModel:  "meta-model",
		HTTPClient:     server.Client(),
		Log:            discardLogger(),
		Dimensions:     3,
	})

	embedding, err := client.Embed(context.Background(), "hello")
	if err != nil {
		t.Fatalf("Embed() error = %v", err)
	}
	if len(embedding) != 3 {
		t.Fatalf("embedding len = %d, want 3", len(embedding))
	}
	if got := calls.Load(); got != 3 {
		t.Fatalf("call count = %d, want 3", got)
	}
}

func TestExtractMetadataStripsThinkingBlocks(t *testing.T) {
	cases := []struct {
		name    string
		content string
	}{
		{
			name:    "think tag with braces inside",
			content: "<think>\nLet me map {this} to the schema carefully.\n</think>\n{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"idea\",\"source\":\"\"}",
		},
		{
			name:    "thinking tag",
			content: "<thinking>reasoning {here}</thinking>{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"idea\",\"source\":\"\"}",
		},
	}

	for _, tc := range cases {
		t.Run(tc.name, func(t *testing.T) {
			content := tc.content
			server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
				_ = json.NewEncoder(w).Encode(map[string]any{
					"choices": []map[string]any{
						{"message": map[string]any{"content": content}},
					},
				})
			}))
			defer server.Close()

			client := New(Config{
				Name:          "test",
				BaseURL:       server.URL,
				APIKey:        "secret",
				MetadataModel: "meta-model",
				HTTPClient:    server.Client(),
				Log:           discardLogger(),
			})

			metadata, err := client.ExtractMetadata(context.Background(), "hello")
			if err != nil {
				t.Fatalf("ExtractMetadata() error = %v", err)
			}
			if metadata.Type != "idea" {
				t.Fatalf("metadata type = %q, want idea", metadata.Type)
			}
		})
	}
}

func TestExtractMetadataFallbackModel(t *testing.T) {
	var calls atomic.Int32

	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		var req chatCompletionsRequest
		_ = json.NewDecoder(r.Body).Decode(&req)

		if req.Model == "primary-model" {
			calls.Add(1)
			http.Error(w, "model unavailable", http.StatusServiceUnavailable)
			return
		}
		_ = json.NewEncoder(w).Encode(map[string]any{
			"choices": []map[string]any{
				{"message": map[string]any{"content": "{\"people\":[],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"test\"],\"type\":\"task\",\"source\":\"\"}"}},
			},
		})
	}))
	defer server.Close()

	client := New(Config{
		Name:                  "test",
		BaseURL:               server.URL,
		APIKey:                "secret",
		MetadataModel:         "primary-model",
		FallbackMetadataModel: "fallback-model",
		HTTPClient:            server.Client(),
		Log:                   discardLogger(),
	})

	metadata, err := client.ExtractMetadata(context.Background(), "hello")
	if err != nil {
		t.Fatalf("ExtractMetadata() error = %v", err)
	}
	if metadata.Type != "task" {
		t.Fatalf("metadata type = %q, want task", metadata.Type)
	}
	if calls.Load() == 0 {
		t.Fatal("primary model was never called")
	}
}

func TestExtractMetadataParsesCodeFencedJSON(t *testing.T) {
	server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
		_ = json.NewEncoder(w).Encode(map[string]any{
			"choices": []map[string]any{
				{
					"message": map[string]any{
						"content": "```json\n{\"people\":[\"Alice\"],\"action_items\":[],\"dates_mentioned\":[],\"topics\":[\"memory\"],\"type\":\"idea\",\"source\":\"mcp\"}\n```",
					},
				},
			},
		})
	}))
	defer server.Close()

	client := New(Config{
		Name:           "test",
		BaseURL:        server.URL,
		APIKey:         "secret",
		EmbeddingModel: "embed-model",
		MetadataModel:  "meta-model",
		HTTPClient:     server.Client(),
		Log:            discardLogger(),
	})

	metadata, err := client.ExtractMetadata(context.Background(), "hello")
	if err != nil {
		t.Fatalf("ExtractMetadata() error = %v", err)
	}
	if metadata.Type != "idea" {
		t.Fatalf("metadata type = %q, want idea", metadata.Type)
	}
	if len(metadata.People) != 1 || metadata.People[0] != "Alice" {
		t.Fatalf("metadata people = %#v, want [Alice]", metadata.People)
	}
}