wdevs/relspecgo
5
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 63 Wiki Activity

relspec templ's @TableIndex ordering is non-deterministic #10

New Issue
Closed
opened 2026-07-19 13:46:31 +00:00 by warkanum · 2 comments
warkanum commented 2026-07-19 13:46:31 +00:00
Owner
Copy Link
Copy Source

Found a real upstream bug while checking codegen reproducibility: relspec templ's @TableIndex ordering is non-deterministic (content-identical, order differs) on 6 of the 18 tables — this will cause spurious failures on the "clean diff" CI gates both docs promise for regeneration. Worth filing against relspecgo.

Found a real upstream bug while checking codegen reproducibility: relspec templ's @TableIndex ordering is non-deterministic (content-identical, order differs) on 6 of the 18 tables — this will cause spurious failures on the "clean diff" CI gates both docs promise for regeneration. Worth filing against relspecgo.
sgcommand commented 2026-07-19 13:58:02 +00:00
Member
Copy Link
Copy Source

PR opened: #11

Branch: fix/issue-10-deterministic-table-index
Commit: c2def00bcfe9a0529dea08efc7edafabb3489826

Verification completed:

  • Regression first reproduced nondeterministic output before the fix.
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template -run TestWriterTableIndexValuesDeterministic -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template ./pkg/reflectutil -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/... -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./... -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache make test
  • git diff --check

Not merging or closing; ready for independent review.

PR opened: https://git.warky.dev/wdevs/relspecgo/pulls/11 Branch: `fix/issue-10-deterministic-table-index` Commit: `c2def00bcfe9a0529dea08efc7edafabb3489826` Verification completed: - Regression first reproduced nondeterministic output before the fix. - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template -run TestWriterTableIndexValuesDeterministic -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template ./pkg/reflectutil -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/... -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./... -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache make test` - `git diff --check` Not merging or closing; ready for independent review.
sgcommand commented 2026-07-19 14:11:12 +00:00
Member
Copy Link
Copy Source

Completed and merged via PR #11. Independent review confirmed the template values path now sorts map keys deterministically, repeatedly generated TableIndex output is byte-identical and lexically ordered, gofmt and git diff --check pass, and go test ./... passes. Feature SHA: c2def00bcf.

Completed and merged via PR #11. Independent review confirmed the template values path now sorts map keys deterministically, repeatedly generated TableIndex output is byte-identical and lexically ordered, gofmt and git diff --check pass, and go test ./... passes. Feature SHA: c2def00bcfe9a0529dea08efc7edafabb3489826.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) support warkanum (Warky)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/relspecgo#10
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?