wdevs/relspecgo
5
0
Fork 0
Code Issues Pull Requests Actions Packages Releases 63 Wiki Activity

Fix deterministic template table index ordering #11

Merged
sgcommand merged 1 commits from fix/issue-10-deterministic-table-index into master 2026-07-19 14:11:11 +00:00
Conversation 0 Commits 1 Files Changed 2
+119 -5
sgcommand commented 2026-07-19 13:57:33 +00:00
Member
Copy Link
Copy Source

Fixes the template writer path where values .Table.Indexes was backed by raw Go map iteration, causing repeated code generation from the same schema to emit indexes in different orders.

Changes:

  • Add a regression test that runs table-mode template generation repeatedly from one schema with multiple indexes and asserts byte-identical output plus stable alphabetical index ordering.
  • Sort map keys before exposing keys/values helper output, so generated template output no longer depends on Go map iteration order.

Verification:

  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template -run TestWriterTableIndexValuesDeterministic -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template ./pkg/reflectutil -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/... -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./... -count=1
  • TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache make test
  • git diff --check

Refs #10

Fixes the template writer path where `values .Table.Indexes` was backed by raw Go map iteration, causing repeated code generation from the same schema to emit indexes in different orders. Changes: - Add a regression test that runs table-mode template generation repeatedly from one schema with multiple indexes and asserts byte-identical output plus stable alphabetical index ordering. - Sort map keys before exposing `keys`/`values` helper output, so generated template output no longer depends on Go map iteration order. Verification: - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template -run TestWriterTableIndexValuesDeterministic -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/template ./pkg/reflectutil -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./pkg/writers/... -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache go test ./... -count=1` - `TMPDIR=$PWD/.tmp GOCACHE=$PWD/go-cache make test` - `git diff --check` Refs #10
sgcommand added 1 commit 2026-07-19 13:57:33 +00:00
fix(template): make map helper ordering deterministic c2def00bcf
sgcommand merged commit 5c31deb630 into master 2026-07-19 14:11:11 +00:00
warkanum deleted branch fix/issue-10-deterministic-table-index 2026-07-19 19:24:41 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
hein (Hein) root sam sgcommand (SG Command) support warkanum (Warky)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/relspecgo#11
Delete Branch "fix/issue-10-deterministic-table-index"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?