Add native asset/file loader for binding local files as query parameters during migrate-apply #7
Closed
opened 2026-07-15 14:19:09 +00:00 by warkanum
·
1 comment
No Branch/Tag Specified
master
issue-20-job-files
issue-21-diff-roundtrip
issue-16-migration-script-count
issue-6-external-file-embedding
fix/bun-extra-fields-issue-4
v1.0.76
v1.0.75
v1.0.74
v1.0.73
v1.0.72
v1.0.71
v1.0.70
v1.0.69
v1.0.68
v1.0.67
v1.0.66
v1.0.65
v1.0.64
v1.0.63
v1.0.62
v1.0.61
v1.0.60
v1.0.59
v1.0.58
v1.0.57
v1.0.56
v1.0.55
v1.0.54
v1.0.53
v1.0.52
v1.0.51
v1.0.50
v1.0.49
v1.0.48
v1.0.47
v1.0.46
v1.0.45
v1.0.44
v1.0.43
v1.0.42
v1.0.41-1-gf4b8fc5
v1.0.41
v1.0.40
v1.0.38-2-gee88c07-1-gdc9172c-dirty
v1.0.38-2-gee88c07
v1.0.39
v1.0.38
v1.0.37-1-g480038d
v1.0.37
v1.0.36
v1.0.35
v1.0.34
v1.0.33
v1.0.32
v1.0.31
v1.0.30
v1.0.29
v1.0.28
v1.0.27
v1.0.26
v1.0.25
v1.0.24
v1.0.22
v1.0.21
v1.0.20
v1.0.19
v1.0.18
v1.0.17
v1.0.16
v1.0.15
v1.0.14
v1.0.13
v1.0.12
v1.0.11
v1.0.10
v1.0.9
v1.0.8
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
Labels
Clear labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wdevs/relspecgo#7
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Context
Related to #6, but proposing a different (preferred) design after more thought.
We need to load local binary/text asset files (e.g. report template
.md/.docxfiles undersql/vault/borg/data/templates/finance/) into Postgres columns (bytea/text) as part ofmake migrate-apply, alongside the existingrelspec scripts executeseeds/scripts pipeline.#6 proposed a SQL-comment
@embeddirective that gets textually inlined into the.sqlfile before execution. On reflection that's the weaker design: it still round-trips binary data through a SQL text literal (base64/dollar-quoting), which is exactly the kind of encoding/escaping surface area we're trying to avoid, and it couples file-reading logic into the SQL-text preprocessing step.Proposed feature instead: a native Go asset loader
Add a new loader/writer path (e.g.
relspec assets executealongside the existingrelspec scripts execute) that:assets.yamlcolocated with the asset files) describing, per file: the source file path, and the SQL statement/function call to invoke for it, with named placeholders for "file bytes" and "filename" (and any static extra columns/params the manifest supplies).pgxwith the file's bytes bound as a real query parameter ($1::byteaetc.) — never converted to a SQL text literal, so no base64/escaping, no size-related SQL parsing issues, and binary files stay byte-exact.[priority]_[sequence]_[name]ordering convention already used for.sqlscripts/seeds, so asset-loading steps can be interleaved correctly withscripts executein a singlemigrate-applyrun.Example manifest shape (illustrative, not prescriptive)
(
:bytesbound as[]bytevia pgx,:filenameas the base name offile— exact placeholder syntax up to whoever implements it, could reuse whatever variable-substitution conventionfuncspec/sqlexecalready has internally.)Relationship to #6
This supersedes #6 as our preferred direction — recommend closing #6 in favor of this one, or keeping both open as alternatives if there's a simpler use case elsewhere that still wants the lighter-weight
@embedtext-inlining behavior. Leaving that call to the maintainer.Workaround in the meantime
Same as noted in #6: generate the seed
.sqlliterals from source assets via a small script invoked beforemake migrate-apply, committed as a generated file, until native support exists.Implementation complete. PR #8: #8 — Branch: issue-7-native-asset-loader — Commit:
60c5cc40b2— All 14 unit tests pass, make build and make test clean.