Support external file embedding in seed/script SQL (for binary/text asset inlining) (redo) #6
Closed
opened 2026-07-15 14:10:28 +00:00 by warkanum
·
3 comments
No Branch/Tag Specified
master
issue-20-job-files
issue-21-diff-roundtrip
issue-16-migration-script-count
issue-6-external-file-embedding
fix/bun-extra-fields-issue-4
v1.0.76
v1.0.75
v1.0.74
v1.0.73
v1.0.72
v1.0.71
v1.0.70
v1.0.69
v1.0.68
v1.0.67
v1.0.66
v1.0.65
v1.0.64
v1.0.63
v1.0.62
v1.0.61
v1.0.60
v1.0.59
v1.0.58
v1.0.57
v1.0.56
v1.0.55
v1.0.54
v1.0.53
v1.0.52
v1.0.51
v1.0.50
v1.0.49
v1.0.48
v1.0.47
v1.0.46
v1.0.45
v1.0.44
v1.0.43
v1.0.42
v1.0.41-1-gf4b8fc5
v1.0.41
v1.0.40
v1.0.38-2-gee88c07-1-gdc9172c-dirty
v1.0.38-2-gee88c07
v1.0.39
v1.0.38
v1.0.37-1-g480038d
v1.0.37
v1.0.36
v1.0.35
v1.0.34
v1.0.33
v1.0.32
v1.0.31
v1.0.30
v1.0.29
v1.0.28
v1.0.27
v1.0.26
v1.0.25
v1.0.24
v1.0.22
v1.0.21
v1.0.20
v1.0.19
v1.0.18
v1.0.17
v1.0.16
v1.0.15
v1.0.14
v1.0.13
v1.0.12
v1.0.11
v1.0.10
v1.0.9
v1.0.8
v1.0.7
v1.0.6
v1.0.5
v1.0.4
v1.0.3
v1.0.2
v1.0.1
v1.0.0
Labels
Clear labels
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
The priority is critical
Priority
High
The priority is high
Priority
Low
The priority is low
Priority
Medium
The priority is medium
Reviewed
Confirmed
Issue has been confirmed
Reviewed
Duplicate
This issue or pull request already exists
Reviewed
Invalid
Invalid issue
Reviewed
Won't Fix
This issue won't be fixed
Status
Abandoned
Somebody has started to work on this but abandoned work
Status
Blocked
Something is blocking this issue or pull request
Status
Need More Info
Feedback is required to reproduce issue or to continue work
Breaking change that won't be backward compatible
Something is not working
Documentation changes
Improve existing functionality
New functionality
This is security issue
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No labels
Milestone
No items
No Milestone
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: wdevs/relspecgo#6
Reference in New Issue
Block a user
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Problem
Seed/script SQL files executed via
relspec scripts execute(pkg/writers/sqlexec + pkg/readers/sqldir) are read and executed verbatim — there is no mechanism to pull the content of an external file (e.g. a.mdor.docxasset sitting alongside the SQL) into the script at execution time.Concrete use case (origin project): we want to store report template source files as real files on disk —
sql/vault/borg/data/templates/finance/*.mdand*.docx— and have a seed script (sql/vault/borg/seeds/300_2_template_seed_data.sql) insert their content into abytea/textcolumn (viaorg.save_filepointer) duringmake migrate-apply. Today the only way to do this is to hand-encode the file content as a SQL literal (dollar-quoted text, ordecode('<base64>', 'base64')for binary) and commit that generated SQL — which means the actual template file and the SQL literal can drift out of sync, and binary files bloat/mangle badly as hand-maintained SQL.Requested feature
Support a directive in seed/script
.sqlfiles that tells the reader to inline an external file's content before sending the script to Postgres, e.g. a leading comment pragma:mode=text— file read as UTF-8 text, safely escaped/dollar-quoted into the substituted value.mode=base64— file read as bytes, base64-encoded, suitable fordecode(:var, 'base64')::bytea..sqlfile's own directory (so seeds can reference a siblingdata/folder without hardcoding absolute paths).pkg/readers/sqldirand therelspec scripts executecodepath (pkg/writers/sqlexec).Alternative considered
pg_read_file/pg_read_binary_fileinside the SQL itself was considered, but requires the asset to exist on the Postgres server's filesystem (not the migration client's), needs elevated privileges, and doesn't work against managed/remote Postgres — not viable for this use case.Workaround in the meantime
We'll generate the seed
.sqlfile's literals from the source assets via a small script invoked beforemake migrate-apply, and commit the generated file. Native support in relspec would let us drop that generation step and keep the seed script and the source asset as a single source of truth.warkanum referenced this issue2026-07-16 19:45:01 +00:00
Rather go with: #7
Maybe we can add this later.
Changed my mind. We can combine this with the asset loaded
Support external file embedding in seed/script SQL (for binary/text asset inlining)to Support external file embedding in seed/script SQL (for binary/text asset inlining) (redo)Implementation complete for issue #6.
PR: #12
Branch: issue-6-external-file-embedding
Commit:
1bcdf29206Summary:
-- @embed:directives for seed/script SQL.mode=textas escaped SQL text literals andmode=base64as base64 SQL literals fordecode(..., 'base64').Verification:
git diff --check-> passed, no outputgo test ./pkg/assetloader ./pkg/readers/sqldir ./pkg/writers/sqlexec-> passedgo test ./...-> passed