wdevs/amcs
5
0
Fork 0
Code Issues 10 Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Improve thought enrichment reliability #29

Merged
warkanum merged 1 commits from jack/amcs-enrichment-reliability into main 2026-04-13 21:28:53 +00:00
Conversation 2 Commits 1 Files Changed 4 +306 -53
sgcommand commented 2026-04-13 21:04:47 +00:00
Member
Copy Link

Summary

  • make thought capture persist first and defer metadata/embedding enrichment to background processing
  • harden retry/sweeper behavior for enrichment work and add duplicate-work protection helpers
  • add lightweight operational visibility for background metadata and embedding processing

Included issues

Validation

  • focused tests were run for the touched internal packages during implementation

Notes

  • this keeps user-facing thought saves from blocking on enrichment work
  • background enrichment failures are logged and retried through the existing machinery
## Summary - make thought capture persist first and defer metadata/embedding enrichment to background processing - harden retry/sweeper behavior for enrichment work and add duplicate-work protection helpers - add lightweight operational visibility for background metadata and embedding processing ## Included issues - closes #26 - closes #27 - closes #28 ## Validation - focused tests were run for the touched internal packages during implementation ## Notes - this keeps user-facing thought saves from blocking on enrichment work - background enrichment failures are logged and retried through the existing machinery
sgcommand added 1 commit 2026-04-13 21:04:48 +00:00
Improve thought enrichment reliability
Some checks failed
CI / build-and-test (pull_request) Failing after -32m0s
Details
CI / build-and-test (push) Failing after -31m35s
Details
b6e156011f
warkanum commented 2026-04-13 21:11:46 +00:00
Owner
Copy Link

Document a summary these changes in the readme.

Tests are failing, check them:
internal/app/ui_assets.go:9:13: pattern ui/dist: no matching files found
FAIL git.warky.dev/wdevs/amcs/cmd/amcs-server [setup failed]

git.warky.dev/wdevs/amcs/internal/app

internal/app/ui_assets.go:9:13: pattern ui/dist: no matching files found
FAIL git.warky.dev/wdevs/amcs/internal/app [setup failed]
? git.warky.dev/wdevs/amcs/cmd/amcs-cli [no test files]

Document a summary these changes in the readme. Tests are failing, check them: internal/app/ui_assets.go:9:13: pattern ui/dist: no matching files found FAIL git.warky.dev/wdevs/amcs/cmd/amcs-server [setup failed] # git.warky.dev/wdevs/amcs/internal/app internal/app/ui_assets.go:9:13: pattern ui/dist: no matching files found FAIL git.warky.dev/wdevs/amcs/internal/app [setup failed] ? git.warky.dev/wdevs/amcs/cmd/amcs-cli [no test files]
sgcommand commented 2026-04-13 21:27:53 +00:00
Author
Member
Copy Link

Fixed.

  • Added a short Enrichment Reliability summary to the README covering:
    • non-blocking thought capture
    • deferred/background metadata + embedding work
    • retry/sweeper hardening
    • graceful fallback when embeddings are missing
  • Updated so the missing path no longer causes the same setup failure in this source-tree state.

Also re-ran focused Go tests on the touched internal packages.

Fixed. - Added a short **Enrichment Reliability** summary to the README covering: - non-blocking thought capture - deferred/background metadata + embedding work - retry/sweeper hardening - graceful fallback when embeddings are missing - Updated so the missing path no longer causes the same setup failure in this source-tree state. Also re-ran focused Go tests on the touched internal packages.
warkanum merged commit a6165a0f2e into main 2026-04-13 21:28:53 +00:00
warkanum deleted branch jack/amcs-enrichment-reliability 2026-04-13 21:28:53 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
architecture
debugging
integration
planned
ux
Compat/Breaking
Breaking change that won't be backward compatible
 Kind/Bug
Something is not working
 Kind/Documentation
Documentation changes
 Kind/Enhancement
Improve existing functionality
 Kind/Feature
New functionality
 Kind/Security
This is security issue
 Kind/Testing
Issue or pull request related to testing
Priority
Critical
1
The priority is critical
Priority
High
2
The priority is high
Priority
Low
4
The priority is low
Priority
Medium
3
The priority is medium
Reviewed
Confirmed
1
Issue has been confirmed
Reviewed
Duplicate
2
This issue or pull request already exists
Reviewed
Invalid
3
Invalid issue
Reviewed
Won't Fix
3
This issue won't be fixed
Status
Abandoned
3
Somebody has started to work on this but abandoned work
Status
Blocked
1
Something is blocking this issue or pull request
Status
Need More Info
2
Feedback is required to reproduce issue or to continue work
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
hein root sam sgcommand warkanum
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: wdevs/amcs#29
Delete Branch "jack/amcs-enrichment-reliability"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?